collect_tokens_trailing_token cleanups by nnethercote · Pull Request #127902 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation10 Commits5 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
More cleanups I made while understanding the code for processing cfg_attr, to fix test failures in #124141.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
This comment has been minimized.
r=me after updating the doc example to not fail.
@rustbot author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
I fixed the doc failure and rebased.
@bors r=petrochenkov
📌 Commit 4b20da7 has been approved by petrochenkov
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…g_token-cleanups, r=petrochenkov
collect_tokens_trailing_token cleanups
More cleanups I made while understanding the code for processing cfg_attr, to fix test failures in rust-lang#124141.
r? @petrochenkov
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
The Options within the ReplaceRanges within the hashmap are always
None. This PR omits them and inserts them when they are extracted from
the hashmap.
It's no shorter than ret.attrs(), and ret.attrs() is used multiple
times earlier in the function.
This puts it just before the replace_ranges initialization, which
makes sense because the two variables are closely related.
Currently in collect_tokens_trailing_token, start_pos and end_pos
are 1-indexed by replace_ranges is 0-indexed, which is really
confusing. Making them both 0-indexed makes debugging much easier.
Adding details, clarifying lots of little things, etc. In particular, the commit adds details of an example. I find this very helpful, because it's taken me a long time to understand how this code works.
I added a reason to the ignore comment, hopefully that should fix the problem.
@bors r=petrochenkov
📌 Commit 1dd566a has been approved by petrochenkov
It is now in the queue for this repository.
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#121533 (Handle .init_array link_section specially on wasm)
- rust-lang#127825 (Migrate
macos-fat-archive,manual-linkandarchive-duplicate-namesrun-maketests to rmake) - rust-lang#127891 (Tweak suggestions when using incorrect type of enum literal)
- rust-lang#127902 (
collect_tokens_trailing_tokencleanups) - rust-lang#127928 (Migrate
lto-smoke-candlink-path-orderrun-maketests to rmake) - rust-lang#127935 (Change
binary_asm_labelsto only fire on x86 and x86_64) - rust-lang#127953 ([compiletest] Search *.a when getting dynamic libraries on AIX)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#127902 - nnethercote:collect_tokens_trailing_token-cleanups, r=petrochenkov
collect_tokens_trailing_token cleanups
More cleanups I made while understanding the code for processing cfg_attr, to fix test failures in rust-lang#124141.
r? @petrochenkov
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.