Improve diagnostic-related lints: untranslatable_diagnostic & diagnostic_outside_of_impl by GrigorenkoPV · Pull Request #128941 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits3 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Summary:

• Made untranslatable_diagnostic point to problematic arguments instead of the function call
  (I found this misleading while working on some A-translation PRs: my first impression was that
  the methods themselves were not translation-aware and needed to be changed,
  while in reality the problem was with the hardcoded strings passed as arguments).
• Made the shared pass of untranslatable_diagnostic & diagnostic_outside_of_impl more efficient.

@rustbot label D-imprecise-spans A-translation

and not the function/method call

1. Decouple them.
2. Make logic around diagnostic_outside_of_impl's early exits simpler.
3. Make untranslatable_diagnostic run one loop instead of two and not allocate an intermediate vec.
4. Overall, reduce the amount of code executed when the lints do not end up firing.

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

A-translation

Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic

D-imprecise-spans

Diagnostics: spans don't point to exactly the erroneous code

labels

Aug 10, 2024

📌 Commit e94a4ee has been approved by davidtwco

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 21, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 21, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#127279 (use old ctx if has same expand environment during decode span)
• rust-lang#127945 (Implement debug_more_non_exhaustive)
• rust-lang#128941 ( Improve diagnostic-related lints: untranslatable_diagnostic & diagnostic_outside_of_impl)
• rust-lang#129070 (Point at explicit 'static obligations on a trait)
• rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
• rust-lang#129231 (improve submodule updates)
• rust-lang#129264 (Update library/Cargo.toml in weekly job)
• rust-lang#129284 (rustdoc: animate the :target highlight)
• rust-lang#129302 (compiletest: use std::fs::remove_dir_all now that it is available)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 21, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#127279 (use old ctx if has same expand environment during decode span)
• rust-lang#127945 (Implement debug_more_non_exhaustive)
• rust-lang#128941 ( Improve diagnostic-related lints: untranslatable_diagnostic & diagnostic_outside_of_impl)
• rust-lang#129070 (Point at explicit 'static obligations on a trait)
• rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
• rust-lang#129231 (improve submodule updates)
• rust-lang#129264 (Update library/Cargo.toml in weekly job)
• rust-lang#129284 (rustdoc: animate the :target highlight)
• rust-lang#129302 (compiletest: use std::fs::remove_dir_all now that it is available)

r? @ghost @rustbot modify labels: rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Aug 22, 2024

…ints, r=davidtwco

Improve diagnostic-related lints: untranslatable_diagnostic & diagnostic_outside_of_impl

Summary:

• Made untranslatable_diagnostic point to problematic arguments instead of the function call (I found this misleading while working on some A-translation PRs: my first impression was that the methods themselves were not translation-aware and needed to be changed, while in reality the problem was with the hardcoded strings passed as arguments).
• Made the shared pass of untranslatable_diagnostic & diagnostic_outside_of_impl more efficient.

@rustbot label D-imprecise-spans A-translation

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 22, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#127279 (use old ctx if has same expand environment during decode span)
• rust-lang#127945 (Implement debug_more_non_exhaustive)
• rust-lang#128941 ( Improve diagnostic-related lints: untranslatable_diagnostic & diagnostic_outside_of_impl)
• rust-lang#129070 (Point at explicit 'static obligations on a trait)
• rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
• rust-lang#129231 (improve submodule updates)
• rust-lang#129264 (Update library/Cargo.toml in weekly job)
• rust-lang#129284 (rustdoc: animate the :target highlight)
• rust-lang#129302 (compiletest: use std::fs::remove_dir_all now that it is available)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Aug 22, 2024

Rollup merge of rust-lang#128941 - GrigorenkoPV:internal-diagnostic-lints, r=davidtwco

Improve diagnostic-related lints: untranslatable_diagnostic & diagnostic_outside_of_impl

Summary:

• Made untranslatable_diagnostic point to problematic arguments instead of the function call (I found this misleading while working on some A-translation PRs: my first impression was that the methods themselves were not translation-aware and needed to be changed, while in reality the problem was with the hardcoded strings passed as arguments).
• Made the shared pass of untranslatable_diagnostic & diagnostic_outside_of_impl more efficient.

@rustbot label D-imprecise-spans A-translation

Labels

A-translation

Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic

D-imprecise-spans

Diagnostics: spans don't point to exactly the erroneous code

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.