improve submodule updates by onur-ozkan · Pull Request #129231 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits4 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
During config parsing, some bootstrap logic (e.g., download-ci-llvm) checks certain sources (for download-ci-llvm, it's src/llvm-project) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the update_submodule function from the Build to Config, so we can access to it during the parsing process.
Closes #122787
During config parsing, some bootstrap logic (e.g., download-ci-llvm) checks certain sources
and acts based on their state. This means that if path is a git submodule, bootstrap needs to
update it before checking its state. Otherwise it may make incorrect assumptions by relying on
outdated sources. To enable submodule updates during config parsing, we need to move the update_submodule
function from the Build to Config instance, so we can access to it during the parsing process.
Signed-off-by: onur-ozkan work@onurozkan.dev
Signed-off-by: onur-ozkan work@onurozkan.dev
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.
This PR modifies src/bootstrap/src/core/config.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
Signed-off-by: onur-ozkan work@onurozkan.dev
📌 Commit 1ca2708 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…es, r=Mark-Simulacrum
improve submodule updates
During config parsing, some bootstrap logic (e.g., download-ci-llvm) checks certain sources (for download-ci-llvm, it's src/llvm-project) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the update_submodule function from the Build to Config, so we can access to it during the parsing process.
Closes rust-lang#122787
bors added a commit to rust-lang-ci/rust that referenced this pull request
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Signed-off-by: onur-ozkan work@onurozkan.dev
📌 Commit d2d8fa4 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…es, r=Mark-Simulacrum
improve submodule updates
During config parsing, some bootstrap logic (e.g., download-ci-llvm) checks certain sources (for download-ci-llvm, it's src/llvm-project) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the update_submodule function from the Build to Config, so we can access to it during the parsing process.
Closes rust-lang#122787
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- rust-lang#127623 (fix: fs::remove_dir_all: treat internal ENOENT as success)
- rust-lang#128627 (Special case DUMMY_SP to emit line 0/column 0 locations on DWARF platforms.)
- rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
- rust-lang#129190 (Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
- rust-lang#129231 (improve submodule updates)
- rust-lang#129257 (Allow rust staticlib to work with MSVC's /WHOLEARCHIVE)
r? @ghost
@rustbot modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…es, r=Mark-Simulacrum
improve submodule updates
During config parsing, some bootstrap logic (e.g., download-ci-llvm) checks certain sources (for download-ci-llvm, it's src/llvm-project) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the update_submodule function from the Build to Config, so we can access to it during the parsing process.
Closes rust-lang#122787
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- rust-lang#127623 (fix: fs::remove_dir_all: treat internal ENOENT as success)
- rust-lang#128627 (Special case DUMMY_SP to emit line 0/column 0 locations on DWARF platforms.)
- rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
- rust-lang#129190 (Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
- rust-lang#129231 (improve submodule updates)
- rust-lang#129284 (rustdoc: animate the
:targethighlight)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- rust-lang#127623 (fix: fs::remove_dir_all: treat internal ENOENT as success)
- rust-lang#128627 (Special case DUMMY_SP to emit line 0/column 0 locations on DWARF platforms.)
- rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
- rust-lang#129190 (Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
- rust-lang#129231 (improve submodule updates)
- rust-lang#129284 (rustdoc: animate the
:targethighlight)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#127279 (use old ctx if has same expand environment during decode span)
- rust-lang#127945 (Implement
debug_more_non_exhaustive) - rust-lang#128941 ( Improve diagnostic-related lints:
untranslatable_diagnostic&diagnostic_outside_of_impl) - rust-lang#129070 (Point at explicit
'staticobligations on a trait) - rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
- rust-lang#129231 (improve submodule updates)
- rust-lang#129264 (Update
library/Cargo.tomlin weekly job) - rust-lang#129284 (rustdoc: animate the
:targethighlight) - rust-lang#129302 (compiletest: use
std::fs::remove_dir_allnow that it is available)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#127279 (use old ctx if has same expand environment during decode span)
- rust-lang#127945 (Implement
debug_more_non_exhaustive) - rust-lang#128941 ( Improve diagnostic-related lints:
untranslatable_diagnostic&diagnostic_outside_of_impl) - rust-lang#129070 (Point at explicit
'staticobligations on a trait) - rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
- rust-lang#129231 (improve submodule updates)
- rust-lang#129264 (Update
library/Cargo.tomlin weekly job) - rust-lang#129284 (rustdoc: animate the
:targethighlight) - rust-lang#129302 (compiletest: use
std::fs::remove_dir_allnow that it is available)
r? @ghost
@rustbot modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…es, r=Mark-Simulacrum
improve submodule updates
During config parsing, some bootstrap logic (e.g., download-ci-llvm) checks certain sources (for download-ci-llvm, it's src/llvm-project) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the update_submodule function from the Build to Config, so we can access to it during the parsing process.
Closes rust-lang#122787
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#127279 (use old ctx if has same expand environment during decode span)
- rust-lang#127945 (Implement
debug_more_non_exhaustive) - rust-lang#128941 ( Improve diagnostic-related lints:
untranslatable_diagnostic&diagnostic_outside_of_impl) - rust-lang#129070 (Point at explicit
'staticobligations on a trait) - rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
- rust-lang#129231 (improve submodule updates)
- rust-lang#129264 (Update
library/Cargo.tomlin weekly job) - rust-lang#129284 (rustdoc: animate the
:targethighlight) - rust-lang#129302 (compiletest: use
std::fs::remove_dir_allnow that it is available)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#129231 - onur-ozkan:improve-submodule-updates, r=Mark-Simulacrum
improve submodule updates
During config parsing, some bootstrap logic (e.g., download-ci-llvm) checks certain sources (for download-ci-llvm, it's src/llvm-project) and acts based on their state. This means that if path is a git submodule, bootstrap needs to update it before checking its state. Otherwise it may make incorrect assumptions by relying on outdated sources. To enable submodule updates during config parsing, we need to move the update_submodule function from the Build to Config, so we can access to it during the parsing process.
Closes rust-lang#122787
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)