Implement debug_more_non_exhaustive by tgross35 · Pull Request #127945 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This implements the ACP at rust-lang/libs-team#248, adding .finish_non_exhaustive() for DebugTuple, DebugSet, DebugList, and DebugMap.

Also used this as an opportunity to make some documentation and tests more readable by using raw strings instead of escaped quotes.

Tracking issue: #127942

r? @Nilstrieb

rustbot has assigned @Nilstrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Jul 19, 2024

tgross35 changed the titleDebug more non exhaustive Implement debug_more_non_exhaustive

Jul 19, 2024

This was referenced

Jul 19, 2024

Noratrieb added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 21, 2024

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jul 21, 2024

This comment has been minimized.

There are quite a few uses of escaped quotes. Turn these into raw strings within documentation and tests to make things easier to read.

Add a .finish_non_exhaustive() method to DebugTuple, DebugSet, DebugList, and DebugMap. This indicates that the structures have remaining items with ...

This implements the ACP at <rust-lang/libs-team#248>.

📌 Commit 827970e has been approved by Noratrieb

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 21, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 21, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#127279 (use old ctx if has same expand environment during decode span)
• rust-lang#127945 (Implement debug_more_non_exhaustive)
• rust-lang#128941 ( Improve diagnostic-related lints: untranslatable_diagnostic & diagnostic_outside_of_impl)
• rust-lang#129070 (Point at explicit 'static obligations on a trait)
• rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
• rust-lang#129231 (improve submodule updates)
• rust-lang#129264 (Update library/Cargo.toml in weekly job)
• rust-lang#129284 (rustdoc: animate the :target highlight)
• rust-lang#129302 (compiletest: use std::fs::remove_dir_all now that it is available)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 21, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#127279 (use old ctx if has same expand environment during decode span)
• rust-lang#127945 (Implement debug_more_non_exhaustive)
• rust-lang#128941 ( Improve diagnostic-related lints: untranslatable_diagnostic & diagnostic_outside_of_impl)
• rust-lang#129070 (Point at explicit 'static obligations on a trait)
• rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
• rust-lang#129231 (improve submodule updates)
• rust-lang#129264 (Update library/Cargo.toml in weekly job)
• rust-lang#129284 (rustdoc: animate the :target highlight)
• rust-lang#129302 (compiletest: use std::fs::remove_dir_all now that it is available)

r? @ghost @rustbot modify labels: rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Aug 22, 2024

…, r=Noratrieb

Implement debug_more_non_exhaustive

This implements the ACP at rust-lang/libs-team#248, adding .finish_non_exhaustive() for DebugTuple, DebugSet, DebugList, and DebugMap.

Also used this as an opportunity to make some documentation and tests more readable by using raw strings instead of escaped quotes.

Tracking issue: rust-lang#127942

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 22, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#127279 (use old ctx if has same expand environment during decode span)
• rust-lang#127945 (Implement debug_more_non_exhaustive)
• rust-lang#128941 ( Improve diagnostic-related lints: untranslatable_diagnostic & diagnostic_outside_of_impl)
• rust-lang#129070 (Point at explicit 'static obligations on a trait)
• rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
• rust-lang#129231 (improve submodule updates)
• rust-lang#129264 (Update library/Cargo.toml in weekly job)
• rust-lang#129284 (rustdoc: animate the :target highlight)
• rust-lang#129302 (compiletest: use std::fs::remove_dir_all now that it is available)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Aug 22, 2024

Rollup merge of rust-lang#127945 - tgross35:debug-more-non-exhaustive, r=Noratrieb

Implement debug_more_non_exhaustive

This implements the ACP at rust-lang/libs-team#248, adding .finish_non_exhaustive() for DebugTuple, DebugSet, DebugList, and DebugMap.

Also used this as an opportunity to make some documentation and tests more readable by using raw strings instead of escaped quotes.

Tracking issue: rust-lang#127942

tgross35 deleted the debug-more-non-exhaustive branch

August 22, 2024 08:34

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.