Fix is_val_statically_known for floats by beetrees · Pull Request #129173 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits1 Checks12 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The LLVM intrinsic name for floats differs from the LLVM type name, so handle them explicitly. Also adds support for f16 and f128.
f16/f128 tracking issue: #116909
r? @cjgillot
rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
| | TypeKind::Float |
|---|
| | TypeKind::Double |
| | TypeKind::FP128 => { |
| let type_str = match kind { |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This double match is really awkward. I'd honestly rather the code duplication, or maybe make the _ => branch into a return so you can uplift that let type_str out of the outer match. Also worth leaving a note why some of these are special cased.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've refactored it to be a single match statement.
I'll try closing and reopening
📌 Commit 9bc7cea has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
tgross35 added a commit to tgross35/rust that referenced this pull request
…=compiler-errors
Fix is_val_statically_known for floats
The LLVM intrinsic name for floats differs from the LLVM type name, so handle them explicitly. Also adds support for f16 and f128.
f16/f128 tracking issue: rust-lang#116909
tgross35 added a commit to tgross35/rust that referenced this pull request
…=compiler-errors
Fix is_val_statically_known for floats
The LLVM intrinsic name for floats differs from the LLVM type name, so handle them explicitly. Also adds support for f16 and f128.
f16/f128 tracking issue: rust-lang#116909
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- rust-lang#128786 (Detect multiple crate versions on method not found)
- rust-lang#128982 (Re-enable more debuginfo tests on Windows)
- rust-lang#128989 (Emit an error for invalid use of the linkage attribute)
- rust-lang#129115 (Re-enable
dump-ice-to-diskfor Windows) - rust-lang#129164 (Use
ar_archive_writerfor writing COFF import libs on all backends) - rust-lang#129167 (mir/pretty: use
Optioninstead ofEither<Once, Empty>) - rust-lang#129168 (Return correct HirId when finding body owner in diagnostics)
- rust-lang#129173 (Fix
is_val_statically_knownfor floats) - rust-lang#129185 (Port
run-make/libtest-json/validate_json.pyto Rust)
r? @ghost
@rustbot modify labels: rollup
tgross35 added a commit to tgross35/rust that referenced this pull request
…=compiler-errors
Fix is_val_statically_known for floats
The LLVM intrinsic name for floats differs from the LLVM type name, so handle them explicitly. Also adds support for f16 and f128.
f16/f128 tracking issue: rust-lang#116909
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- rust-lang#128771 (Stabilize
unsafe_attributes) - rust-lang#128982 (Re-enable more debuginfo tests on Windows)
- rust-lang#129115 (Re-enable
dump-ice-to-diskfor Windows) - rust-lang#129173 (Fix
is_val_statically_knownfor floats) - rust-lang#129185 (Port
run-make/libtest-json/validate_json.pyto Rust) - rust-lang#129190 (Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 5 pull requests
Successful merges:
- rust-lang#129164 (Use
ar_archive_writerfor writing COFF import libs on all backends) - rust-lang#129173 (Fix
is_val_statically_knownfor floats) - rust-lang#129185 (Port
run-make/libtest-json/validate_json.pyto Rust) - rust-lang#129203 (Use cnum for extern crate data key)
- rust-lang#129221 (Remove JohnTitor from review rotation)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#129173 - beetrees:statically-known-float, r=compiler-errors
Fix is_val_statically_known for floats
The LLVM intrinsic name for floats differs from the LLVM type name, so handle them explicitly. Also adds support for f16 and f128.
f16/f128 tracking issue: rust-lang#116909
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.