Port run-make/libtest-json/validate_json.py to Rust by Zalathar · Pull Request #129185 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This is a trivial Python script that simply tries to parse each line of stdin (i.e. the test process output) as JSON, to verify that the overall output is JSON Lines.
We can perform the same check directly in rmake.rs using serde_json.
r? @jieyouxu
This is a trivial Python script that simply tries to parse each line of stdin (i.e. the test process output) as JSON, to verify that the overall output is JSON Lines.
We can perform the same check directly in rmake.rs using serde_json.
This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.
cc @jieyouxu
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. Lol. Thanks!
Feel free to r=me after CI is green.
@bors delegate+ rollup
✌️ @Zalathar, you can now approve this pull request!
If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu
📌 Commit 3116db6 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
tgross35 added a commit to tgross35/rust that referenced this pull request
Port run-make/libtest-json/validate_json.py to Rust
This is a trivial Python script that simply tries to parse each line of stdin (i.e. the test process output) as JSON, to verify that the overall output is JSON Lines.
We can perform the same check directly in rmake.rs using serde_json.
r? @jieyouxu
tgross35 added a commit to tgross35/rust that referenced this pull request
Port run-make/libtest-json/validate_json.py to Rust
This is a trivial Python script that simply tries to parse each line of stdin (i.e. the test process output) as JSON, to verify that the overall output is JSON Lines.
We can perform the same check directly in rmake.rs using serde_json.
r? @jieyouxu
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- rust-lang#128786 (Detect multiple crate versions on method not found)
- rust-lang#128982 (Re-enable more debuginfo tests on Windows)
- rust-lang#128989 (Emit an error for invalid use of the linkage attribute)
- rust-lang#129115 (Re-enable
dump-ice-to-diskfor Windows) - rust-lang#129164 (Use
ar_archive_writerfor writing COFF import libs on all backends) - rust-lang#129167 (mir/pretty: use
Optioninstead ofEither<Once, Empty>) - rust-lang#129168 (Return correct HirId when finding body owner in diagnostics)
- rust-lang#129173 (Fix
is_val_statically_knownfor floats) - rust-lang#129185 (Port
run-make/libtest-json/validate_json.pyto Rust)
r? @ghost
@rustbot modify labels: rollup
tgross35 added a commit to tgross35/rust that referenced this pull request
Port run-make/libtest-json/validate_json.py to Rust
This is a trivial Python script that simply tries to parse each line of stdin (i.e. the test process output) as JSON, to verify that the overall output is JSON Lines.
We can perform the same check directly in rmake.rs using serde_json.
r? @jieyouxu
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- rust-lang#128771 (Stabilize
unsafe_attributes) - rust-lang#128982 (Re-enable more debuginfo tests on Windows)
- rust-lang#129115 (Re-enable
dump-ice-to-diskfor Windows) - rust-lang#129173 (Fix
is_val_statically_knownfor floats) - rust-lang#129185 (Port
run-make/libtest-json/validate_json.pyto Rust) - rust-lang#129190 (Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 5 pull requests
Successful merges:
- rust-lang#129164 (Use
ar_archive_writerfor writing COFF import libs on all backends) - rust-lang#129173 (Fix
is_val_statically_knownfor floats) - rust-lang#129185 (Port
run-make/libtest-json/validate_json.pyto Rust) - rust-lang#129203 (Use cnum for extern crate data key)
- rust-lang#129221 (Remove JohnTitor from review rotation)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#129185 - Zalathar:validate-json, r=jieyouxu
Port run-make/libtest-json/validate_json.py to Rust
This is a trivial Python script that simply tries to parse each line of stdin (i.e. the test process output) as JSON, to verify that the overall output is JSON Lines.
We can perform the same check directly in rmake.rs using serde_json.
r? @jieyouxu
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
Advise against removing the remaining Python scripts from tests/run-make
After some recent PRs (e.g. rust-lang#129185), there are only two Python scripts left in tests/run-make.
Having come so far, it's tempting to try to get rid of the remaining ones. But after trying that myself, I've come to the conclusion that it's not worth the extra hassle, especially if it means pulling in an XML-parsing crate just for one test.
This PR therefore leaves behind a few signpost comments to explain why getting rid of these particular scripts has low value.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Advise against removing the remaining Python scripts from tests/run-make
After some recent PRs (e.g. rust-lang#129185), there are only two Python scripts left in tests/run-make.
Having come so far, it's tempting to try to get rid of the remaining ones. But after trying that myself, I've come to the conclusion that it's not worth the extra hassle, especially if it means pulling in an XML-parsing crate just for one test.
This PR therefore leaves behind a few signpost comments to explain why getting rid of these particular scripts has low value.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#129387 - Zalathar:python-apologia, r=jieyouxu
Advise against removing the remaining Python scripts from tests/run-make
After some recent PRs (e.g. rust-lang#129185), there are only two Python scripts left in tests/run-make.
Having come so far, it's tempting to try to get rid of the remaining ones. But after trying that myself, I've come to the conclusion that it's not worth the extra hassle, especially if it means pulling in an XML-parsing crate just for one test.
This PR therefore leaves behind a few signpost comments to explain why getting rid of these particular scripts has low value.
Labels
Area: port run-make Makefiles to rmake.rs
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.