Simplify DestProp memory management by nnethercote · Pull Request #129720 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits4 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

The DestProp MIR pass has some convoluted memory management. This PR simplifies it.

r? @davidtwco

It doesn't need to be in there, and the move simplifies lifetimes.

It's not necessary, and just complicates things.

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Aug 29, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@JakobDegen is probably the best reviewer, but I'm not sure if they have review permissions.

By making it own the index maps, instead of holding references to them. This requires moving the free function find_candidate into Candidate::reset_and_find. It lets the 'alloc lifetime be removed everywhere that still has it.

📌 Commit 1be2204 has been approved by cjgillot

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 1, 2024

I think this is a small, innocuous change and can be rolled up safely.

@bors rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 5, 2024

… r=cjgillot

Simplify DestProp memory management

The DestProp MIR pass has some convoluted memory management. This PR simplifies it.

r? @davidtwco

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

…iaskrgr

Rollup of 6 pull requests

Successful merges:

• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#129624 (Adjust memchr pinning and run cargo update)
• rust-lang#129720 (Simplify DestProp memory management)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129891 (Do not request sanitizers for naked functions)
• rust-lang#129938 (Elaborate on deriving vs implementing Copy)

Failed merges:

• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 5, 2024

… r=cjgillot

Simplify DestProp memory management

The DestProp MIR pass has some convoluted memory management. This PR simplifies it.

r? @davidtwco

This was referenced

Sep 5, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#128820 (fix: get llvm type of global val)
• rust-lang#129028 (impl_trait_overcaptures: Don't worry about uncaptured contravariant lifetimes if they outlive a captured lifetime)
• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
• rust-lang#129706 (Rename dump of coroutine by-move-body to be more consistent, fix ICE in dump_mir)
• rust-lang#129720 (Simplify DestProp memory management)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129938 (Elaborate on deriving vs implementing Copy)
• rust-lang#129973 (run_make_support: rename Command::stdin to stdin_buf and add std{in,out,err} config helpers)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#128820 (fix: get llvm type of global val)
• rust-lang#129028 (impl_trait_overcaptures: Don't worry about uncaptured contravariant lifetimes if they outlive a captured lifetime)
• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
• rust-lang#129706 (Rename dump of coroutine by-move-body to be more consistent, fix ICE in dump_mir)
• rust-lang#129720 (Simplify DestProp memory management)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129938 (Elaborate on deriving vs implementing Copy)
• rust-lang#129973 (run_make_support: rename Command::stdin to stdin_buf and add std{in,out,err} config helpers)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

Rollup merge of rust-lang#129720 - nnethercote:simplify-dest_prop-mm, r=cjgillot

Simplify DestProp memory management

The DestProp MIR pass has some convoluted memory management. This PR simplifies it.

r? @davidtwco

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.