Unify scraped examples with other code examples by GuillaumeGomez · Pull Request #129796 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation25 Commits12 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Fixes #129763.

This first PR both fixes #129763 but also unifies buttons display for code examples:

You can test it here and here.

I'm planning to send a follow-up to make the buttons generated in JS directly (or I can do it in this PR directly if you prefer).

cc @willcrichton
r? @notriddle

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

labels

Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to keep the backline character.

I'm happy to have the button-js change as a separate PR. For now, let's just fix the CSS.

This spacing is already there in the current version. It's the same for "normal" code examples with line numbers too:

The spacing isn’t the point. The point is the rounded corners.

Oooooooh. Totally missed it. Fixing it and adding a test for it as well.

So it was actually an already existing bug. Fixed it in this PR anyway. Also updated online docs so you can check the result.

This seems wrong.

Good catch! Fixed this bug as well.

Still comes out wrong on iOS. The code block is below the lines numbers instead of beside it.

The screen of the iPhone is really small. ^^'

I needed to reduce the width to less than 400px to finally be able to see the bug. I updated the demo, can you give it another try please?

Corners still seem wrong.

At least it allowed me to realize that I forgot to add a GUI test for scraped examples code blocks. Now it's done as well.

The corners seem fine now, but I still think it looks a bit weird.

When it’s in collapsed mode, the bottom has a fade-out effect to indicate this. It’s supposed to have it on top, too, but it’s missing.

📌 Commit 7157f98 has been approved by notriddle

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 3, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Sep 3, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 3, 2024

…llaumeGomez

Rollup of 7 pull requests

Successful merges:

• rust-lang#127021 (Add target support for RTEMS Arm)
• rust-lang#128871 (bypass linker configuration and cross target check for specific commands)
• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#129706 (Rename dump of coroutine by-move-body to be more consistent, fix ICE in dump_mir)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129939 (explain why Rvalue::Len still exists)

r? @ghost @rustbot modify labels: rollup

tgross35 added a commit to tgross35/rust that referenced this pull request

Sep 4, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 4, 2024

Rollup of 8 pull requests

Successful merges:

• rust-lang#101339 (enable -Zrandomize-layout in debug CI builds )
• rust-lang#127021 (Add target support for RTEMS Arm)
• rust-lang#128871 (bypass linker configuration and cross target check for specific commands)
• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#129624 (Adjust memchr pinning and run cargo update)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129939 (explain why Rvalue::Len still exists)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 4, 2024

Rollup of 8 pull requests

Successful merges:

• rust-lang#101339 (enable -Zrandomize-layout in debug CI builds )
• rust-lang#127021 (Add target support for RTEMS Arm)
• rust-lang#128871 (bypass linker configuration and cross target check for specific commands)
• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#129624 (Adjust memchr pinning and run cargo update)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129939 (explain why Rvalue::Len still exists)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 4, 2024

Rollup of 8 pull requests

Successful merges:

• rust-lang#101339 (enable -Zrandomize-layout in debug CI builds )
• rust-lang#127021 (Add target support for RTEMS Arm)
• rust-lang#128871 (bypass linker configuration and cross target check for specific commands)
• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#129624 (Adjust memchr pinning and run cargo update)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129939 (explain why Rvalue::Len still exists)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

Rollup of 8 pull requests

Successful merges:

• rust-lang#101339 (enable -Zrandomize-layout in debug CI builds )
• rust-lang#127021 (Add target support for RTEMS Arm)
• rust-lang#128871 (bypass linker configuration and cross target check for specific commands)
• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#129624 (Adjust memchr pinning and run cargo update)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129939 (explain why Rvalue::Len still exists)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 5, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

…iaskrgr

Rollup of 6 pull requests

Successful merges:

• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#129624 (Adjust memchr pinning and run cargo update)
• rust-lang#129720 (Simplify DestProp memory management)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129891 (Do not request sanitizers for naked functions)
• rust-lang#129938 (Elaborate on deriving vs implementing Copy)

Failed merges:

• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 5, 2024

This was referenced

Sep 5, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#128820 (fix: get llvm type of global val)
• rust-lang#129028 (impl_trait_overcaptures: Don't worry about uncaptured contravariant lifetimes if they outlive a captured lifetime)
• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
• rust-lang#129706 (Rename dump of coroutine by-move-body to be more consistent, fix ICE in dump_mir)
• rust-lang#129720 (Simplify DestProp memory management)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129938 (Elaborate on deriving vs implementing Copy)
• rust-lang#129973 (run_make_support: rename Command::stdin to stdin_buf and add std{in,out,err} config helpers)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#128820 (fix: get llvm type of global val)
• rust-lang#129028 (impl_trait_overcaptures: Don't worry about uncaptured contravariant lifetimes if they outlive a captured lifetime)
• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
• rust-lang#129706 (Rename dump of coroutine by-move-body to be more consistent, fix ICE in dump_mir)
• rust-lang#129720 (Simplify DestProp memory management)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129938 (Elaborate on deriving vs implementing Copy)
• rust-lang#129973 (run_make_support: rename Command::stdin to stdin_buf and add std{in,out,err} config helpers)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 19, 2024

RalfJung pushed a commit to RalfJung/miri that referenced this pull request

Sep 21, 2024

lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request

Sep 25, 2024

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.