Add f16 and f128 to invalid_nan_comparison by tgross35 · Pull Request #132439 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Currently f32_nan and f64_nan are used to provide the invalid_nan_comparison lint. Since we have f16_nan and f128_nan, hook these up so the new float types get the same lints.
Currently f32_nan and f64_nan are used to provide the
invalid_nan_comparison lint. Since we have f16_nan and f128_nan,
hook these up so the new float types get the same lints.
r? @cjgillot
rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks!
r? jieyouxu
@bors r+ rollup
📌 Commit 3afbe4f has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…ouxu
Add f16 and f128 to invalid_nan_comparison
Currently f32_nan and f64_nan are used to provide the invalid_nan_comparison lint. Since we have f16_nan and f128_nan, hook these up so the new float types get the same lints.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 13 pull requests
Successful merges:
- rust-lang#131829 (Remove support for
-Zprofile(gcov-style coverage instrumentation)) - rust-lang#132369 (style-guide: Only use the new binop heuristic for assignments)
- rust-lang#132383 (Implement suggestion for never type fallback lints)
- rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate)
- rust-lang#132438 (Remove unncessary option for default rust-analyzer setting)
- rust-lang#132439 (Add
f16andf128toinvalid_nan_comparison) - rust-lang#132445 (Cleanup attributes around unchecked shifts and unchecked negation in const)
- rust-lang#132448 (Add missing backtick)
- rust-lang#132450 (Show actual MIR when MIR building forgot to terminate block)
- rust-lang#132451 (remove some unnecessary rustc_allow_const_fn_unstable)
- rust-lang#132455 (make const_alloc_layout feature gate only about functions that are already stable)
- rust-lang#132456 (Move remaining inline assembly test files into asm directory)
- rust-lang#132459 (feat(byte_sub_ptr): unstably add ptr::byte_sub_ptr)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 14 pull requests
Successful merges:
- rust-lang#131829 (Remove support for
-Zprofile(gcov-style coverage instrumentation)) - rust-lang#132369 (style-guide: Only use the new binop heuristic for assignments)
- rust-lang#132383 (Implement suggestion for never type fallback lints)
- rust-lang#132413 (update offset_of! docs to reflect the stabilization of nesting)
- rust-lang#132438 (Remove unncessary option for default rust-analyzer setting)
- rust-lang#132439 (Add
f16andf128toinvalid_nan_comparison) - rust-lang#132444 (rustdoc: Directly use rustc_abi instead of reexports)
- rust-lang#132445 (Cleanup attributes around unchecked shifts and unchecked negation in const)
- rust-lang#132448 (Add missing backtick)
- rust-lang#132450 (Show actual MIR when MIR building forgot to terminate block)
- rust-lang#132451 (remove some unnecessary rustc_allow_const_fn_unstable)
- rust-lang#132455 (make const_alloc_layout feature gate only about functions that are already stable)
- rust-lang#132456 (Move remaining inline assembly test files into asm directory)
- rust-lang#132459 (feat(byte_sub_ptr): unstably add ptr::byte_sub_ptr)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#132439 - tgross35:f16-f128-nan-lint, r=jieyouxu
Add f16 and f128 to invalid_nan_comparison
Currently f32_nan and f64_nan are used to provide the invalid_nan_comparison lint. Since we have f16_nan and f128_nan, hook these up so the new float types get the same lints.
Labels
Area: Lints (warnings about flaws in source code) such as unused_mut.
`#![feature(f16)]`, `#![feature(f128)]`
Lint: invalid_nan_comparisons
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.