coverage: Regression test for inlining into an uninstrumented crate by Zalathar · Pull Request #132437 · rust-lang/rust (original) (raw)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

…r=jieyouxu

coverage: Regression test for inlining into an uninstrumented crate

Regression test for rust-lang#132395, after I was able to figure out a simple way to reproduce it. See also rust-lang#132436.

In addition to confirming that there is no ICE, this test also demonstrates that the affected code is undercounted, because executing the inlined copy doesn't increment coverage counters.

bors added a commit to rust-lang-ci/rust that referenced this pull request

…iaskrgr

Rollup of 6 pull requests

Successful merges:

rust-lang#131829 (Remove support for -Zprofile (gcov-style coverage instrumentation))
rust-lang#132341 (Reject raw lifetime followed by ', like regular lifetimes do)
rust-lang#132369 (style-guide: Only use the new binop heuristic for assignments)
rust-lang#132383 (Implement suggestion for never type fallback lints)
rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate)
rust-lang#132438 (Remove unncessary option for default rust-analyzer setting)

r? @ghost @rustbot modify labels: rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

…r=jieyouxu

coverage: Regression test for inlining into an uninstrumented crate

Regression test for rust-lang#132395, after I was able to figure out a simple way to reproduce it. See also rust-lang#132436.

In addition to confirming that there is no ICE, this test also demonstrates that the affected code is undercounted, because executing the inlined copy doesn't increment coverage counters.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Rollup of 13 pull requests

Successful merges:

rust-lang#131829 (Remove support for -Zprofile (gcov-style coverage instrumentation))
rust-lang#132369 (style-guide: Only use the new binop heuristic for assignments)
rust-lang#132383 (Implement suggestion for never type fallback lints)
rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate)
rust-lang#132438 (Remove unncessary option for default rust-analyzer setting)
rust-lang#132439 (Add f16 and f128 to invalid_nan_comparison)
rust-lang#132445 (Cleanup attributes around unchecked shifts and unchecked negation in const)
rust-lang#132448 (Add missing backtick)
rust-lang#132450 (Show actual MIR when MIR building forgot to terminate block)
rust-lang#132451 (remove some unnecessary rustc_allow_const_fn_unstable)
rust-lang#132455 (make const_alloc_layout feature gate only about functions that are already stable)
rust-lang#132456 (Move remaining inline assembly test files into asm directory)
rust-lang#132459 (feat(byte_sub_ptr): unstably add ptr::byte_sub_ptr)

r? @ghost @rustbot modify labels: rollup

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Whether or not running this program produces a .profraw file appears to vary by platform.

Since that isn't the main point of this test, I've just added //@ ignore-coverage-run as a workaround (diff).

Thanks, r=me after PR CI is green.

I'm also running a side job to verify that the fix actually works.

Side job succeeded on aarch64-gnu.

@bors r=jieyouxu

📌 Commit afe1902 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

…r=jieyouxu

coverage: Regression test for inlining into an uninstrumented crate

Regression test for rust-lang#132395, after I was able to figure out a simple way to reproduce it. See also rust-lang#132436.

In addition to confirming that there is no ICE, this test also demonstrates that the affected code is undercounted, because executing the inlined copy doesn't increment coverage counters.

bors added a commit to rust-lang-ci/rust that referenced this pull request

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

…r=jieyouxu

coverage: Regression test for inlining into an uninstrumented crate

Regression test for rust-lang#132395, after I was able to figure out a simple way to reproduce it. See also rust-lang#132436.

In addition to confirming that there is no ICE, this test also demonstrates that the affected code is undercounted, because executing the inlined copy doesn't increment coverage counters.

bors added a commit to rust-lang-ci/rust that referenced this pull request

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

…r=jieyouxu

coverage: Regression test for inlining into an uninstrumented crate

Regression test for rust-lang#132395, after I was able to figure out a simple way to reproduce it. See also rust-lang#132436.

In addition to confirming that there is no ICE, this test also demonstrates that the affected code is undercounted, because executing the inlined copy doesn't increment coverage counters.

bors added a commit to rust-lang-ci/rust that referenced this pull request

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

…r=jieyouxu

coverage: Regression test for inlining into an uninstrumented crate

Regression test for rust-lang#132395, after I was able to figure out a simple way to reproduce it. See also rust-lang#132436.

In addition to confirming that there is no ICE, this test also demonstrates that the affected code is undercounted, because executing the inlined copy doesn't increment coverage counters.

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

…r=jieyouxu

coverage: Regression test for inlining into an uninstrumented crate

Regression test for rust-lang#132395, after I was able to figure out a simple way to reproduce it. See also rust-lang#132436.

In addition to confirming that there is no ICE, this test also demonstrates that the affected code is undercounted, because executing the inlined copy doesn't increment coverage counters.

bors added a commit to rust-lang-ci/rust that referenced this pull request

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

…r=jieyouxu

coverage: Regression test for inlining into an uninstrumented crate

Regression test for rust-lang#132395, after I was able to figure out a simple way to reproduce it. See also rust-lang#132436.

In addition to confirming that there is no ICE, this test also demonstrates that the affected code is undercounted, because executing the inlined copy doesn't increment coverage counters.

bors added a commit to rust-lang-ci/rust that referenced this pull request

bors added a commit to rust-lang-ci/rust that referenced this pull request

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request