Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs by Zalathar · Pull Request #136279 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation18 Commits5 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added A-query-system

Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jan 30, 2025

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @rust-lang/wg-const-eval

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

(All of the changes outside the query system are just applying the renames.)

This comment has been minimized.

Also adjust query calls in librustdoc (diff).

This comment has been minimized.

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

This comment has been minimized.

Rebased to resolve conflicts; I'll put this in the queue when PR CI is green.

@bors r=oli-obk

This might be rotty, but I'll worry about that if it actually starts conflicting.

📌 Commit 3ae0239 has been approved by oli-obk

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 1, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request

Feb 1, 2025

Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs

This is all based on my archaeology for https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/.60TyCtxtEnsure.60.

The main renamings are:

• tcx.ensure() → tcx.ensure_ok()
• tcx.ensure_with_value() → tcx.ensure_done()
• Query modifier ensure_forwards_result_if_red → return_result_from_ensure_ok

Hopefully these new names are a better fit for the actual function and purpose of these query call modes.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

Rollup of 11 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#135836 (bootstrap: only build crt{begin,end}.o when compiling to MUSL)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136283 (Update encode_utf16 to mention it is native endian)
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

Rollup of 11 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#135836 (bootstrap: only build crt{begin,end}.o when compiling to MUSL)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136283 (Update encode_utf16 to mention it is native endian)
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 1, 2025

Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs

This is all based on my archaeology for https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/.60TyCtxtEnsure.60.

The main renamings are:

• tcx.ensure() → tcx.ensure_ok()
• tcx.ensure_with_value() → tcx.ensure_done()
• Query modifier ensure_forwards_result_if_red → return_result_from_ensure_ok

Hopefully these new names are a better fit for the actual function and purpose of these query call modes.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

Rollup of 10 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#135836 (bootstrap: only build crt{begin,end}.o when compiling to MUSL)
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136283 (Update encode_utf16 to mention it is native endian)
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

try-job: dist-powerpc64-linux

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 1, 2025

Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs

This is all based on my archaeology for https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/.60TyCtxtEnsure.60.

The main renamings are:

• tcx.ensure() → tcx.ensure_ok()
• tcx.ensure_with_value() → tcx.ensure_done()
• Query modifier ensure_forwards_result_if_red → return_result_from_ensure_ok

Hopefully these new names are a better fit for the actual function and purpose of these query call modes.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

Rollup of 5 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#135836 (bootstrap: only build crt{begin,end}.o when compiling to MUSL)
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])

r? @ghost @rustbot modify labels: rollup

try-job: dist-powerpc64-linux

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

Rollup of 11 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#135836 (bootstrap: only build crt{begin,end}.o when compiling to MUSL)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136283 (Update encode_utf16 to mention it is native endian)
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

try-job: dist-powerpc64-linux

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

Rollup of 11 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#135836 (bootstrap: only build crt{begin,end}.o when compiling to MUSL)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136283 (Update encode_utf16 to mention it is native endian)
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

try-job: dist-powerpc64-linux

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 1, 2025

Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs

This is all based on my archaeology for https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/.60TyCtxtEnsure.60.

The main renamings are:

• tcx.ensure() → tcx.ensure_ok()
• tcx.ensure_with_value() → tcx.ensure_done()
• Query modifier ensure_forwards_result_if_red → return_result_from_ensure_ok

Hopefully these new names are a better fit for the actual function and purpose of these query call modes.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 2, 2025

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#136133 (Fix sentence in process::abort)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 2, 2025

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#136133 (Fix sentence in process::abort)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 2, 2025

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#136133 (Fix sentence in process::abort)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 2, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#136133 (Fix sentence in process::abort)
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)
• rust-lang#136412 (Tweak fn pointer suggestion span)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 2, 2025

Rollup merge of rust-lang#136279 - Zalathar:ensure-ok, r=oli-obk

Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs

This is all based on my archaeology for https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/.60TyCtxtEnsure.60.

The main renamings are:

• tcx.ensure() → tcx.ensure_ok()
• tcx.ensure_with_value() → tcx.ensure_done()
• Query modifier ensure_forwards_result_if_red → return_result_from_ensure_ok

Hopefully these new names are a better fit for the actual function and purpose of these query call modes.

flip1995 pushed a commit to flip1995/rust that referenced this pull request

Feb 6, 2025

Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs

This is all based on my archaeology for https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/.60TyCtxtEnsure.60.

The main renamings are:

• tcx.ensure() → tcx.ensure_ok()
• tcx.ensure_with_value() → tcx.ensure_done()
• Query modifier ensure_forwards_result_if_red → return_result_from_ensure_ok

Hopefully these new names are a better fit for the actual function and purpose of these query call modes.

bjorn3 pushed a commit to bjorn3/rust that referenced this pull request

Feb 7, 2025

Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs

This is all based on my archaeology for https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/.60TyCtxtEnsure.60.

The main renamings are:

• tcx.ensure() → tcx.ensure_ok()
• tcx.ensure_with_value() → tcx.ensure_done()
• Query modifier ensure_forwards_result_if_red → return_result_from_ensure_ok

Hopefully these new names are a better fit for the actual function and purpose of these query call modes.

Labels

A-query-system

Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.