CompileTest: Add Directives to Ignore arm-unknown-* Targets by veera-sivarajan · Pull Request #136339 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

In #134626, I want to ignore arm-unknown-* targets because the LLVM IR for those looks very different compared to other targets: https://rust.godbolt.org/z/ssYMhdv4x.

I can use ignore-arm but, I think, it would exclude large number of Apple devices.

So this PR adds a few directives to ignore arm-unknown-* targets specifically.

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added A-compiletest

Area: The compiletest test runner

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Jan 31, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

📌 Commit 4d42046 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 31, 2025

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jan 31, 2025

…-headers, r=jieyouxu

CompileTest: Add Directives to Ignore arm-unknown-* Targets

In rust-lang#134626, I want to ignore arm-unknown-* targets because the LLVM IR for those looks very different compared to other targets: https://rust.godbolt.org/z/ssYMhdv4x.

I can use ignore-arm but, I think, it would exclude large number of Apple devices.

So this PR adds a few directives to ignore arm-unknown-* targets specifically.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 31, 2025

…kingjubilee

Rollup of 16 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#135768 (tests: Port symbol-mangling-hashed to rmake.rs)
• rust-lang#135836 (bootstrap: only build crt{begin,end}.o when compiling to MUSL)
• rust-lang#135840 (omit unused args warnings for intrinsics without body)
• rust-lang#135900 (Manually walk into WF obligations in BestObligation proof tree visitor)
• rust-lang#136146 (Explicitly choose x86 softfloat/hardfloat ABI)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136163 (Fix off-by-one error causing slice::sort to abort the program)
• rust-lang#136266 (fix broken release notes id)
• rust-lang#136283 (Update encode_utf16 to mention it is native endian)
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136314 (Use proper type when applying deref adjustment in const)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136348 (miri: make float min/max non-deterministic)
• rust-lang#136351 (Add documentation for derive(CoercePointee))
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])

Failed merges:

• rust-lang#135994 (Rename rustc_middle::Ty::is_unsafe_ptr to is_raw_ptr)

r? @ghost @rustbot modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Feb 1, 2025

…-headers, r=jieyouxu

CompileTest: Add Directives to Ignore arm-unknown-* Targets

In rust-lang#134626, I want to ignore arm-unknown-* targets because the LLVM IR for those looks very different compared to other targets: https://rust.godbolt.org/z/ssYMhdv4x.

I can use ignore-arm but, I think, it would exclude large number of Apple devices.

So this PR adds a few directives to ignore arm-unknown-* targets specifically.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

Rollup of 11 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#135836 (bootstrap: only build crt{begin,end}.o when compiling to MUSL)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136283 (Update encode_utf16 to mention it is native endian)
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

Rollup of 11 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#135836 (bootstrap: only build crt{begin,end}.o when compiling to MUSL)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136283 (Update encode_utf16 to mention it is native endian)
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 1, 2025

…-headers, r=jieyouxu

CompileTest: Add Directives to Ignore arm-unknown-* Targets

In rust-lang#134626, I want to ignore arm-unknown-* targets because the LLVM IR for those looks very different compared to other targets: https://rust.godbolt.org/z/ssYMhdv4x.

I can use ignore-arm but, I think, it would exclude large number of Apple devices.

So this PR adds a few directives to ignore arm-unknown-* targets specifically.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

Rollup of 10 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#135836 (bootstrap: only build crt{begin,end}.o when compiling to MUSL)
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136283 (Update encode_utf16 to mention it is native endian)
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

try-job: dist-powerpc64-linux

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 1, 2025

…-headers, r=jieyouxu

CompileTest: Add Directives to Ignore arm-unknown-* Targets

In rust-lang#134626, I want to ignore arm-unknown-* targets because the LLVM IR for those looks very different compared to other targets: https://rust.godbolt.org/z/ssYMhdv4x.

I can use ignore-arm but, I think, it would exclude large number of Apple devices.

So this PR adds a few directives to ignore arm-unknown-* targets specifically.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

Rollup of 5 pull requests

Successful merges:

• rust-lang#134740 (Add amdgpu target)
• rust-lang#136283 (Update encode_utf16 to mention it is native endian)
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

try-job: dist-powerpc64-linux

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 1, 2025

…-headers, r=jieyouxu

CompileTest: Add Directives to Ignore arm-unknown-* Targets

In rust-lang#134626, I want to ignore arm-unknown-* targets because the LLVM IR for those looks very different compared to other targets: https://rust.godbolt.org/z/ssYMhdv4x.

I can use ignore-arm but, I think, it would exclude large number of Apple devices.

So this PR adds a few directives to ignore arm-unknown-* targets specifically.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#130514 (Implement MIR lowering for unsafe binders)
• rust-lang#135684 (docs: Documented Send and Sync requirements for Mutex + MutexGuard)
• rust-lang#135760 (Add unchecked_disjoint_bitor per ACP373)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

Rollup of 11 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#135836 (bootstrap: only build crt{begin,end}.o when compiling to MUSL)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136283 (Update encode_utf16 to mention it is native endian)
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

try-job: dist-powerpc64-linux

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

Rollup of 11 pull requests

Successful merges:

• rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
• rust-lang#134740 (Add amdgpu target)
• rust-lang#135836 (bootstrap: only build crt{begin,end}.o when compiling to MUSL)
• rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
• rust-lang#136279 (Rename tcx.ensure() to tcx.ensure_ok(), and improve the associated docs)
• rust-lang#136283 (Update encode_utf16 to mention it is native endian)
• rust-lang#136309 (set rustc dylib on manually constructed rustc command)
• rust-lang#136328 (Rework "long type names" printing logic)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136358 (#[optimize(none)] implies #[inline(never)])
• rust-lang#136368 (Make comma separated lists of anything easier to make for errors)

r? @ghost @rustbot modify labels: rollup

try-job: dist-powerpc64-linux

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 2, 2025

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#136145 (Test validity of pattern types)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136403 (Fix malformed error annotations in a UI test)
• rust-lang#136414 (Shorten error message for callable with wrong return type)
• rust-lang#136425 (Move rustc_middle::infer::unify_key)
• rust-lang#136426 (Explain why we retroactively change a static initializer to have a different type)
• rust-lang#136445 (Couple of cleanups to DiagCtxt and EarlyDiagCtxt)
• rust-lang#136452 (Miri subtree update)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 2, 2025

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#136145 (Test validity of pattern types)
• rust-lang#136339 (CompileTest: Add Directives to Ignore arm-unknown-* Targets)
• rust-lang#136403 (Fix malformed error annotations in a UI test)
• rust-lang#136414 (Shorten error message for callable with wrong return type)
• rust-lang#136425 (Move rustc_middle::infer::unify_key)
• rust-lang#136426 (Explain why we retroactively change a static initializer to have a different type)
• rust-lang#136445 (Couple of cleanups to DiagCtxt and EarlyDiagCtxt)
• rust-lang#136452 (Miri subtree update)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 3, 2025

Rollup merge of rust-lang#136339 - veera-sivarajan:ignore-arm-unknown-headers, r=jieyouxu

CompileTest: Add Directives to Ignore arm-unknown-* Targets

In rust-lang#134626, I want to ignore arm-unknown-* targets because the LLVM IR for those looks very different compared to other targets: https://rust.godbolt.org/z/ssYMhdv4x.

I can use ignore-arm but, I think, it would exclude large number of Apple devices.

So this PR adds a few directives to ignore arm-unknown-* targets specifically.

Labels

A-compiletest

Area: The compiletest test runner

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)