bootstrap: only build crt{begin,end}.o when compiling to MUSL by japaric · Pull Request #135836 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation12 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

japaric

only MUSL needs those objects and trying to compile them to other targets, e.g. Windows or macOS, will produce C compilation errors

check the target before shelling out to the C compiler and tweak make_run to skip the actual C compilation when the target is not MUSL

fixes #135782

see the linked issue for additional context

@rustbot

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Jan 21, 2025

@rustbot

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

onur-ozkan

Comment on lines 1305 to 1309

assert!(
self.target.needs_crt_begin_end(),
"tried to build crtbegin.o and crtend.o for the wrong target ({})",
self.target
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still be able to build this when invoked manually.

onur-ozkan

@onur-ozkan

@jieyouxu

@rustbot rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 22, 2025

@onur-ozkan

@japaric

only MUSL needs those objects and trying to compile them to other targets, e.g. Windows or macOS, will produce C compilation errors

check the target before shelling out to the C compiler and tweak make_run to skip the actual C compilation when the target is not MUSL

fixes rust-lang#135782

@japaric

@onur-ozkan

@bors

📌 Commit 88260f4 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jan 31, 2025

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jan 31, 2025

@workingjubilee

…ly-for-musl, r=onur-ozkan

bootstrap: only build crt{begin,end}.o when compiling to MUSL

only MUSL needs those objects and trying to compile them to other targets, e.g. Windows or macOS, will produce C compilation errors

check the target before shelling out to the C compiler and tweak make_run to skip the actual C compilation when the target is not MUSL

fixes rust-lang#135782

see the linked issue for additional context

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 31, 2025

@bors

…kingjubilee

Rollup of 16 pull requests

Successful merges:

Failed merges:

r? @ghost @rustbot modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Feb 1, 2025

@jhpratt

…ly-for-musl, r=onur-ozkan

bootstrap: only build crt{begin,end}.o when compiling to MUSL

only MUSL needs those objects and trying to compile them to other targets, e.g. Windows or macOS, will produce C compilation errors

check the target before shelling out to the C compiler and tweak make_run to skip the actual C compilation when the target is not MUSL

fixes rust-lang#135782

see the linked issue for additional context

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

@bors

Rollup of 11 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

@bors

Rollup of 11 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 1, 2025

@matthiaskrgr

…ly-for-musl, r=onur-ozkan

bootstrap: only build crt{begin,end}.o when compiling to MUSL

only MUSL needs those objects and trying to compile them to other targets, e.g. Windows or macOS, will produce C compilation errors

check the target before shelling out to the C compiler and tweak make_run to skip the actual C compilation when the target is not MUSL

fixes rust-lang#135782

see the linked issue for additional context

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

@bors

Rollup of 10 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

try-job: dist-powerpc64-linux

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 1, 2025

@matthiaskrgr

…ly-for-musl, r=onur-ozkan

bootstrap: only build crt{begin,end}.o when compiling to MUSL

only MUSL needs those objects and trying to compile them to other targets, e.g. Windows or macOS, will produce C compilation errors

check the target before shelling out to the C compiler and tweak make_run to skip the actual C compilation when the target is not MUSL

fixes rust-lang#135782

see the linked issue for additional context

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

@bors

Rollup of 5 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

try-job: dist-powerpc64-linux

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

@bors

Rollup of 11 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

try-job: dist-powerpc64-linux

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 1, 2025

@bors

Rollup of 11 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

try-job: dist-powerpc64-linux

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 3, 2025

@matthiaskrgr

…ly-for-musl, r=onur-ozkan

bootstrap: only build crt{begin,end}.o when compiling to MUSL

only MUSL needs those objects and trying to compile them to other targets, e.g. Windows or macOS, will produce C compilation errors

check the target before shelling out to the C compiler and tweak make_run to skip the actual C compilation when the target is not MUSL

fixes rust-lang#135782

see the linked issue for additional context

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 3, 2025

@bors

…iaskrgr

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 3, 2025

@matthiaskrgr

…ly-for-musl, r=onur-ozkan

bootstrap: only build crt{begin,end}.o when compiling to MUSL

only MUSL needs those objects and trying to compile them to other targets, e.g. Windows or macOS, will produce C compilation errors

check the target before shelling out to the C compiler and tweak make_run to skip the actual C compilation when the target is not MUSL

fixes rust-lang#135782

see the linked issue for additional context

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 3, 2025

@bors

…iaskrgr

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Feb 3, 2025

@jieyouxu

…ly-for-musl, r=onur-ozkan

bootstrap: only build crt{begin,end}.o when compiling to MUSL

only MUSL needs those objects and trying to compile them to other targets, e.g. Windows or macOS, will produce C compilation errors

check the target before shelling out to the C compiler and tweak make_run to skip the actual C compilation when the target is not MUSL

fixes rust-lang#135782

see the linked issue for additional context

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 3, 2025

@bors

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 3, 2025

@matthiaskrgr

…ly-for-musl, r=onur-ozkan

bootstrap: only build crt{begin,end}.o when compiling to MUSL

only MUSL needs those objects and trying to compile them to other targets, e.g. Windows or macOS, will produce C compilation errors

check the target before shelling out to the C compiler and tweak make_run to skip the actual C compilation when the target is not MUSL

fixes rust-lang#135782

see the linked issue for additional context

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 4, 2025

@bors

…iaskrgr

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 4, 2025

@bors

…iaskrgr

Rollup of 6 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 4, 2025

@rust-timer

Rollup merge of rust-lang#135836 - ferrocene:ja-gh135782-build-crt-only-for-musl, r=onur-ozkan

bootstrap: only build crt{begin,end}.o when compiling to MUSL

only MUSL needs those objects and trying to compile them to other targets, e.g. Windows or macOS, will produce C compilation errors

check the target before shelling out to the C compiler and tweak make_run to skip the actual C compilation when the target is not MUSL

fixes rust-lang#135782

see the linked issue for additional context

@japaric japaric deleted the ja-gh135782-build-crt-only-for-musl branch

February 4, 2025 12:06

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)