Use proper type when applying deref adjustment in const by compiler-errors · Pull Request #136314 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
When applying a deref adjustment to some type Wrap<T> which derefs to T, we were checking that T: ~const Deref, not Wrap<T>: ~const Deref like we should have been.
r? project-const-traits
Fixes #136273
Fixes #135210 -- I just deleted the test since the regression test is uninteresting
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit c64038a has been approved by fee1-dead
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…=fee1-dead
Use proper type when applying deref adjustment in const
When applying a deref adjustment to some type Wrap<T> which derefs to T, we were checking that T: ~const Deref, not Wrap<T>: ~const Deref like we should have been.
r? project-const-traits
Fixes rust-lang#136273 Fixes rust-lang#135210 -- I just deleted the test since the regression test is uninteresting
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 16 pull requests
Successful merges:
- rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu)
- rust-lang#135768 (tests: Port
symbol-mangling-hashedto rmake.rs) - rust-lang#135836 (bootstrap: only build
crt{begin,end}.owhen compiling to MUSL) - rust-lang#135840 (omit unused args warnings for intrinsics without body)
- rust-lang#135900 (Manually walk into WF obligations in
BestObligationproof tree visitor) - rust-lang#136146 (Explicitly choose x86 softfloat/hardfloat ABI)
- rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe})
- rust-lang#136163 (Fix off-by-one error causing slice::sort to abort the program)
- rust-lang#136266 (fix broken release notes id)
- rust-lang#136283 (Update encode_utf16 to mention it is native endian)
- rust-lang#136309 (set rustc dylib on manually constructed rustc command)
- rust-lang#136314 (Use proper type when applying deref adjustment in const)
- rust-lang#136339 (CompileTest: Add Directives to Ignore
arm-unknown-*Targets) - rust-lang#136348 (miri: make float min/max non-deterministic)
- rust-lang#136351 (Add documentation for derive(CoercePointee))
- rust-lang#136358 (
#[optimize(none)]implies#[inline(never)])
Failed merges:
- rust-lang#135994 (Rename rustc_middle::Ty::is_unsafe_ptr to is_raw_ptr)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#135840 (omit unused args warnings for intrinsics without body)
- rust-lang#135900 (Manually walk into WF obligations in
BestObligationproof tree visitor) - rust-lang#136163 (Fix off-by-one error causing slice::sort to abort the program)
- rust-lang#136266 (fix broken release notes id)
- rust-lang#136314 (Use proper type when applying deref adjustment in const)
- rust-lang#136348 (miri: make float min/max non-deterministic)
- rust-lang#136351 (Add documentation for derive(CoercePointee))
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#136314 - compiler-errors:const-deref-adj, r=fee1-dead
Use proper type when applying deref adjustment in const
When applying a deref adjustment to some type Wrap<T> which derefs to T, we were checking that T: ~const Deref, not Wrap<T>: ~const Deref like we should have been.
r? project-const-traits
Fixes rust-lang#136273 Fixes rust-lang#135210 -- I just deleted the test since the regression test is uninteresting
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.