Improve -Zremap-path-scope tests with dependency by Urgau · Pull Request #140716 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This PR greatly improves our coverage of -Zremap-path-scope for diagnostic paths and macros with dependencies.
r? @jieyouxu (since we talked about it)
try-job: x86_64-msvc-1
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, these are very nice 💙
📌 Commit e534797 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Zalathar added a commit to Zalathar/rust that referenced this pull request
…=jieyouxu
Improve -Zremap-path-scope tests with dependency
This PR greatly improves our coverage of -Zremap-path-scope for diagnostic paths and macros with dependencies.
r? @jieyouxu (since we talked about it)
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 15 pull requests
Successful merges:
- rust-lang#138736 (Sanitizers target modificators)
- rust-lang#140260 (Only prefer param-env candidates if they remain non-global after norm)
- rust-lang#140523 (Better error message for late/early lifetime param mismatch)
- rust-lang#140579 (Remove estebank from automated review assignment)
- rust-lang#140641 (detect additional uses of opaques after writeback)
- rust-lang#140711 (Do not discard constraints on overflow if there was candidate ambiguity)
- rust-lang#140716 (Improve
-Zremap-path-scopetests with dependency) - rust-lang#140755 ([win][arm64] Disable various DebugInfo tests that don't work on Arm64 Windows)
- rust-lang#140756 ([arm64] Pointer auth test should link with C static library statically)
- rust-lang#140758 ([win][arm64] Disable MSVC Linker 'Arm Hazard' warning)
- rust-lang#140759 ([win][arm64] Disable std::fs tests that require symlinks)
- rust-lang#140762 (rustdoc-json: Remove newlines from attributes)
- rust-lang#140764 (style: Never break within a nullary function call
func()or a unit literal()) - rust-lang#140769 (Add
DefPathData::OpaqueLifetimeto avoid conflicts for remapped opaque lifetimes) - rust-lang#140773 (triagebot: Better message for changes to
tests/rustdoc-json)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…=jieyouxu
Improve -Zremap-path-scope tests with dependency
This PR greatly improves our coverage of -Zremap-path-scope for diagnostic paths and macros with dependencies.
r? @jieyouxu (since we talked about it)
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#140716 (Improve
-Zremap-path-scopetests with dependency) - rust-lang#140732 (make it possible to run in-tree rustfmt with
x run rustfmt) - rust-lang#140736 (trait selection: check
&before suggest remove deref) - rust-lang#140755 ([win][arm64] Disable various DebugInfo tests that don't work on Arm64 Windows)
- rust-lang#140756 ([arm64] Pointer auth test should link with C static library statically)
- rust-lang#140758 ([win][arm64] Disable MSVC Linker 'Arm Hazard' warning)
- rust-lang#140759 ([win][arm64] Disable std::fs tests that require symlinks)
r? @ghost
@rustbot modify labels: rollup
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…try>
Improve -Zremap-path-scope tests with dependency
This PR greatly improves our coverage of -Zremap-path-scope for diagnostic paths and macros with dependencies.
r? @jieyouxu (since we talked about it)
try-job: x86_64-msvc-1
⌛ Trying commit f959039 with merge b206ca0380c7da377785325698586b875c07f863...
☀️ Try build successful - checks-actions
Build commit: b206ca0 (b206ca0380c7da377785325698586b875c07f863)
Removed the dbg! in favor of simpler println! as the dbg! used the debug representation of strings which renders \ as \\ which interacts poorly with compiletest normalization.
@bors r=jieyouxu
📌 Commit f959039 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…=jieyouxu
Improve -Zremap-path-scope tests with dependency
This PR greatly improves our coverage of -Zremap-path-scope for diagnostic paths and macros with dependencies.
r? @jieyouxu (since we talked about it)
try-job: x86_64-msvc-1
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#140095 (Eliminate
word_and_emptymethods.) - rust-lang#140341 (Clarify black_box warning a bit)
- rust-lang#140684 (Only include
dyn Trait<Assoc = ...>associated type bounds forSelf: Sizedassociated types if they are provided) - rust-lang#140707 (Structurally normalize in range pattern checking in HIR typeck)
- rust-lang#140716 (Improve
-Zremap-path-scopetests with dependency) - rust-lang#140800 (Make
rustdoc-tempdir-removalrun-make tests work on other platforms than linux) - rust-lang#140802 (Add release notes for 1.87.0)
- rust-lang#140811 (Enable triagebot note functionality for rust-lang/rust)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#140716 - Urgau:improve-remap_scope-tests, r=jieyouxu
Improve -Zremap-path-scope tests with dependency
This PR greatly improves our coverage of -Zremap-path-scope for diagnostic paths and macros with dependencies.
r? @jieyouxu (since we talked about it)
try-job: x86_64-msvc-1
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.