[win][arm64] Disable std::fs tests that require symlinks by dpaoliello · Pull Request #140759 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
While trying to get the aarch64-msvc build working correctly (#140136), various tests in std::fs were failing as the Arm64 Windows runner image we are using does not have Developer Mode enabled, thus it cannot create symlinks.
I've filed a request to get Developer Mode enabled, but in the meantime I've disabled the relevant tests on Arm64 Windows.
rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah seems fine.
| @@ -730,6 +730,10 @@ fn recursive_mkdir_empty() { |
|---|
| } |
| #[test] |
| #[cfg_attr( |
| all(windows, target_arch = "aarch64"), |
| ignore = "SymLinks not enabled on Arm64 Windows runners https://github.com/actions/partner-runner-images/issues/94" |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a cute way of embedding a message there
📌 Commit 0cacc05 has been approved by workingjubilee
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Zalathar added a commit to Zalathar/rust that referenced this pull request
[win][arm64] Disable std::fs tests that require symlinks
While trying to get the aarch64-msvc build working correctly (rust-lang#140136), various tests in std::fs were failing as the Arm64 Windows runner image we are using does not have Developer Mode enabled, thus it cannot create symlinks.
I've filed a request to get Developer Mode enabled, but in the meantime I've disabled the relevant tests on Arm64 Windows.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 15 pull requests
Successful merges:
- rust-lang#138736 (Sanitizers target modificators)
- rust-lang#140260 (Only prefer param-env candidates if they remain non-global after norm)
- rust-lang#140523 (Better error message for late/early lifetime param mismatch)
- rust-lang#140579 (Remove estebank from automated review assignment)
- rust-lang#140641 (detect additional uses of opaques after writeback)
- rust-lang#140711 (Do not discard constraints on overflow if there was candidate ambiguity)
- rust-lang#140716 (Improve
-Zremap-path-scopetests with dependency) - rust-lang#140755 ([win][arm64] Disable various DebugInfo tests that don't work on Arm64 Windows)
- rust-lang#140756 ([arm64] Pointer auth test should link with C static library statically)
- rust-lang#140758 ([win][arm64] Disable MSVC Linker 'Arm Hazard' warning)
- rust-lang#140759 ([win][arm64] Disable std::fs tests that require symlinks)
- rust-lang#140762 (rustdoc-json: Remove newlines from attributes)
- rust-lang#140764 (style: Never break within a nullary function call
func()or a unit literal()) - rust-lang#140769 (Add
DefPathData::OpaqueLifetimeto avoid conflicts for remapped opaque lifetimes) - rust-lang#140773 (triagebot: Better message for changes to
tests/rustdoc-json)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
[win][arm64] Disable std::fs tests that require symlinks
While trying to get the aarch64-msvc build working correctly (rust-lang#140136), various tests in std::fs were failing as the Arm64 Windows runner image we are using does not have Developer Mode enabled, thus it cannot create symlinks.
I've filed a request to get Developer Mode enabled, but in the meantime I've disabled the relevant tests on Arm64 Windows.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#140716 (Improve
-Zremap-path-scopetests with dependency) - rust-lang#140732 (make it possible to run in-tree rustfmt with
x run rustfmt) - rust-lang#140736 (trait selection: check
&before suggest remove deref) - rust-lang#140755 ([win][arm64] Disable various DebugInfo tests that don't work on Arm64 Windows)
- rust-lang#140756 ([arm64] Pointer auth test should link with C static library statically)
- rust-lang#140758 ([win][arm64] Disable MSVC Linker 'Arm Hazard' warning)
- rust-lang#140759 ([win][arm64] Disable std::fs tests that require symlinks)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#140736 (trait selection: check
&before suggest remove deref) - rust-lang#140755 ([win][arm64] Disable various DebugInfo tests that don't work on Arm64 Windows)
- rust-lang#140756 ([arm64] Pointer auth test should link with C static library statically)
- rust-lang#140758 ([win][arm64] Disable MSVC Linker 'Arm Hazard' warning)
- rust-lang#140759 ([win][arm64] Disable std::fs tests that require symlinks)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#140759 - dpaoliello:symlink, r=workingjubilee
[win][arm64] Disable std::fs tests that require symlinks
While trying to get the aarch64-msvc build working correctly (rust-lang#140136), various tests in std::fs were failing as the Arm64 Windows runner image we are using does not have Developer Mode enabled, thus it cannot create symlinks.
I've filed a request to get Developer Mode enabled, but in the meantime I've disabled the relevant tests on Arm64 Windows.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.