triagebot: Better message for changes to tests/rustdoc-json by aDotInTheVoid · Pull Request #140773 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Adds a message to changes to tests/rustdoc-json, instead of just pinging me. Hopefully this makes the significance of these tests clearer to people who otherwise wouldn't have context, so hopefully we can avoid that happening again. It's annoyingly hard to know how well this works, because the real test is seeing if it doesn't get ignored.
Predrag has kindly offered to also get pinged here.
This comment was marked as outdated.
Area: Issues & PRs about the rust-lang/rust repository itself
Status: Awaiting review from the assignee but also interested parties.
labels
triagebot.toml has been modified, there may have been changes to the review queue.
📌 Commit 1799f5f has been approved by dtolnay
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
| @@ -1001,7 +1001,15 @@ message = "This PR changes how GCC is built. Consider updating src/bootstrap/dow |
|---|
| message = "This PR changes a file inside `tests/crashes`. If a crash was fixed, please move into the corresponding `ui` subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge." |
| [mentions."tests/rustdoc-json"] |
| cc = ["@aDotInTheVoid"] |
| message = """ |
| These commits modify `test/rustdoc-json`. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
| These commits modify `test/rustdoc-json`. |
|---|
| These commits modify `tests/rustdoc-json`. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, this happened in #140812
Zalathar added a commit to Zalathar/rust that referenced this pull request
…dtolnay
triagebot: Better message for changes to tests/rustdoc-json
Followup to rust-lang#140689 / rust-lang#140606
Adds a message to changes to tests/rustdoc-json, instead of just pinging me. Hopefully this makes the significance of these tests clearer to people who otherwise wouldn't have context, so hopefully we can avoid that happening again. It's annoyingly hard to know how well this works, because the real test is seeing if it doesn't get ignored.
Predrag has [kindly offered](rust-lang#140689 (comment)) to also get pinged here.
cc @jyn514 @obi1kenobi
r? @GuillaumeGomez
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 15 pull requests
Successful merges:
- rust-lang#138736 (Sanitizers target modificators)
- rust-lang#140260 (Only prefer param-env candidates if they remain non-global after norm)
- rust-lang#140523 (Better error message for late/early lifetime param mismatch)
- rust-lang#140579 (Remove estebank from automated review assignment)
- rust-lang#140641 (detect additional uses of opaques after writeback)
- rust-lang#140711 (Do not discard constraints on overflow if there was candidate ambiguity)
- rust-lang#140716 (Improve
-Zremap-path-scopetests with dependency) - rust-lang#140755 ([win][arm64] Disable various DebugInfo tests that don't work on Arm64 Windows)
- rust-lang#140756 ([arm64] Pointer auth test should link with C static library statically)
- rust-lang#140758 ([win][arm64] Disable MSVC Linker 'Arm Hazard' warning)
- rust-lang#140759 ([win][arm64] Disable std::fs tests that require symlinks)
- rust-lang#140762 (rustdoc-json: Remove newlines from attributes)
- rust-lang#140764 (style: Never break within a nullary function call
func()or a unit literal()) - rust-lang#140769 (Add
DefPathData::OpaqueLifetimeto avoid conflicts for remapped opaque lifetimes) - rust-lang#140773 (triagebot: Better message for changes to
tests/rustdoc-json)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#140260 (Only prefer param-env candidates if they remain non-global after norm)
- rust-lang#140523 (Better error message for late/early lifetime param mismatch)
- rust-lang#140579 (Remove estebank from automated review assignment)
- rust-lang#140641 (detect additional uses of opaques after writeback)
- rust-lang#140711 (Do not discard constraints on overflow if there was candidate ambiguity)
- rust-lang#140762 (rustdoc-json: Remove newlines from attributes)
- rust-lang#140764 (style: Never break within a nullary function call
func()or a unit literal()) - rust-lang#140769 (Add
DefPathData::OpaqueLifetimeto avoid conflicts for remapped opaque lifetimes) - rust-lang#140773 (triagebot: Better message for changes to
tests/rustdoc-json)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#140773 - aDotInTheVoid:rdj-triagdfsadgs, r=dtolnay
triagebot: Better message for changes to tests/rustdoc-json
Followup to rust-lang#140689 / rust-lang#140606
Adds a message to changes to tests/rustdoc-json, instead of just pinging me. Hopefully this makes the significance of these tests clearer to people who otherwise wouldn't have context, so hopefully we can avoid that happening again. It's annoyingly hard to know how well this works, because the real test is seeing if it doesn't get ignored.
Predrag has [kindly offered](rust-lang#140689 (comment)) to also get pinged here.
cc @jyn514 @obi1kenobi
r? @GuillaumeGomez
Labels
Area: Issues & PRs about the rust-lang/rust repository itself
Area: Rustdoc JSON backend
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the rustdoc team, which will review and decide on the PR/issue.