Stabilize path_add_extension by hanna-kruppe · Pull Request #145209 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks10 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

FCP in tracking issue #127292 finished in January. There was more discussion since then, but libs-api decided to match set_extension by keeping the return type as-is and adding a panic for invalid extensions. The latter was implemented in #140163, so this feature should be ready for stabilization. But if anyone's unsure, another FCP could be done to confirm.

Closes #127292

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Aug 10, 2025

Sorry for the delay, only now starting to get caught up on reviews. Thank you!
@bors r+ rollup

📌 Commit 52063ae has been approved by tgross35

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 3, 2025

tgross35 added a commit to tgross35/rust that referenced this pull request

Sep 3, 2025

…=tgross35

Stabilize path_add_extension

FCP in tracking issue rust-lang#127292 finished in January. There was more discussion since then, but [libs-api decided to match set_extension][0] by keeping the return type as-is and adding a panic for invalid extensions. The latter was implemented in rust-lang#140163, so this feature should be ready for stabilization. But if anyone's unsure, another FCP could be done to confirm.

Closes rust-lang#127292

[0]: rust-lang#127292 (comment)

bors added a commit that referenced this pull request

Sep 3, 2025

Rollup of 9 pull requests

Successful merges:

• #143725 (core: add Peekable::next_if_map)
• #145209 (Stabilize path_add_extension)
• #145750 (raw_vec.rs: Remove superfluous fn alloc_guard)
• #145962 (Ensure we emit an allocator shim when only some crate types need one)
• #145963 (Add LSX accelerated implementation for source file analysis)
• #146054 (add #[must_use] to array::repeat)
• #146090 (Derive PartialEq for InvisibleOrigin)
• #146120 (Correct typo in rustc_errors comment)
• #146131 (rustdoc-search: add test case for indexing every item type)

r? @ghost @rustbot modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Sep 3, 2025

…=tgross35

Stabilize path_add_extension

FCP in tracking issue rust-lang#127292 finished in January. There was more discussion since then, but [libs-api decided to match set_extension][0] by keeping the return type as-is and adding a panic for invalid extensions. The latter was implemented in rust-lang#140163, so this feature should be ready for stabilization. But if anyone's unsure, another FCP could be done to confirm.

Closes rust-lang#127292

[0]: rust-lang#127292 (comment)

bors added a commit that referenced this pull request

Sep 3, 2025

Rollup of 15 pull requests

Successful merges:

• #143725 (core: add Peekable::next_if_map)
• #145209 (Stabilize path_add_extension)
• #145750 (raw_vec.rs: Remove superfluous fn alloc_guard)
• #145962 (Ensure we emit an allocator shim when only some crate types need one)
• #145963 (Add LSX accelerated implementation for source file analysis)
• #146054 (add #[must_use] to array::repeat)
• #146090 (Derive PartialEq for InvisibleOrigin)
• #146120 (Correct typo in rustc_errors comment)
• #146127 (Rename ToolRustc to ToolRustcPrivate)
• #146131 (rustdoc-search: add test case for indexing every item type)
• #146133 (Revert "Make lto and linker-plugin-lto work the same for compiler_builtins)
• #146134 (llvm: nvptx: Layout update to match LLVM)
• #146136 (docs(std): add missing closing code block fences in doc comments)
• #146137 (Disallow frontmatter in --cfg and --check-cfg arguments)
• #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries)

r? @ghost @rustbot modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request

Sep 3, 2025

…=tgross35

Stabilize path_add_extension

FCP in tracking issue rust-lang#127292 finished in January. There was more discussion since then, but [libs-api decided to match set_extension][0] by keeping the return type as-is and adding a panic for invalid extensions. The latter was implemented in rust-lang#140163, so this feature should be ready for stabilization. But if anyone's unsure, another FCP could be done to confirm.

Closes rust-lang#127292

[0]: rust-lang#127292 (comment)

bors added a commit that referenced this pull request

Sep 3, 2025

Rollup of 16 pull requests

Successful merges:

• #143725 (core: add Peekable::next_if_map)
• #145209 (Stabilize path_add_extension)
• #145342 (fix drop scope for super let bindings within if let)
• #145750 (raw_vec.rs: Remove superfluous fn alloc_guard)
• #145962 (Ensure we emit an allocator shim when only some crate types need one)
• #145963 (Add LSX accelerated implementation for source file analysis)
• #146054 (add #[must_use] to array::repeat)
• #146090 (Derive PartialEq for InvisibleOrigin)
• #146120 (Correct typo in rustc_errors comment)
• #146127 (Rename ToolRustc to ToolRustcPrivate)
• #146133 (Revert "Make lto and linker-plugin-lto work the same for compiler_builtins)
• #146134 (llvm: nvptx: Layout update to match LLVM)
• #146136 (docs(std): add missing closing code block fences in doc comments)
• #146137 (Disallow frontmatter in --cfg and --check-cfg arguments)
• #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries)
• #146156 (miri subtree update)

r? @ghost @rustbot modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request

Sep 4, 2025

…=tgross35

Stabilize path_add_extension

FCP in tracking issue rust-lang#127292 finished in January. There was more discussion since then, but [libs-api decided to match set_extension][0] by keeping the return type as-is and adding a panic for invalid extensions. The latter was implemented in rust-lang#140163, so this feature should be ready for stabilization. But if anyone's unsure, another FCP could be done to confirm.

Closes rust-lang#127292

[0]: rust-lang#127292 (comment)

bors added a commit that referenced this pull request

Sep 4, 2025

Rollup of 24 pull requests

Successful merges:

• #140459 (Add read_buf equivalents for positioned reads)
• #143725 (core: add Peekable::next_if_map)
• #145209 (Stabilize path_add_extension)
• #145342 (fix drop scope for super let bindings within if let)
• #145750 (raw_vec.rs: Remove superfluous fn alloc_guard)
• #145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const)
• #145932 (Allow inline(always) with a target feature behind a unstable feature target_feature_inline_always.)
• #145962 (Ensure we emit an allocator shim when only some crate types need one)
• #145963 (Add LSX accelerated implementation for source file analysis)
• #146054 (add #[must_use] to array::repeat)
• #146090 (Derive PartialEq for InvisibleOrigin)
• #146112 (don't uppercase error messages)
• #146120 (Correct typo in rustc_errors comment)
• #146124 (Test rustc-dev in distcheck)
• #146127 (Rename ToolRustc to ToolRustcPrivate)
• #146131 (rustdoc-search: add test case for indexing every item type)
• #146134 (llvm: nvptx: Layout update to match LLVM)
• #146136 (docs(std): add missing closing code block fences in doc comments)
• #146137 (Disallow frontmatter in --cfg and --check-cfg arguments)
• #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries)
• #146150 (fix(rustdoc): match rustc --emit precedence )
• #146155 (Make bootstrap self test parallel)
• #146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths)
• #146172 (triagebot: configure some pings when certain attributes are used)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Sep 4, 2025

Rollup merge of #145209 - hanna-kruppe:path_add_extension, r=tgross35

Stabilize path_add_extension

FCP in tracking issue #127292 finished in January. There was more discussion since then, but [libs-api decided to match set_extension][0] by keeping the return type as-is and adding a panic for invalid extensions. The latter was implemented in #140163, so this feature should be ready for stabilization. But if anyone's unsure, another FCP could be done to confirm.

Closes #127292

[0]: #127292 (comment)

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Sep 5, 2025

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request

Sep 8, 2025

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Sep 9, 2025

…=tgross35

Stabilize path_add_extension

FCP in tracking issue rust-lang#127292 finished in January. There was more discussion since then, but [libs-api decided to match set_extension][0] by keeping the return type as-is and adding a panic for invalid extensions. The latter was implemented in rust-lang#140163, so this feature should be ready for stabilization. But if anyone's unsure, another FCP could be done to confirm.

Closes rust-lang#127292

[0]: rust-lang#127292 (comment)

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Sep 9, 2025

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.