Rename ToolRustc to ToolRustcPrivate by Kobzol · Pull Request #146127 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation10 Commits1 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
I think that this name gets the point across much better.
r? @jieyouxu
jieyouxu is currently at their maximum review capacity.
They may take a while to respond.
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
📌 Commit df5896a has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
jhpratt added a commit to jhpratt/rust that referenced this pull request
Rename ToolRustc to ToolRustcPrivate
I think that this name gets the point across much better.
r? @jieyouxu
bors added a commit that referenced this pull request
Rollup of 15 pull requests
Successful merges:
- #143725 (core: add Peekable::next_if_map)
- #145209 (Stabilize
path_add_extension) - #145750 (raw_vec.rs: Remove superfluous fn alloc_guard)
- #145962 (Ensure we emit an allocator shim when only some crate types need one)
- #145963 (Add LSX accelerated implementation for source file analysis)
- #146054 (add
#[must_use]toarray::repeat) - #146090 (Derive
PartialEqforInvisibleOrigin) - #146120 (Correct typo in
rustc_errorscomment) - #146127 (Rename
ToolRustctoToolRustcPrivate) - #146131 (rustdoc-search: add test case for indexing every item type)
- #146133 (Revert "Make
ltoandlinker-plugin-ltowork the same forcompiler_builtins) - #146134 (llvm: nvptx: Layout update to match LLVM)
- #146136 (docs(std): add missing closing code block fences in doc comments)
- #146137 (Disallow frontmatter in
--cfgand--check-cfgarguments) - #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries)
r? @ghost
@rustbot modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request
Rename ToolRustc to ToolRustcPrivate
I think that this name gets the point across much better.
r? @jieyouxu
bors added a commit that referenced this pull request
Rollup of 16 pull requests
Successful merges:
- #143725 (core: add Peekable::next_if_map)
- #145209 (Stabilize
path_add_extension) - #145342 (fix drop scope for
super letbindings withinif let) - #145750 (raw_vec.rs: Remove superfluous fn alloc_guard)
- #145962 (Ensure we emit an allocator shim when only some crate types need one)
- #145963 (Add LSX accelerated implementation for source file analysis)
- #146054 (add
#[must_use]toarray::repeat) - #146090 (Derive
PartialEqforInvisibleOrigin) - #146120 (Correct typo in
rustc_errorscomment) - #146127 (Rename
ToolRustctoToolRustcPrivate) - #146133 (Revert "Make
ltoandlinker-plugin-ltowork the same forcompiler_builtins) - #146134 (llvm: nvptx: Layout update to match LLVM)
- #146136 (docs(std): add missing closing code block fences in doc comments)
- #146137 (Disallow frontmatter in
--cfgand--check-cfgarguments) - #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries)
- #146156 (miri subtree update)
r? @ghost
@rustbot modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request
Rename ToolRustc to ToolRustcPrivate
I think that this name gets the point across much better.
r? @jieyouxu
bors added a commit that referenced this pull request
Rollup of 24 pull requests
Successful merges:
- #140459 (Add
read_bufequivalents for positioned reads) - #143725 (core: add Peekable::next_if_map)
- #145209 (Stabilize
path_add_extension) - #145342 (fix drop scope for
super letbindings withinif let) - #145750 (raw_vec.rs: Remove superfluous fn alloc_guard)
- #145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const)
- #145932 (Allow
inline(always)with a target feature behind a unstable featuretarget_feature_inline_always.) - #145962 (Ensure we emit an allocator shim when only some crate types need one)
- #145963 (Add LSX accelerated implementation for source file analysis)
- #146054 (add
#[must_use]toarray::repeat) - #146090 (Derive
PartialEqforInvisibleOrigin) - #146112 (don't uppercase error messages)
- #146120 (Correct typo in
rustc_errorscomment) - #146124 (Test
rustc-devindistcheck) - #146127 (Rename
ToolRustctoToolRustcPrivate) - #146131 (rustdoc-search: add test case for indexing every item type)
- #146134 (llvm: nvptx: Layout update to match LLVM)
- #146136 (docs(std): add missing closing code block fences in doc comments)
- #146137 (Disallow frontmatter in
--cfgand--check-cfgarguments) - #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries)
- #146150 (fix(rustdoc): match rustc
--emitprecedence ) - #146155 (Make bootstrap self test parallel)
- #146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths)
- #146172 (triagebot: configure some pings when certain attributes are used)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #146127 - Kobzol:rename-tool-rustc, r=jieyouxu
Rename ToolRustc to ToolRustcPrivate
I think that this name gets the point across much better.
r? @jieyouxu
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
Labels
Area: rustc-dev-guide
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)