Disallow frontmatter in `--cfg` and `--check-cfg` arguments by Urgau · Pull Request #146137 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation11 Commits1 Checks10 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This PR disallows the frontmatter syntax in --cfg and --check-cfg arguments.

Fixes #146130
r? fmease

fmease is not on the review rotation at the moment.
They may take a while to respond.

rustbot added A-run-make

Area: port run-make Makefiles to rmake.rs

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Sep 2, 2025

Thanks! r=me with nit addressed in one way or another
@bors rollup

fmease added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 2, 2025

This comment has been minimized.

📌 Commit 0fa93a3 has been approved by fmease

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Sep 3, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request

Sep 3, 2025

…fmease

Disallow frontmatter in --cfg and --check-cfg arguments

This PR disallows the frontmatter syntax in --cfg and --check-cfg arguments.

Fixes rust-lang#146130 r? fmease

bors added a commit that referenced this pull request

Sep 3, 2025

Rollup of 15 pull requests

Successful merges:

#143725 (core: add Peekable::next_if_map)
#145209 (Stabilize path_add_extension)
#145750 (raw_vec.rs: Remove superfluous fn alloc_guard)
#145962 (Ensure we emit an allocator shim when only some crate types need one)
#145963 (Add LSX accelerated implementation for source file analysis)
#146054 (add #[must_use] to array::repeat)
#146090 (Derive PartialEq for InvisibleOrigin)
#146120 (Correct typo in rustc_errors comment)
#146127 (Rename ToolRustc to ToolRustcPrivate)
#146131 (rustdoc-search: add test case for indexing every item type)
#146133 (Revert "Make lto and linker-plugin-lto work the same for compiler_builtins)
#146134 (llvm: nvptx: Layout update to match LLVM)
#146136 (docs(std): add missing closing code block fences in doc comments)
#146137 (Disallow frontmatter in --cfg and --check-cfg arguments)
#146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries)

r? @ghost @rustbot modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request

Sep 3, 2025

…fmease

Disallow frontmatter in --cfg and --check-cfg arguments

This PR disallows the frontmatter syntax in --cfg and --check-cfg arguments.

Fixes rust-lang#146130 r? fmease

bors added a commit that referenced this pull request

Sep 3, 2025

Rollup of 16 pull requests

Successful merges:

#143725 (core: add Peekable::next_if_map)
#145209 (Stabilize path_add_extension)
#145342 (fix drop scope for super let bindings within if let)
#145750 (raw_vec.rs: Remove superfluous fn alloc_guard)
#145962 (Ensure we emit an allocator shim when only some crate types need one)
#145963 (Add LSX accelerated implementation for source file analysis)
#146054 (add #[must_use] to array::repeat)
#146090 (Derive PartialEq for InvisibleOrigin)
#146120 (Correct typo in rustc_errors comment)
#146127 (Rename ToolRustc to ToolRustcPrivate)
#146133 (Revert "Make lto and linker-plugin-lto work the same for compiler_builtins)
#146134 (llvm: nvptx: Layout update to match LLVM)
#146136 (docs(std): add missing closing code block fences in doc comments)
#146137 (Disallow frontmatter in --cfg and --check-cfg arguments)
#146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries)
#146156 (miri subtree update)

r? @ghost @rustbot modify labels: rollup

bors added a commit that referenced this pull request

Sep 4, 2025

Rollup of 24 pull requests

Successful merges:

#140459 (Add read_buf equivalents for positioned reads)
#143725 (core: add Peekable::next_if_map)
#145209 (Stabilize path_add_extension)
#145342 (fix drop scope for super let bindings within if let)
#145750 (raw_vec.rs: Remove superfluous fn alloc_guard)
#145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const)
#145932 (Allow inline(always) with a target feature behind a unstable feature target_feature_inline_always.)
#145962 (Ensure we emit an allocator shim when only some crate types need one)
#145963 (Add LSX accelerated implementation for source file analysis)
#146054 (add #[must_use] to array::repeat)
#146090 (Derive PartialEq for InvisibleOrigin)
#146112 (don't uppercase error messages)
#146120 (Correct typo in rustc_errors comment)
#146124 (Test rustc-dev in distcheck)
#146127 (Rename ToolRustc to ToolRustcPrivate)
#146131 (rustdoc-search: add test case for indexing every item type)
#146134 (llvm: nvptx: Layout update to match LLVM)
#146136 (docs(std): add missing closing code block fences in doc comments)
#146137 (Disallow frontmatter in --cfg and --check-cfg arguments)
#146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries)
#146150 (fix(rustdoc): match rustc --emit precedence )
#146155 (Make bootstrap self test parallel)
#146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths)
#146172 (triagebot: configure some pings when certain attributes are used)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Sep 4, 2025

Rollup merge of #146137 - Urgau:cfg-disallow-frontmatter, r=fmease

Disallow frontmatter in --cfg and --check-cfg arguments

This PR disallows the frontmatter syntax in --cfg and --check-cfg arguments.

Fixes #146130 r? fmease

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Sep 5, 2025

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request

Sep 8, 2025

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Sep 9, 2025

Beta/stable backport declined as discussed in today's compiler triage meeting #t-compiler/meetings > [weekly] 2025-09-11 @ 💬, since it seems very unlikely that users would try to do this, so it seems fine to ride the normal release train.

@rustbot label: -beta-nominated -stable-nominated

epage mentioned this pull request