prevent line number from being copied in chrome by el-ev · Pull Request #146877 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks10 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

T-rustdoc-frontend

Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

labels

Sep 22, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

It'd be worthwhile to investigate if this is a Chrome bug or a Firefox one (i.e., what does the spec say?) and find the corresp. upstream ticket to link to.

The whole "copy" event handler has a comment saying it's for firefox, probably want to move or rewrite that so it makes more sense. Something like "workaround for multiple browser-specific bugs". Also I think it would make sense to link to the chrome bug report like we do with the firefox bug report.

Thanks!

@bors r=fmease,lolbinarycat,GuillaumeGomez

📌 Commit 9ae7aef has been approved by fmease,lolbinarycat,GuillaumeGomez

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 23, 2025

bors added a commit that referenced this pull request

Sep 23, 2025

Rollup of 10 pull requests

Successful merges:

#146632 (Fix uses of "adaptor")
#146731 (test: Use SVG for terminal url test)
#146775 (fixes for numerous clippy warnings)
#146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows)
#146799 (Fix a dangling reference in rustc_thread_pool)
#146802 (mbe: Simplifications and refactoring)
#146806 (add private module override re-export test)
#146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly))
#146875 (tests/run-make/crate-loading: Rename source files for clarity)
#146877 (prevent line number from being copied in chrome)