test: Use SVG for terminal url test by Muscraft · Pull Request #146731 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits2 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
I came across the test for -Zterminal-urls and found its output a bit hard to read. So, I decided to switch it to an SVG test, as I found it easier to differentiate the link and link text.
Note: anstyle-svg needed to be upgraded to at least 0.1.8 to support links in SVGs, so I went ahead and upgraded it to the latest version (0.1.11).
These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.
Some changes occurred in src/tools/compiletest
cc @jieyouxu
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
r? @BoxyUwU
rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Svg test terminal url test: Use SVG for terminal url test
looks good! @bors r+ rollup
📌 Commit 6375083 has been approved by jdonszelmann
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
jhpratt added a commit to jhpratt/rust that referenced this pull request
…jdonszelmann
test: Use SVG for terminal url test
I came across the test for -Zterminal-urls and found its output a bit hard to read. So, I decided to switch it to an SVG test, as I found it easier to differentiate the link and link text.
Note: anstyle-svg needed to be upgraded to at least 0.1.8 to support links in SVGs, so I went ahead and upgraded it to the latest version (0.1.11).
bors added a commit that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- #146229 (Automatically switch to lto-fat when flag RUSTFLAGS="- Zautodiff=Enable" is set)
- #146615 (rustc_codegen_llvm: Feature Conversion Tidying)
- #146638 (
rustc_next_trait_solver: canonical out ofEvalCtxt) - #146663 (Allow windows resource compiler to be overridden)
- #146691 (std: Fix WASI implementation of
remove_dir_all) - #146709 (stdarch subtree update)
- #146731 (test: Use SVG for terminal url test)
- #146738 (Fix tidy spellchecking on Windows)
r? @ghost
@rustbot modify labels: rollup
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 4f02ec2 has been approved by jdonszelmann
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Zalathar added a commit to Zalathar/rust that referenced this pull request
…jdonszelmann
test: Use SVG for terminal url test
I came across the test for -Zterminal-urls and found its output a bit hard to read. So, I decided to switch it to an SVG test, as I found it easier to differentiate the link and link text.
Note: anstyle-svg needed to be upgraded to at least 0.1.8 to support links in SVGs, so I went ahead and upgraded it to the latest version (0.1.11).
bors added a commit that referenced this pull request
Rollup of 13 pull requests
Successful merges:
- #146632 (Fix uses of "adaptor")
- #146731 (test: Use SVG for terminal url test)
- #146775 (fixes for numerous clippy warnings)
- #146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows)
- #146799 (Fix a dangling reference in
rustc_thread_pool) - #146802 (mbe: Simplifications and refactoring)
- #146806 (add private module override re-export test)
- #146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly))
- #146875 (tests/run-make/crate-loading: Rename source files for clarity)
- #146896 (rustc-dev-guide subtree update)
- #146898 (Update books)
- #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
- #146907 (add regression test for issue 146537)
r? @ghost
@rustbot modify labels: rollup
Kobzol added a commit to Kobzol/rust that referenced this pull request
…jdonszelmann
test: Use SVG for terminal url test
I came across the test for -Zterminal-urls and found its output a bit hard to read. So, I decided to switch it to an SVG test, as I found it easier to differentiate the link and link text.
Note: anstyle-svg needed to be upgraded to at least 0.1.8 to support links in SVGs, so I went ahead and upgraded it to the latest version (0.1.11).
Github's svg preview doesn't give any indication about the link and I imagine neither would any non-browser svg viewer.
bors added a commit that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- #146632 (Fix uses of "adaptor")
- #146731 (test: Use SVG for terminal url test)
- #146775 (fixes for numerous clippy warnings)
- #146802 (mbe: Simplifications and refactoring)
- #146875 (tests/run-make/crate-loading: Rename source files for clarity)
- #146896 (rustc-dev-guide subtree update)
- #146898 (Update books)
- #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 10 pull requests
Successful merges:
- #146632 (Fix uses of "adaptor")
- #146731 (test: Use SVG for terminal url test)
- #146775 (fixes for numerous clippy warnings)
- #146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows)
- #146799 (Fix a dangling reference in
rustc_thread_pool) - #146802 (mbe: Simplifications and refactoring)
- #146806 (add private module override re-export test)
- #146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly))
- #146875 (tests/run-make/crate-loading: Rename source files for clarity)
- #146877 (prevent line number from being copied in chrome)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #146731 - Muscraft:svg-test-terminal-url, r=jdonszelmann
test: Use SVG for terminal url test
I came across the test for -Zterminal-urls and found its output a bit hard to read. So, I decided to switch it to an SVG test, as I found it easier to differentiate the link and link text.
Note: anstyle-svg needed to be upgraded to at least 0.1.8 to support links in SVGs, so I went ahead and upgraded it to the latest version (0.1.11).
Muscraft pushed a commit to Muscraft/rust that referenced this pull request
…jdonszelmann
test: Use SVG for terminal url test
I came across the test for -Zterminal-urls and found its output a bit hard to read. So, I decided to switch it to an SVG test, as I found it easier to differentiate the link and link text.
Note: anstyle-svg needed to be upgraded to at least 0.1.8 to support links in SVGs, so I went ahead and upgraded it to the latest version (0.1.11).
Muscraft pushed a commit to Muscraft/rust that referenced this pull request
Labels
Area: The compiletest test runner
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Relevant to the compiler team, which will review and decide on the PR/issue.