mbe: Simplifications and refactoring by joshtriplett · Pull Request #146802 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits3 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
A few simplifications and refactors in advance of other work.
Macro metavariable expressions were using Ident::as_str and doing string
comparisons; I converted them to use symbols.
I factored out a function for transcribing a ParseNtResult, which will help
separate the evaluation and transcription of future macro metavariable
expressions.
Factor out the check for a variable that's still repeating.
Identify metavariable functions by using named symbols rather than string comparisons.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
r? @jackh726
rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkBst I don't think anything in the perf suite is likely to test metavariable expressions.
(Also, feel free to review and merge, I don't think this needs to wait for petrochenkov specifically.)
@hkBst: 🔑 Insufficient privileges: Not in reviewers
📌 Commit a54111a has been approved by petrochenkov
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…r=petrochenkov
mbe: Simplifications and refactoring
A few simplifications and refactors in advance of other work.
Macro metavariable expressions were using Ident::as_str and doing string
comparisons; I converted them to use symbols.
I factored out a function for transcribing a ParseNtResult, which will help
separate the evaluation and transcription of future macro metavariable
expressions.
bors added a commit that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- #146632 (Fix uses of "adaptor")
- #146775 (fixes for numerous clippy warnings)
- #146802 (mbe: Simplifications and refactoring)
- #146806 (add private module override re-export test)
- #146866 ([rustdoc] Correctly handle intra doc link when type alias disambiguator is passed for primitive)
- #146896 (rustc-dev-guide subtree update)
- #146898 (Update books)
r? @ghost
@rustbot modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request
…r=petrochenkov
mbe: Simplifications and refactoring
A few simplifications and refactors in advance of other work.
Macro metavariable expressions were using Ident::as_str and doing string
comparisons; I converted them to use symbols.
I factored out a function for transcribing a ParseNtResult, which will help
separate the evaluation and transcription of future macro metavariable
expressions.
bors added a commit that referenced this pull request
Rollup of 13 pull requests
Successful merges:
- #146632 (Fix uses of "adaptor")
- #146731 (test: Use SVG for terminal url test)
- #146775 (fixes for numerous clippy warnings)
- #146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows)
- #146799 (Fix a dangling reference in
rustc_thread_pool) - #146802 (mbe: Simplifications and refactoring)
- #146806 (add private module override re-export test)
- #146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly))
- #146875 (tests/run-make/crate-loading: Rename source files for clarity)
- #146896 (rustc-dev-guide subtree update)
- #146898 (Update books)
- #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
- #146907 (add regression test for issue 146537)
r? @ghost
@rustbot modify labels: rollup
Kobzol added a commit to Kobzol/rust that referenced this pull request
…r=petrochenkov
mbe: Simplifications and refactoring
A few simplifications and refactors in advance of other work.
Macro metavariable expressions were using Ident::as_str and doing string
comparisons; I converted them to use symbols.
I factored out a function for transcribing a ParseNtResult, which will help
separate the evaluation and transcription of future macro metavariable
expressions.
bors added a commit that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- #146632 (Fix uses of "adaptor")
- #146731 (test: Use SVG for terminal url test)
- #146775 (fixes for numerous clippy warnings)
- #146802 (mbe: Simplifications and refactoring)
- #146875 (tests/run-make/crate-loading: Rename source files for clarity)
- #146896 (rustc-dev-guide subtree update)
- #146898 (Update books)
- #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 10 pull requests
Successful merges:
- #146632 (Fix uses of "adaptor")
- #146731 (test: Use SVG for terminal url test)
- #146775 (fixes for numerous clippy warnings)
- #146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows)
- #146799 (Fix a dangling reference in
rustc_thread_pool) - #146802 (mbe: Simplifications and refactoring)
- #146806 (add private module override re-export test)
- #146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly))
- #146875 (tests/run-make/crate-loading: Rename source files for clarity)
- #146877 (prevent line number from being copied in chrome)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #146802 - joshtriplett:mbe-simplifications, r=petrochenkov
mbe: Simplifications and refactoring
A few simplifications and refactors in advance of other work.
Macro metavariable expressions were using Ident::as_str and doing string
comparisons; I converted them to use symbols.
I factored out a function for transcribing a ParseNtResult, which will help
separate the evaluation and transcription of future macro metavariable
expressions.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request
…r=petrochenkov
mbe: Simplifications and refactoring
A few simplifications and refactors in advance of other work.
Macro metavariable expressions were using Ident::as_str and doing string
comparisons; I converted them to use symbols.
I factored out a function for transcribing a ParseNtResult, which will help
separate the evaluation and transcription of future macro metavariable
expressions.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.