Fix a crash/mislex when more than one frontmatter closing possibility is considered by Teapot4195 · Pull Request #146899 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
When the less fortunate recovery path for frontmatters are taken, if the lexer considers more than one possible frontmatter closing possibility, the current index is entirely mis-tracked and can result in bump_bytes landing in the middle of a multichar unicode character.
This fixes it by tracking the actual base index and updating it as it considers additional closing possibilities.
fixes #146847
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
r? @nnethercote
rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Could you please add a regression test? In tests/ui/frontmatter/
Could you please add a regression test? In
tests/ui/frontmatter/
First time writing tests, naming/contents ok?
📌 Commit 2d18c88 has been approved by nnethercote
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Zalathar added a commit to Zalathar/rust that referenced this pull request
…thercote
Fix a crash/mislex when more than one frontmatter closing possibility is considered
When the less fortunate recovery path for frontmatters are taken, if the lexer considers more than one possible frontmatter closing possibility, the current index is entirely mis-tracked and can result in bump_bytes landing in the middle of a multichar unicode character.
This fixes it by tracking the actual base index and updating it as it considers additional closing possibilities.
fixes rust-lang#146847
bors added a commit that referenced this pull request
Rollup of 13 pull requests
Successful merges:
- #146632 (Fix uses of "adaptor")
- #146731 (test: Use SVG for terminal url test)
- #146775 (fixes for numerous clippy warnings)
- #146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows)
- #146799 (Fix a dangling reference in
rustc_thread_pool) - #146802 (mbe: Simplifications and refactoring)
- #146806 (add private module override re-export test)
- #146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly))
- #146875 (tests/run-make/crate-loading: Rename source files for clarity)
- #146896 (rustc-dev-guide subtree update)
- #146898 (Update books)
- #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
- #146907 (add regression test for issue 146537)
r? @ghost
@rustbot modify labels: rollup
Kobzol added a commit to Kobzol/rust that referenced this pull request
…thercote
Fix a crash/mislex when more than one frontmatter closing possibility is considered
When the less fortunate recovery path for frontmatters are taken, if the lexer considers more than one possible frontmatter closing possibility, the current index is entirely mis-tracked and can result in bump_bytes landing in the middle of a multichar unicode character.
This fixes it by tracking the actual base index and updating it as it considers additional closing possibilities.
fixes rust-lang#146847
bors added a commit that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- #146632 (Fix uses of "adaptor")
- #146731 (test: Use SVG for terminal url test)
- #146775 (fixes for numerous clippy warnings)
- #146802 (mbe: Simplifications and refactoring)
- #146875 (tests/run-make/crate-loading: Rename source files for clarity)
- #146896 (rustc-dev-guide subtree update)
- #146898 (Update books)
- #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…thercote
Fix a crash/mislex when more than one frontmatter closing possibility is considered
When the less fortunate recovery path for frontmatters are taken, if the lexer considers more than one possible frontmatter closing possibility, the current index is entirely mis-tracked and can result in bump_bytes landing in the middle of a multichar unicode character.
This fixes it by tracking the actual base index and updating it as it considers additional closing possibilities.
fixes rust-lang#146847
bors added a commit that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- #146818 (constify {float}::total_cmp())
- #146896 (rustc-dev-guide subtree update)
- #146898 (Update books)
- #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
- #146904 (#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
- #146907 (add regression test for issue 146537)
- #146927 (Make it possible to
x installCranelift and LLVM bitcode linker) - #146931 (miri subtree update)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- #146818 (constify {float}::total_cmp())
- #146896 (rustc-dev-guide subtree update)
- #146898 (Update books)
- #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
- #146904 (#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
- #146907 (add regression test for issue 146537)
r? @ghost
@rustbot modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request
…thercote
Fix a crash/mislex when more than one frontmatter closing possibility is considered
When the less fortunate recovery path for frontmatters are taken, if the lexer considers more than one possible frontmatter closing possibility, the current index is entirely mis-tracked and can result in bump_bytes landing in the middle of a multichar unicode character.
This fixes it by tracking the actual base index and updating it as it considers additional closing possibilities.
fixes rust-lang#146847
bors added a commit that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- #146818 (constify {float}::total_cmp())
- #146896 (rustc-dev-guide subtree update)
- #146898 (Update books)
- #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
- #146904 (#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
- #146907 (add regression test for issue 146537)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- #146818 (constify {float}::total_cmp())
- #146896 (rustc-dev-guide subtree update)
- #146898 (Update books)
- #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
- #146904 (#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
- #146907 (add regression test for issue 146537)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #146899 - Teapot4195:issue-146847-fix, r=nnethercote
Fix a crash/mislex when more than one frontmatter closing possibility is considered
When the less fortunate recovery path for frontmatters are taken, if the lexer considers more than one possible frontmatter closing possibility, the current index is entirely mis-tracked and can result in bump_bytes landing in the middle of a multichar unicode character.
This fixes it by tracking the actual base index and updating it as it considers additional closing possibilities.
fixes #146847
Muscraft pushed a commit to Muscraft/rust that referenced this pull request
…thercote
Fix a crash/mislex when more than one frontmatter closing possibility is considered
When the less fortunate recovery path for frontmatters are taken, if the lexer considers more than one possible frontmatter closing possibility, the current index is entirely mis-tracked and can result in bump_bytes landing in the middle of a multichar unicode character.
This fixes it by tracking the actual base index and updating it as it considers additional closing possibilities.
fixes rust-lang#146847
Muscraft pushed a commit to Muscraft/rust that referenced this pull request
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request
10 tasks
Labels
`#![feature(frontmatter)]`
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.