"running analysis passes on crate foo" This message is displayed in cycle errors in particular, and in some cases without any spans...">

Mention crate being analyzed in query description by estebank · Pull Request #147137 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation18 Commits1 Checks12 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

"running analysis passes on this crate" -> "running analysis passes on crate foo"

This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle.

Address #74380, but we still need a test for that case in particular.

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

LL \| const FOO: usize = FOO;
\| ^^^
= note: ...which again requires simplifying constant for the type system `FOO`, completing the cycle
= note: cycle used when running analysis passes on this crate

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line removed?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the PR looks fine, but this is a worry, because this test looks very similar to the other tests but it is changed in a different way.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An answer here is needed to unblock further progress.

@rustbot author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rebasing these changes went away.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your lucky day!

error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0391`.
For more information about this error, try `rustc --explain E0391`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the file-ending newline removed?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be perfectly honest: not the faintest idea why my changes affect this test at all 😵

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Reminder, once the PR becomes ready for a review, use @rustbot ready.

"running analysis passes on this crate" -> "running analysis passes on crate foo"

This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle.

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

estebank added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

📌 Commit 0efeec5 has been approved by nnethercote

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Mention crate being analyzed in query description

"running analysis passes on this crate" -> "running analysis passes on crate foo"

This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle.

Address rust-lang#74380, but we still need a test for that case in particular.

bors added a commit that referenced this pull request

Rollup of 8 pull requests

Successful merges:

#147137 (Mention crate being analyzed in query description)
#148099 (Prepare to move debugger discovery from compiletest to bootstrap)
#148194 (compiletest: Remove cleanup_debug_info_options)
#148199 (compiletest: Don't modify testpaths when creating aux contexts)
#148240 (rustc_codegen: fix musttail returns for cast/indirect ABIs)
#148247 (Remove two special cases from reachable_non_generics)
#148290 (Do not emit solver errors that contain error types)
#148362 (docs: makes a note about possible building rustc 1.91.0 + host tools for win7)

r? @ghost @rustbot modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Mention crate being analyzed in query description

"running analysis passes on this crate" -> "running analysis passes on crate foo"

This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle.

Address rust-lang#74380, but we still need a test for that case in particular.

bors added a commit that referenced this pull request

Rollup of 12 pull requests

Successful merges:

#147137 (Mention crate being analyzed in query description)
#147642 (Miscellaneous const-generics-related fixes)
#147806 (Ignore test-dashboard related files)
#147947 (Implement strip_circumfix lib feature)
#148194 (compiletest: Remove cleanup_debug_info_options)
#148199 (compiletest: Don't modify testpaths when creating aux contexts)
#148247 (Remove two special cases from reachable_non_generics)
#148348 (dangling ptr lint cleanup)
#148357 (temporary-lifetime-extension.rs test works in all editions)
#148362 (docs: makes a note about possible building rustc 1.91.0 + host tools for win7)
#148367 (Use --print host-tuple to get the host)
#148374 (miri subtree update)

r? @ghost @rustbot modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request

Mention crate being analyzed in query description

"running analysis passes on this crate" -> "running analysis passes on crate foo"

This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle.

Address rust-lang#74380, but we still need a test for that case in particular.

rust-bors bot added a commit that referenced this pull request

Mention crate being analyzed in query description

try-job: armhf-gnu

bors added a commit that referenced this pull request

Rollup of 9 pull requests

Successful merges:

#147137 (Mention crate being analyzed in query description)
#147155 (arm-linux.md: various fixes/improvements)
#147642 (Miscellaneous const-generics-related fixes)
#147806 (Ignore test-dashboard related files)
#147947 (Implement strip_circumfix lib feature)
#148346 (Change cfg_trace, cfg_attr_trace symbol values)
#148348 (dangling ptr lint cleanup)
#148393 (Remove tests/run-make/fmt-write-bloat/)
#148400 (Better warning message for crate type unsupported by codegen backend)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Rollup merge of #147137 - estebank:issue-74380, r=nnethercote

Mention crate being analyzed in query description

"running analysis passes on this crate" -> "running analysis passes on crate foo"

This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle.

Address #74380, but we still need a test for that case in particular.

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Relevant to the compiler team, which will review and decide on the PR/issue.