compiletest: Remove cleanup_debug_info_options by Zalathar · Pull Request #148194 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation18 Commits1 Checks12 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to --host-rustcflags or --target-rustcflags.
I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice.
In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating TestCx, which is the biggest win.
r? jieyouxu
This "cleanup" function is more than a decade old, and I can't find any
evidence of modern-day bootstrap being able to pass any of these flags to
--host-rustcflags or --target-rustcflags.
Some changes occurred in src/tools/compiletest
cc @jieyouxu
Area: The compiletest test runner
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
jieyouxu is currently at their maximum review capacity.
They may take a while to respond.
@bors try jobs=x86_64-msvc-1,i686-msvc-1,aarch64-msvc-1,x86_64-mingw-1,test-various,armhf-gnu,aarch64-apple
This comment has been minimized.
rust-bors bot added a commit that referenced this pull request
compiletest: Remove cleanup_debug_info_options
try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: aarch64-msvc-1 try-job: x86_64-mingw-1 try-job: test-various try-job: armhf-gnu try-job: aarch64-apple
jieyouxuis currently at their maximum review capacity.
They may take a while to respond.
I have a few more compiletest PRs that I plan to open (big and small), so I understand if it takes some time to get around to all of them. Thanks for your good work! 💖
☀️ Try build successful (CI)
Build commit: 5bf34a8 (5bf34a8252ab0d62acaeddf7a02112f90f7d9dbc, parent: adaa838976ff99a4f0661136322f64cb466b58a0)
I have a few more compiletest PRs that I plan to open (big and small), so I understand if it takes some time to get around to all of them. Thanks for your good work! 💖
Yeah that is perfectly fine, it'll just take some time for me to get through them.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this is used for (this predates my time), but I'm also in favor of yeeting this until someone complains with a solid use case.
View changes since this review
📌 Commit 08b188c has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
compiletest: Remove cleanup_debug_info_options
This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to --host-rustcflags or --target-rustcflags.
I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice.
In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating TestCx, which is the biggest win.
r? jieyouxu
bors added a commit that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- #147137 (Mention crate being analyzed in query description)
- #148099 (Prepare to move debugger discovery from compiletest to bootstrap)
- #148194 (compiletest: Remove
cleanup_debug_info_options) - #148199 (compiletest: Don't modify
testpathswhen creating aux contexts) - #148240 (rustc_codegen: fix musttail returns for cast/indirect ABIs)
- #148247 (Remove two special cases from reachable_non_generics)
- #148290 (Do not emit solver errors that contain error types)
- #148362 (docs: makes a note about possible building
rustc 1.91.0 + host toolsfor win7)
r? @ghost
@rustbot modify labels: rollup
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
@bors try jobs=arm-android
This comment has been minimized.
rust-bors bot added a commit that referenced this pull request
compiletest: Remove cleanup_debug_info_options
try-job: arm-android
After some investigation, I'm pretty sure the failure was from #148199, so putting this back in the queue.
@bors r=jieyouxu
📌 Commit 08b188c has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
jhpratt added a commit to jhpratt/rust that referenced this pull request
compiletest: Remove cleanup_debug_info_options
This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to --host-rustcflags or --target-rustcflags.
I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice.
In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating TestCx, which is the biggest win.
r? jieyouxu
☀️ Try build successful (CI)
Build commit: 96fa94d (96fa94df7159b4407163fdbc00fc69fb3df021df, parent: bd3ac0330018c23b111bbee176f32c377be7b319)
bors added a commit that referenced this pull request
Rollup of 12 pull requests
Successful merges:
- #147137 (Mention crate being analyzed in query description)
- #147642 (Miscellaneous const-generics-related fixes)
- #147806 (Ignore test-dashboard related files)
- #147947 (Implement
strip_circumfixlib feature) - #148194 (compiletest: Remove
cleanup_debug_info_options) - #148199 (compiletest: Don't modify
testpathswhen creating aux contexts) - #148247 (Remove two special cases from reachable_non_generics)
- #148348 (dangling ptr lint cleanup)
- #148357 (temporary-lifetime-extension.rs test works in all editions)
- #148362 (docs: makes a note about possible building
rustc 1.91.0 + host toolsfor win7) - #148367 (Use --print host-tuple to get the host)
- #148374 (miri subtree update)
r? @ghost
@rustbot modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request
compiletest: Remove cleanup_debug_info_options
This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to --host-rustcflags or --target-rustcflags.
I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice.
In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating TestCx, which is the biggest win.
r? jieyouxu
Zalathar added a commit to Zalathar/rust that referenced this pull request
compiletest: Remove cleanup_debug_info_options
This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to --host-rustcflags or --target-rustcflags.
I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice.
In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating TestCx, which is the biggest win.
r? jieyouxu
bors added a commit that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- #147947 (Implement
strip_circumfixlib feature) - #148170 (split definition and use site hidden tys)
- #148194 (compiletest: Remove
cleanup_debug_info_options) - #148199 (compiletest: Don't modify
testpathswhen creating aux contexts) - #148240 (rustc_codegen: fix musttail returns for cast/indirect ABIs)
- #148290 (Do not emit solver errors that contain error types)
- #148357 (temporary-lifetime-extension.rs test works in all editions)
- #148362 (docs: makes a note about possible building
rustc 1.91.0 + host toolsfor win7) - #148367 (Use --print host-tuple to get the host)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
compiletest: Remove cleanup_debug_info_options
This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to --host-rustcflags or --target-rustcflags.
I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice.
In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating TestCx, which is the biggest win.
r? jieyouxu
This was referenced
Nov 2, 2025
bors added a commit that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- #148170 (split definition and use site hidden tys)
- #148194 (compiletest: Remove
cleanup_debug_info_options) - #148199 (compiletest: Don't modify
testpathswhen creating aux contexts) - #148290 (Do not emit solver errors that contain error types)
- #148357 (temporary-lifetime-extension.rs test works in all editions)
- #148362 (docs: makes a note about possible building
rustc 1.91.0 + host toolsfor win7) - #148367 (Use --print host-tuple to get the host)
- #148374 (miri subtree update)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #148194 - Zalathar:no-cleanup, r=jieyouxu
compiletest: Remove cleanup_debug_info_options
This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to --host-rustcflags or --target-rustcflags.
I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice.
In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating TestCx, which is the biggest win.
r? jieyouxu
Bors, this was already merged.
@bors r-
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#148170 (split definition and use site hidden tys)
- rust-lang#148194 (compiletest: Remove
cleanup_debug_info_options) - rust-lang#148199 (compiletest: Don't modify
testpathswhen creating aux contexts) - rust-lang#148290 (Do not emit solver errors that contain error types)
- rust-lang#148357 (temporary-lifetime-extension.rs test works in all editions)
- rust-lang#148362 (docs: makes a note about possible building
rustc 1.91.0 + host toolsfor win7) - rust-lang#148367 (Use --print host-tuple to get the host)
- rust-lang#148374 (miri subtree update)
r? @ghost
@rustbot modify labels: rollup
Labels
Area: The compiletest test runner
Area: The testsuite used to check the correctness of rustc
Status: This is awaiting some action (such as code changes or more information) from the author.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)