Implement strip_circumfix lib feature by yotamofek · Pull Request #147947 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits1 Checks11 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
r? @ibraheemdev
rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)
Click to see the possible cause of the failure (guessed by this bot)
Documenting proc_macro_test v0.1.0 (/checkout/tests/rustdoc-gui/src/proc_macro_test)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.81s
Generated /checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/proc_macro_test/index.html
npm WARN deprecated puppeteer@22.15.0: < 24.10.2 is no longer supported
npm ERR! code E409
npm ERR! 409 Conflict - GET https://registry.npmjs.org/inherits/-/inherits-2.0.4.tgz
npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-10-22T11_12_26_794Z-debug-0.log
npm install did not exit successfully
thread 'main' (59853) panicked at src/tools/rustdoc-gui-test/src/main.rs:63:10:
unable to install browser-ui-test: Custom { kind: Other, error: "npm install returned exit code exit status: 1" }
stack backtrace:
0: __rustc::rust_begin_unwind
at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/std/src/panicking.rs:698:5
1: core::panicking::panic_fmt
at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/core/src/panicking.rs:75:14
npm ERR! code E409 npm ERR! 409 Conflict - GET https://registry.npmjs.org/inherits/-/inherits-2.0.4.tgz
Looks quite spurious :)
Indeed!
This looks fine, thank you!
@bors r+ rollup
r? joboet
📌 Commit 827bd00 has been approved by joboet
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
jhpratt added a commit to jhpratt/rust that referenced this pull request
…r=joboet
Implement strip_circumfix lib feature
Tracking issue: rust-lang#147946
bors added a commit that referenced this pull request
Rollup of 12 pull requests
Successful merges:
- #147137 (Mention crate being analyzed in query description)
- #147642 (Miscellaneous const-generics-related fixes)
- #147806 (Ignore test-dashboard related files)
- #147947 (Implement
strip_circumfixlib feature) - #148194 (compiletest: Remove
cleanup_debug_info_options) - #148199 (compiletest: Don't modify
testpathswhen creating aux contexts) - #148247 (Remove two special cases from reachable_non_generics)
- #148348 (dangling ptr lint cleanup)
- #148357 (temporary-lifetime-extension.rs test works in all editions)
- #148362 (docs: makes a note about possible building
rustc 1.91.0 + host toolsfor win7) - #148367 (Use --print host-tuple to get the host)
- #148374 (miri subtree update)
r? @ghost
@rustbot modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request
…r=joboet
Implement strip_circumfix lib feature
Tracking issue: rust-lang#147946
Zalathar added a commit to Zalathar/rust that referenced this pull request
…r=joboet
Implement strip_circumfix lib feature
Tracking issue: rust-lang#147946
bors added a commit that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- #147947 (Implement
strip_circumfixlib feature) - #148170 (split definition and use site hidden tys)
- #148194 (compiletest: Remove
cleanup_debug_info_options) - #148199 (compiletest: Don't modify
testpathswhen creating aux contexts) - #148240 (rustc_codegen: fix musttail returns for cast/indirect ABIs)
- #148290 (Do not emit solver errors that contain error types)
- #148357 (temporary-lifetime-extension.rs test works in all editions)
- #148362 (docs: makes a note about possible building
rustc 1.91.0 + host toolsfor win7) - #148367 (Use --print host-tuple to get the host)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…r=joboet
Implement strip_circumfix lib feature
Tracking issue: rust-lang#147946
This was referenced
Nov 2, 2025
bors added a commit that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- #147137 (Mention crate being analyzed in query description)
- #147155 (arm-linux.md: various fixes/improvements)
- #147642 (Miscellaneous const-generics-related fixes)
- #147806 (Ignore test-dashboard related files)
- #147947 (Implement
strip_circumfixlib feature) - #148346 (Change cfg_trace, cfg_attr_trace symbol values)
- #148348 (dangling ptr lint cleanup)
- #148393 (Remove
tests/run-make/fmt-write-bloat/) - #148400 (Better warning message for crate type unsupported by codegen backend)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #147947 - yotamofek:pr/lib/strip-circumfix, r=joboet
Implement strip_circumfix lib feature
Tracking issue: #147946
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
…r=joboet
Implement strip_circumfix lib feature
Tracking issue: rust-lang#147946
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.