Rename downcast_[ref|mut]_unchecked -> downcast_unchecked_[ref|mut] by taj-p · Pull Request #148079 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits1 Checks11 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Intent
Renames downcast_[ref|mut]_unchecked to downcast_unchecked_[ref|mut] because we want to emphasise that it is the downcast that is unsafe, not the aliasing per:
Tracking Issue: #90850 (comment)
cc @marc0246
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.
cc @rust-lang/rust-analyzer
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.
Relevant to the rust-analyzer team, which will review and decide on the PR/issue.
labels
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Please squash, since revert commits defeat the purpose of submitting changes upstream.
Undo rust-analyzer changes
Please squash, since revert commits defeat the purpose of submitting changes upstream.
Done! Thanks @lnicola 🙏
📌 Commit b247f67 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit that referenced this pull request
Rollup of 22 pull requests
Successful merges:
- #128666 (Add
overflow_checksintrinsic) - #146305 (Add correct suggestion for multi-references for self type in method)
- #147179 ([DebugInfo] Fix container types failing to find template args)
- #147743 (Show packed field alignment in mir_transform_unaligned_packed_ref)
- #148079 (Rename
downcast_[ref|mut]_unchecked->downcast_unchecked_[ref|mut]) - #148084 (Optimize path components iteration on platforms that don't have prefixes)
- #148126 (Fix rust stdlib build failing for VxWorks)
- #148204 (Modify contributor email entries in .mailmap)
- #148279 (rustc_builtin_macros: rename bench parameter to avoid collisions with user-defined function names)
- #148333 (constify result unwrap unchecked)
- #148539 (Add Allocator proxy impls for Box, Rc, and Arc)
- #148601 (
invalid_atomic_ordering: also lintupdate&try_update) - #148612 (Add note for identifier with attempted hygiene violation)
- #148613 (Switch hexagon targets to rust-lld)
- #148619 (Enable std locking functions on AIX)
- #148644 ([bootstrap] Make
--openoption work withdoc src/tools/error_index_generator) - #148649 (don't completely reset
HeadUsages) - #148673 (Remove a remnant of
dyn*from the parser) - #148675 (Remove eslint-js from npm dependencies)
- #148680 (Recover
[T: N]as[T; N]) - #148688 (Remove unused argument
featuresfromeval_config_entry) - #148711 (Use the current lint note id when parsing
cfg!())
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #148079 - taj-p:master, r=Mark-Simulacrum
Rename downcast_[ref|mut]_unchecked -> downcast_unchecked_[ref|mut]
Intent
Renames downcast_[ref|mut]_unchecked to downcast_unchecked_[ref|mut] because we want to emphasise that it is the downcast that is unsafe, not the aliasing per:
Tracking Issue: #90850 (comment)
cc @marc0246
github-actions bot pushed a commit to rust-lang/stdarch that referenced this pull request
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
makai410 pushed a commit to makai410/rustc_public that referenced this pull request
makai410 pushed a commit to makai410/rust that referenced this pull request
Rename downcast_[ref|mut]_unchecked -> downcast_unchecked_[ref|mut]
Intent
Renames downcast_[ref|mut]_unchecked to downcast_unchecked_[ref|mut] because we want to emphasise that it is the downcast that is unsafe, not the aliasing per:
Tracking Issue: rust-lang#90850 (comment)
cc @marc0246
makai410 pushed a commit to makai410/rust that referenced this pull request
makai410 pushed a commit to makai410/rustc_public that referenced this pull request
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
Rename downcast_[ref|mut]_unchecked -> downcast_unchecked_[ref|mut]
Intent
Renames downcast_[ref|mut]_unchecked to downcast_unchecked_[ref|mut] because we want to emphasise that it is the downcast that is unsafe, not the aliasing per:
Tracking Issue: rust-lang#90850 (comment)
cc @marc0246
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.
Relevant to the rust-analyzer team, which will review and decide on the PR/issue.