constify result unwrap unchecked by bend-n · Pull Request #148333 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks11 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

constifies unwrap unchecked on result
will make tracking issue if good

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Oct 31, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

// SAFETY: the safety contract must be upheld by the caller.
Err(_) => unsafe { hint::unreachable_unchecked() },
Err(e) => {
super::mem::forget(e);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be annotated as a const hack so it can potentially be fixed later:

// FIXME(const-hack): to avoid E: const Destruct bound

This comment has been minimized.

r=me with a tracking issue added

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bend-n: 🔑 Insufficient privileges: Not in reviewers

📌 Commit edd7d8a has been approved by mark-simulacrum

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Nov 8, 2025

bors added a commit that referenced this pull request

Nov 9, 2025

Rollup of 22 pull requests

Successful merges:

#128666 (Add overflow_checks intrinsic)
#146305 (Add correct suggestion for multi-references for self type in method)
#147179 ([DebugInfo] Fix container types failing to find template args)
#147743 (Show packed field alignment in mir_transform_unaligned_packed_ref)
#148079 (Rename downcast_[ref|mut]_unchecked -> downcast_unchecked_[ref|mut])
#148084 (Optimize path components iteration on platforms that don't have prefixes)
#148126 (Fix rust stdlib build failing for VxWorks)
#148204 (Modify contributor email entries in .mailmap)
#148279 (rustc_builtin_macros: rename bench parameter to avoid collisions with user-defined function names)
#148333 (constify result unwrap unchecked)
#148539 (Add Allocator proxy impls for Box, Rc, and Arc)
#148601 (invalid_atomic_ordering: also lint update & try_update)
#148612 (Add note for identifier with attempted hygiene violation)
#148613 (Switch hexagon targets to rust-lld)
#148619 (Enable std locking functions on AIX)
#148644 ([bootstrap] Make --open option work with doc src/tools/error_index_generator)
#148649 (don't completely reset HeadUsages)
#148673 (Remove a remnant of dyn* from the parser)
#148675 (Remove eslint-js from npm dependencies)
#148680 (Recover [T: N] as [T; N])
#148688 (Remove unused argument features from eval_config_entry)
#148711 (Use the current lint note id when parsing cfg!())

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Nov 9, 2025

Rollup merge of #148333 - bend-n:const_result_unwrap_unchecked, r=mark-simulacrum

constify result unwrap unchecked

constifies unwrap unchecked on result will make tracking issue if good

bend-n deleted the const_result_unwrap_unchecked branch

November 9, 2025 14:44

github-actions bot pushed a commit to rust-lang/stdarch that referenced this pull request

Nov 10, 2025

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Nov 10, 2025

makai410 pushed a commit to makai410/rustc_public that referenced this pull request

Nov 10, 2025

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 10, 2025

…ed, r=mark-simulacrum

constify result unwrap unchecked

constifies unwrap unchecked on result will make tracking issue if good

makai410 pushed a commit to makai410/rust that referenced this pull request

Nov 10, 2025

makai410 pushed a commit to makai410/rustc_public that referenced this pull request

Nov 16, 2025

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Nov 30, 2025

…ed, r=mark-simulacrum

constify result unwrap unchecked

constifies unwrap unchecked on result will make tracking issue if good

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Nov 30, 2025

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.