rustc: Spawn cmd /c emcc.bat explicitly by alexcrichton · Pull Request #44542 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
In #42436 the behavior for spawning processes on Windows was tweaked slightly to
fix various bugs, but this caused #42791 as a regression, namely that to spawn
batch scripts they need to be manually spawned with cmd /c instead now. This
updates the compiler to handle this case explicitly for Emscripten.
Closes #42791
In rust-lang#42436 the behavior for spawning processes on Windows was tweaked slightly to
fix various bugs, but this caused rust-lang#42791 as a regression, namely that to spawn
batch scripts they need to be manually spawned with cmd /c instead now. This
updates the compiler to handle this case explicitly for Emscripten.
Closes rust-lang#42791
(rust_highfive has picked a reviewer for you, use r? to override)
📌 Commit 5cad391 has been approved by nikomatsakis
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…, r=nikomatsakis
rustc: Spawn cmd /c emcc.bat explicitly
In rust-lang#42436 the behavior for spawning processes on Windows was tweaked slightly to
fix various bugs, but this caused rust-lang#42791 as a regression, namely that to spawn
batch scripts they need to be manually spawned with cmd /c instead now. This
updates the compiler to handle this case explicitly for Emscripten.
Closes rust-lang#42791
alexcrichton added a commit to alexcrichton/rust that referenced this pull request
…, r=nikomatsakis
rustc: Spawn cmd /c emcc.bat explicitly
In rust-lang#42436 the behavior for spawning processes on Windows was tweaked slightly to
fix various bugs, but this caused rust-lang#42791 as a regression, namely that to spawn
batch scripts they need to be manually spawned with cmd /c instead now. This
updates the compiler to handle this case explicitly for Emscripten.
Closes rust-lang#42791
frewsxcv added a commit to frewsxcv/rust that referenced this pull request
…, r=nikomatsakis
rustc: Spawn cmd /c emcc.bat explicitly
In rust-lang#42436 the behavior for spawning processes on Windows was tweaked slightly to
fix various bugs, but this caused rust-lang#42791 as a regression, namely that to spawn
batch scripts they need to be manually spawned with cmd /c instead now. This
updates the compiler to handle this case explicitly for Emscripten.
Closes rust-lang#42791
alexcrichton added a commit to alexcrichton/rust that referenced this pull request
…, r=nikomatsakis
rustc: Spawn cmd /c emcc.bat explicitly
In rust-lang#42436 the behavior for spawning processes on Windows was tweaked slightly to
fix various bugs, but this caused rust-lang#42791 as a regression, namely that to spawn
batch scripts they need to be manually spawned with cmd /c instead now. This
updates the compiler to handle this case explicitly for Emscripten.
Closes rust-lang#42791
bors added a commit that referenced this pull request
Rollup of 19 pull requests
- Successful merges: #44273, #44356, #44395, #44531, #44537, #44542, #44560, #44567, #44574, #44577, #44586, #44589, #44590, #44593, #44598, #44606, #44609, #44616, #44631
- Failed merges:
Labels
Accepted for backporting to the compiler in the beta channel.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.