rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

I am investigating rust's code generation into Gecko by https://bugzilla.mozilla.org/show_bug.cgi?id=1399337.

armv7-linux-androideabi target uses +v7,+thumb2,+vfp3,+d16,-neon as target-feature. But +thumb2 only doesn't generate thumb2 code. To generate thumb2 code, it requires +thumb-mode. So we should add it for armv7-linux-androideabi.

r? @alexcrichton

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bors: r+

How odd! Looks good regardless!

📌 Commit 07494ec has been approved by alexcrichton

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Sep 15, 2017

Require +thumb-mode to generate thumb2 code for Android/armv7-a

I am investigating rust's code generation into Gecko by https://bugzilla.mozilla.org/show_bug.cgi?id=1399337.

r? @alexcrichton

alexcrichton added a commit to alexcrichton/rust that referenced this pull request

Sep 16, 2017

Require +thumb-mode to generate thumb2 code for Android/armv7-a

I am investigating rust's code generation into Gecko by https://bugzilla.mozilla.org/show_bug.cgi?id=1399337.

r? @alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request

Sep 16, 2017

Require +thumb-mode to generate thumb2 code for Android/armv7-a

I am investigating rust's code generation into Gecko by https://bugzilla.mozilla.org/show_bug.cgi?id=1399337.

r? @alexcrichton

alexcrichton added a commit to alexcrichton/rust that referenced this pull request

Sep 17, 2017

Require +thumb-mode to generate thumb2 code for Android/armv7-a

I am investigating rust's code generation into Gecko by https://bugzilla.mozilla.org/show_bug.cgi?id=1399337.

r? @alexcrichton

bors added a commit that referenced this pull request

Sep 17, 2017

Rollup of 19 pull requests

Successful merges: #44273, #44356, #44395, #44531, #44537, #44542, #44560, #44567, #44574, #44577, #44586, #44589, #44590, #44593, #44598, #44606, #44609, #44616, #44631
Failed merges:

@makotokato @alexcrichton Just noticed this, I'm not sure if it's an issue, but conventionally in rustc the arm targets that generate thumb code are named with thumb.. so maybe this target should be renamed now or this should be a separate target. Also this is a breaking change for anyone who was relying on this target to generate ARM code.

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.