Mention that HashMap::new and HashSet::new do not allocate by jonhoo · Pull Request #44609 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

The docs for HashMap::with_capacity and HashSet::with_capacity already say that

If capacity is 0, the hash map/set will not allocate.

However, the docs for ::new do not say that the initial capacity is 0, and thus promise that a call to ::new alone does not allocate. This PR fixes that.

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+ rollup

thanks a ton!

📌 Commit f7e974e has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request

Sep 16, 2017

Mention that HashMap::new and HashSet::new do not allocate

The docs for HashMap::with_capacity and HashSet::with_capacity already say that

If capacity is 0, the hash map/set will not allocate. However, the docs for ::new do not say that the initial capacity is 0, and thus promise that a call to ::new alone does not allocate. This PR fixes that.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request

Sep 16, 2017

Mention that HashMap::new and HashSet::new do not allocate

The docs for HashMap::with_capacity and HashSet::with_capacity already say that

If capacity is 0, the hash map/set will not allocate. However, the docs for ::new do not say that the initial capacity is 0, and thus promise that a call to ::new alone does not allocate. This PR fixes that.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request

Sep 17, 2017

Mention that HashMap::new and HashSet::new do not allocate

The docs for HashMap::with_capacity and HashSet::with_capacity already say that

If capacity is 0, the hash map/set will not allocate. However, the docs for ::new do not say that the initial capacity is 0, and thus promise that a call to ::new alone does not allocate. This PR fixes that.

bors added a commit that referenced this pull request

Sep 17, 2017

Rollup of 19 pull requests

Successful merges: #44273, #44356, #44395, #44531, #44537, #44542, #44560, #44567, #44574, #44577, #44586, #44589, #44590, #44593, #44598, #44606, #44609, #44616, #44631
Failed merges:

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.