use fmt::Result where applicable by llogiq · Pull Request #50550 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This is a quite boring PR, but I think the type alias improves readability, so why not use it?

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

This comment has been minimized.

@kennytm I think bors needs a 'r+' message to merge, right?

📌 Commit e333725 has been approved by petrochenkov

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 10, 2018

alexcrichton added a commit to alexcrichton/rust that referenced this pull request

May 11, 2018

use fmt::Result where applicable

This is a quite boring PR, but I think the type alias improves readability, so why not use it?

kennytm added a commit to kennytm/rust that referenced this pull request

May 12, 2018

use fmt::Result where applicable

This is a quite boring PR, but I think the type alias improves readability, so why not use it?

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request

May 12, 2018

use fmt::Result where applicable

This is a quite boring PR, but I think the type alias improves readability, so why not use it?

bors added a commit that referenced this pull request

May 12, 2018

Rollup of 13 pull requests

Successful merges:

#50544 (Cleanup some dependencies)
#50545 (Made some functions in time module const)
#50550 (use fmt::Result where applicable)
#50558 (Remove all reference to DepGraph::work_products)
#50602 (Update canonicalize docs)
#50607 (Allocate Symbol strings from an arena)
#50613 (Migrate the toolstate update bot to rust-highfive)
#50624 (fs::write: Add example writing a &str)
#50634 (Do not silently truncate offsets for read_at/write_at on emscripten)
#50644 (AppVeyor: Read back trace from crash dump on failure.)
#50661 (Ignore non .rs files for tidy libcoretest)
#50663 (rustc: Allow an edition's feature on that edition)
#50667 (rustc: Only suggest deleting extern crate if it works)

Failed merges:

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.