rustc: Only suggest deleting `extern crate` if it works by alexcrichton · Pull Request #50667 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This commit updates one of the edition lints to only suggest deleting extern crate if it actually works. Otherwise this can yield some confusing behavior
with rustfix specifically where if you accidentally deny the rust_2018_idioms
lint in the 2015 edition it's suggesting features that don't work!

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:55:03] failures:
[00:55:03] 
[00:55:03] ---- [ui] ui-fulldeps/unnecessary-extern-crate.rs stdout ----
[00:55:03]  
[00:55:03] error: ui test compiled successfully!
[00:55:03] status: exit code: 0
[00:55:03] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/unnecessary-extern-crate.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/unnecessary-extern-crate.stage2-x86_64-unknown-linux-gnu" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/unnecessary-extern-crate.stage2-x86_64-unknown-linux-gnu.aux" "-A" "unused"
[00:55:03] ------------------------------------------
[00:55:03] 
[00:55:03] ------------------------------------------
[00:55:03] stderr:
---
[00:55:03] 
[00:55:03] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:492:22
[00:55:03] 
[00:55:03] 
[00:55:03] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:55:03] 
[00:55:03] 
[00:55:03] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:55:03] Build completed unsuccessfully in 0:16:49
[00:55:03] Build completed unsuccessfully in 0:16:49
[00:55:03] make: *** [check] Error 1
[00:55:03] Makefile:58: recipe for target 'check' failed
2939368 ./obj
2937108 ./obj/build
2162080 ./obj/build/x86_64-unknown-linux-gnu
725912 ./src
---
149744 ./.git/modules
149740 ./.git/modules/src
149124 ./src/llvm-emscripten/test
124332 ./obj/build/bootstrap/debug/incremental/bootstrap-182x3aewwy26b
124328 ./obj/build/bootstrap/debug/incremental/bootstrap-182x3aewwy26b/s-f0y00zypmb-1bxjef-22v3gsapbxtg7
116624 .🔚after_failure.2
travis_time:start:0706b7e7
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time🔚0706b7e7:start=1526066978521963326,finish=1526066978527265621,duration=5302295

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

This commit updates one of the edition lints to only suggest deleting extern crate if it actually works. Otherwise this can yield some confusing behavior with rustfix specifically where if you accidentally deny the rust_2018_idioms lint in the 2015 edition it's suggesting features that don't work!

📌 Commit 12f92e9 has been approved by Manishearth

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 11, 2018

bors added a commit that referenced this pull request

May 12, 2018

Rollup of 13 pull requests

Successful merges:

#50544 (Cleanup some dependencies)
#50545 (Made some functions in time module const)
#50550 (use fmt::Result where applicable)
#50558 (Remove all reference to DepGraph::work_products)
#50602 (Update canonicalize docs)
#50607 (Allocate Symbol strings from an arena)
#50613 (Migrate the toolstate update bot to rust-highfive)
#50624 (fs::write: Add example writing a &str)
#50634 (Do not silently truncate offsets for read_at/write_at on emscripten)
#50644 (AppVeyor: Read back trace from crash dump on failure.)
#50661 (Ignore non .rs files for tidy libcoretest)
#50663 (rustc: Allow an edition's feature on that edition)
#50667 (rustc: Only suggest deleting extern crate if it works)

Failed merges:

kennytm added a commit to kennytm/rust that referenced this pull request

May 13, 2018

…-unless-works, r=Manishearth

rustc: Only suggest deleting extern crate if it works