Migrate the toolstate update bot to rust-highfive by kennytm · Pull Request #50613 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation32 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Rationale: Only members of the rust-lang organization can mention its teams. That means #50434 has no effect if we are still using @kennytm-githubbot.

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

📌 Commit 26321af has been approved by alexcrichton

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 10, 2018

kennytm added a commit to kennytm/rust that referenced this pull request

May 12, 2018

…ive, r=alexcrichton

Migrate the toolstate update bot to rust-highfive

Rationale: Only members of the rust-lang organization can mention its teams. That means rust-lang#50434 has no effect if we are still using @kennytm-githubbot.

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

May 12, 2018

bors added a commit that referenced this pull request

May 12, 2018

Rollup of 13 pull requests

Successful merges:

#50544 (Cleanup some dependencies)
#50545 (Made some functions in time module const)
#50550 (use fmt::Result where applicable)
#50558 (Remove all reference to DepGraph::work_products)
#50602 (Update canonicalize docs)
#50607 (Allocate Symbol strings from an arena)
#50613 (Migrate the toolstate update bot to rust-highfive)
#50624 (fs::write: Add example writing a &str)
#50634 (Do not silently truncate offsets for read_at/write_at on emscripten)
#50644 (AppVeyor: Read back trace from crash dump on failure.)
#50661 (Ignore non .rs files for tidy libcoretest)
#50663 (rustc: Allow an edition's feature on that edition)
#50667 (rustc: Only suggest deleting extern crate if it works)

Failed merges:

This comment has been minimized.

kennytm changed the title~~Migrate the toolstate update bot to rust-highfive~~ [WIP — checking permission] Migrate the toolstate update bot to rust-highfive

May 13, 2018

This comment has been minimized.

@alexcrichton rust-highfive still cannot push anything even though I've made it a collaborator, and I believe it has accepted the invitation. What else maybe missing?

git config --global user.email '34210020+rust-toolstate-update@users.noreply.github.com'
BRANCH=test

git config --global user.email '7378925+rust-toolstate-update@users.noreply.github.com'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/rust-toolstate-update/rust-highfive/

.... maybe? (unsure)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcrichton The + part is just a comment, and 7378925 is already rust-highfive's user ID :(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! I can't think of any other reason though locally why it wouldn't be working...

Maybe I could try regenerating the tokens if this update doesn't work?

This comment has been minimized.

bors added a commit that referenced this pull request

May 14, 2018

[WIP — checking permission] Migrate the toolstate update bot to rust-highfive

Rationale: Only members of the rust-lang organization can mention its teams. That means #50434 has no effect if we are still using @kennytm-githubbot.

This comment has been minimized.

kennytm changed the title~~[WIP — checking permission] Migrate the toolstate update bot to rust-highfive~~ Migrate the toolstate update bot to rust-highfive

May 14, 2018

📌 Commit 2ccf71c has been approved by alexcrichton

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

May 14, 2018

kennytm added a commit to kennytm/rust that referenced this pull request

May 14, 2018

…ive, r=alexcrichton

Migrate the toolstate update bot to rust-highfive

Rationale: Only members of the rust-lang organization can mention its teams. That means rust-lang#50434 has no effect if we are still using @kennytm-githubbot.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

May 15, 2018

…ive, r=alexcrichton

Migrate the toolstate update bot to rust-highfive

Rationale: Only members of the rust-lang organization can mention its teams. That means rust-lang#50434 has no effect if we are still using @kennytm-githubbot.

bors added a commit that referenced this pull request

May 15, 2018

Rollup of 11 pull requests

Successful merges:

#49767 (Rewrite docs for std::ptr)
#50399 (save-analysis: handle aliasing imports a bit more nicely)
#50594 (Update the man page with additional --print options)
#50613 (Migrate the toolstate update bot to rust-highfive)
#50632 (Add minification process)
#50685 (ci: Add Dockerfile for dist-sparc64-linux)
#50691 (rustdoc: Add support for pub(restricted))
#50712 (Improve eager type resolution error message)
#50720 (Add “Examples” section header in f32/f64 doc comments.)
#50733 (Hyperlink DOI against preferred resolver)
#50745 (Uncapitalize "You")

Failed merges:

kennytm deleted the update-toolstate-with-highfive branch

May 15, 2018 15:54

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.