App-lint-cability by zackmdavis · Pull Request #52968 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
@eminence recently pointed out (rust-lang/cargo#5846) that it's
surprising that cargo fix (now shipping with Cargo itself!) doesn't
fix very common lint warnings, which is as good of a reminder as any
that we should finish #50723.
(Previously, we did this on the librustc and libsyntax crates in #50724. I filed rust-lang/this-week-in-rust#685 in hopes of recruiting new contributors to do the rest.)
r? @estebank
This comment has been minimized.
Andrew Chin recently pointed out (rust-lang/cargo#5846) that it's
surprising that cargo fix (now shipping with Cargo itself!) doesn't
fix very common lint warnings, which is as good of a reminder as any
that we should finish rust-lang#50723.
Thank you! I'd really like to see rustfix tests for this, though :)
@zackmdavis oh, right, we should really upgrade these tests to use a newer rustfix and enable filtering!
📌 Commit 6e63b0d has been approved by estebank
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
kennytm added a commit to kennytm/rust that referenced this pull request
bors added a commit that referenced this pull request
Rollup of 14 pull requests
Successful merges:
- #51919 (Provide
{to,from}_{ne,le,be}_bytesfunctions on integers) - #52940 (Align 6-week cycle check with beta promotion instead of stable release.)
- #52968 (App-lint-cability)
- #52969 (rustbuild: fix local_rebuild)
- #52995 (Remove unnecessary local in await! generator)
- #52996 (RELEASES.md: fix the
hash_map::Entry::or_defaultlink) - #53001 (privacy: Fix an ICE in
path_is_private_type) - #53003 (Stabilize --color and --error-format options in rustdoc)
- #53022 (volatile operations docs: clarify that this does not help wrt. concurrency)
- #53024 (Specify reentrancy gurantees of
Once::call_once) - #53041 (Fix invalid code css rule)
- #53047 (Make entire row of doc search results clickable)
- #53050 (Make left column of rustdoc search results narrower)
- #53062 (Remove redundant field names in structs)
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.