rustbuild: fix local_rebuild by Keruspe · Pull Request #52969 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
If we detect a local rebuild (e.g. bootstrap compiler is the same version as target compiler), we set stage to 1.
When trying to build e.g. UnstableBook, we use Mode::ToolBootstrap and stage is 1.
Just allow Mode::ToolBootstrap and stagge != 0 if we are in a local_rebuild
This fixes building current master using current beta (as master hasn't yet been bumped to 1.30).
This should be backported to beta too, as currently we cannot build beta using itself because of that.
If we detect a local rebuild (e.g. bootstrap compiler is the same version as target compiler), we set stage to 1. When trying to build e.g. UnstableBook, we use Mode::ToolBootstrap and stage is 1. Just allow Mode::ToolBootstrap and stagge != 0 if we are in a local_rebuild
Signed-off-by: Marc-Antoine Perennou Marc-Antoine@Perennou.com
📌 Commit 66a4718 has been approved by alexcrichton
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
cramertj added a commit to cramertj/rust that referenced this pull request
rustbuild: fix local_rebuild
If we detect a local rebuild (e.g. bootstrap compiler is the same version as target compiler), we set stage to 1. When trying to build e.g. UnstableBook, we use Mode::ToolBootstrap and stage is 1. Just allow Mode::ToolBootstrap and stagge != 0 if we are in a local_rebuild
This fixes building current master using current beta (as master hasn't yet been bumped to 1.30). This should be backported to beta too, as currently we cannot build beta using itself because of that.
cramertj added a commit to cramertj/rust that referenced this pull request
rustbuild: fix local_rebuild
If we detect a local rebuild (e.g. bootstrap compiler is the same version as target compiler), we set stage to 1. When trying to build e.g. UnstableBook, we use Mode::ToolBootstrap and stage is 1. Just allow Mode::ToolBootstrap and stagge != 0 if we are in a local_rebuild
This fixes building current master using current beta (as master hasn't yet been bumped to 1.30). This should be backported to beta too, as currently we cannot build beta using itself because of that.
kennytm added a commit to kennytm/rust that referenced this pull request
rustbuild: fix local_rebuild
If we detect a local rebuild (e.g. bootstrap compiler is the same version as target compiler), we set stage to 1. When trying to build e.g. UnstableBook, we use Mode::ToolBootstrap and stage is 1. Just allow Mode::ToolBootstrap and stagge != 0 if we are in a local_rebuild
This fixes building current master using current beta (as master hasn't yet been bumped to 1.30). This should be backported to beta too, as currently we cannot build beta using itself because of that.
bors added a commit that referenced this pull request
Rollup of 14 pull requests
Successful merges:
- #51919 (Provide
{to,from}_{ne,le,be}_bytesfunctions on integers) - #52940 (Align 6-week cycle check with beta promotion instead of stable release.)
- #52968 (App-lint-cability)
- #52969 (rustbuild: fix local_rebuild)
- #52995 (Remove unnecessary local in await! generator)
- #52996 (RELEASES.md: fix the
hash_map::Entry::or_defaultlink) - #53001 (privacy: Fix an ICE in
path_is_private_type) - #53003 (Stabilize --color and --error-format options in rustdoc)
- #53022 (volatile operations docs: clarify that this does not help wrt. concurrency)
- #53024 (Specify reentrancy gurantees of
Once::call_once) - #53041 (Fix invalid code css rule)
- #53047 (Make entire row of doc search results clickable)
- #53050 (Make left column of rustdoc search results narrower)
- #53062 (Remove redundant field names in structs)
Is it possible to nominate this for backport to the beta branch?
Nominated for beta, as requested.
bors added a commit that referenced this pull request
[beta] Rollup backports
Merged and approved:
- #53653: Address two regressions
- #53377: std: Use target_pointer_width for BACKTRACE_ELF_SIZE
- #52969: rustbuild: fix local_rebuild
r? @ghost
Labels
Accepted for backporting to the compiler in the beta channel.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.