Specify reentrancy gurantees of Once::call_once by matklad · Pull Request #53024 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
I don't think the docs are clear about what happens in the following code
static INIT: Once = ONCE_INIT;
INIT.call_once(|| INIT.call_once(|| println!("huh?")));
Let's "specify" the behavior to make it clear that the current behavior (deadlock I think?) is not a strict guarantee.
(rust_highfive has picked a reviewer for you, use r? to override)
To expand a bit, I think we can guarantee a deadlock, but I can imagine that, for example, with debug_assertions we might want to escalate that to panic someday, so the aim here is to preserve the flexibility of implementation.
This comment has been minimized.
📌 Commit a2f9aaf has been approved by alexcrichton
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
cramertj added a commit to cramertj/rust that referenced this pull request
kennytm added a commit to kennytm/rust that referenced this pull request
bors added a commit that referenced this pull request
Rollup of 14 pull requests
Successful merges:
- #51919 (Provide
{to,from}_{ne,le,be}_bytesfunctions on integers) - #52940 (Align 6-week cycle check with beta promotion instead of stable release.)
- #52968 (App-lint-cability)
- #52969 (rustbuild: fix local_rebuild)
- #52995 (Remove unnecessary local in await! generator)
- #52996 (RELEASES.md: fix the
hash_map::Entry::or_defaultlink) - #53001 (privacy: Fix an ICE in
path_is_private_type) - #53003 (Stabilize --color and --error-format options in rustdoc)
- #53022 (volatile operations docs: clarify that this does not help wrt. concurrency)
- #53024 (Specify reentrancy gurantees of
Once::call_once) - #53041 (Fix invalid code css rule)
- #53047 (Make entire row of doc search results clickable)
- #53050 (Make left column of rustdoc search results narrower)
- #53062 (Remove redundant field names in structs)
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.