Implement a lint that highlights all moves larger than a configured limit by oli-obk · Pull Request #83519 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation16 Commits5 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Tracking issue: #83518
MCP 420 still ~~blazing~~ in progress

r? @pnkfelix

The main open issue I see with this minimal impl of the feature is that the lint is immediately "stable" (so it can be named on stable), even if it is never executed on stable. I don't think we have the concept of unstable lint names or hiding lint names without an active feature gate, so that would be a bigger change.

This comment has been minimized.

// edition:2018

fn main() {
let x = async { //~ ERROR large_assignments

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a particularly interesting instance of the problem (and perhaps a huge motivation for this lint).

@rustbot label: -S-waiting-on-review +S-waiting-on-author

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 18, 2021

(i'll take over authorship here; oli already okayed me doing so.)

(I rebased oli's work, but did not make any significant change to it so far. As long as I continue to not see any need for modifications, I think I can be trusted as a reviewer.)

At some point, I think the people using this will want an easy to invoke it without having to modify their source code. Right now, you can do so on nightly by using these options:

rustc /tmp/large-stuff.rs '-Zcrate-attr=feature(large_assignments)' '-Zcrate-attr=move_size_limit="1000"'

(which is not perhaps ideal, but it is good enough for now for people to get their feet wet with this.)

📌 Commit 85b1c67 has been approved by pnkfelix

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Apr 20, 2021

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Apr 20, 2021

…ode, r=pnkfelix

Implement a lint that highlights all moves larger than a configured limit

Tracking issue: rust-lang#83518 MCP 420 still ~~blazing~~ in progress

r? @pnkfelix

⌛ Testing commit 85b1c67 with merge 1a254950b12c75287c4652d1dbfe2e08a3ab346f...

bors added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Apr 21, 2021

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

2021-04-21T08:02:23.5205676Z ##[section]Starting: Request a runner to run this job
2021-04-21T08:02:28.8016165Z Can't find any online and idle self-hosted runner in current repository that matches the required labels: 'ubuntu-latest-xl'
2021-04-21T08:02:28.8467672Z Can't find any online and idle self-hosted runner in current repository's organization account that matches the required labels: 'ubuntu-latest-xl'
2021-04-21T08:02:28.9378485Z Found online and idle hosted runner in current repository's organization account that matches the required labels: 'ubuntu-latest-xl'
2021-04-21T08:02:29.0355646Z ##[section]Finishing: Request a runner to run this job

@bors retry

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 24, 2021

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request

Apr 24, 2021

…ode, r=pnkfelix

Implement a lint that highlights all moves larger than a configured limit

Tracking issue: rust-lang#83518 MCP 420 still ~~blazing~~ in progress

r? @pnkfelix

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request

Apr 24, 2021

…ode, r=pnkfelix

Implement a lint that highlights all moves larger than a configured limit

Tracking issue: rust-lang#83518 MCP 420 still ~~blazing~~ in progress

r? @pnkfelix

JohnTitor added a commit to JohnTitor/rust that referenced this pull request

Apr 24, 2021

…ode, r=pnkfelix

Implement a lint that highlights all moves larger than a configured limit

Tracking issue: rust-lang#83518 MCP 420 still ~~blazing~~ in progress

r? @pnkfelix

JohnTitor added a commit to JohnTitor/rust that referenced this pull request

Apr 24, 2021

…ode, r=pnkfelix

Implement a lint that highlights all moves larger than a configured limit

Tracking issue: rust-lang#83518 MCP 420 still ~~blazing~~ in progress

r? @pnkfelix

This was referenced

Apr 24, 2021

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 24, 2021

Rollup of 8 pull requests

Successful merges:

rust-lang#83519 (Implement a lint that highlights all moves larger than a configured limit)
rust-lang#84105 (stabilize core::array::{from_ref,from_mut} in 1.53.0)
rust-lang#84179 (Explicitly implement !Send and !Sync for sys::{Args, Env})
rust-lang#84427 (Update Clippy)
rust-lang#84459 (rustdoc: Turn JsonRenderer::mod_item_in into unreachable!())
rust-lang#84460 (rustdoc: Remove unnecessary is_crate field from doctree::Module and clean::Module)
rust-lang#84464 (rustdoc: Get rid of clean::TypeKind)
rust-lang#84518 (Clean up DOM strings)

Failed merges:

r? @ghost @rustbot modify labels: rollup

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.