Explicitly implement !Send and !Sync for sys::{Args, Env} by CDirkx · Pull Request #84179 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation15 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Remove the field _dont_send_or_sync_me: PhantomData<*mut ()> in favor of an explicit implementation of !Send and !Sync.

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me. One typo:

📌 Commit b29a887 has been approved by m-ou-se

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 14, 2021

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request

Apr 14, 2021

Explicitly implement !Send and !Sync for sys::{Args, Env}

Remove the field _dont_send_or_sync_me: PhantomData<*mut ()> in favor of an explicit implementation of !Send and !Sync.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request

Apr 14, 2021

Explicitly implement !Send and !Sync for sys::{Args, Env}

Remove the field _dont_send_or_sync_me: PhantomData<*mut ()> in favor of an explicit implementation of !Send and !Sync.

⌛ Testing commit b29a887 with merge ef45544547ed2665a9d9d072fa90accc1512038b...

This comment has been minimized.

bors added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Apr 14, 2021

Oops another typo, fixed.

📌 Commit 2ecc820 has been approved by m-ou-se

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 21, 2021

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request

Apr 22, 2021

Explicitly implement !Send and !Sync for sys::{Args, Env}

Remove the field _dont_send_or_sync_me: PhantomData<*mut ()> in favor of an explicit implementation of !Send and !Sync.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request

Apr 22, 2021

Explicitly implement !Send and !Sync for sys::{Args, Env}

Remove the field _dont_send_or_sync_me: PhantomData<*mut ()> in favor of an explicit implementation of !Send and !Sync.

This was referenced

Apr 22, 2021

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request

Apr 22, 2021

Explicitly implement !Send and !Sync for sys::{Args, Env}

Remove the field _dont_send_or_sync_me: PhantomData<*mut ()> in favor of an explicit implementation of !Send and !Sync.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request

Apr 22, 2021

Explicitly implement !Send and !Sync for sys::{Args, Env}

Remove the field _dont_send_or_sync_me: PhantomData<*mut ()> in favor of an explicit implementation of !Send and !Sync.

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Apr 22, 2021

📌 Commit dc110af has been approved by m-ou-se

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Apr 24, 2021

JohnTitor added a commit to JohnTitor/rust that referenced this pull request

Apr 24, 2021

Explicitly implement !Send and !Sync for sys::{Args, Env}

Remove the field _dont_send_or_sync_me: PhantomData<*mut ()> in favor of an explicit implementation of !Send and !Sync.

This was referenced

Apr 24, 2021

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 24, 2021

Rollup of 8 pull requests

Successful merges:

• rust-lang#83519 (Implement a lint that highlights all moves larger than a configured limit)
• rust-lang#84105 (stabilize core::array::{from_ref,from_mut} in 1.53.0)
• rust-lang#84179 (Explicitly implement !Send and !Sync for sys::{Args, Env})
• rust-lang#84427 (Update Clippy)
• rust-lang#84459 (rustdoc: Turn JsonRenderer::mod_item_in into unreachable!())
• rust-lang#84460 (rustdoc: Remove unnecessary is_crate field from doctree::Module and clean::Module)
• rust-lang#84464 (rustdoc: Get rid of clean::TypeKind)
• rust-lang#84518 (Clean up DOM strings)

Failed merges:

r? @ghost @rustbot modify labels: rollup

CDirkx deleted the dont_send_sync branch

April 24, 2021 21:25

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.