rustdoc: Remove unnecessary is_crate field from doctree::Module and clean::Module by jyn514 · Pull Request #84460 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation20 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
It can be calculated on-demand even without a TyCtxt.
This also changed json::conversions::from_item_kind to take a whole item, which avoids
having to add more and more parameters.
Helps with #76382.
r? @camelid
Category: PRs that clean code up or issues documenting cleanup.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
… clean::Module
It can be calculated on-demand even without a TyCtxt.
This also changed from_item_kind to take a whole item, which avoids
having to add more and more parameters.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, r=me after that.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
📌 Commit e29f46c has been approved by camelid
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
JohnTitor added a commit to JohnTitor/rust that referenced this pull request
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request
rustdoc: Remove unnecessary is_crate field from doctree::Module and clean::Module
It can be calculated on-demand even without a TyCtxt.
This also changed json::conversions::from_item_kind to take a whole item, which avoids
having to add more and more parameters.
Helps with rust-lang#76382.
r? @camelid
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request
rustdoc: Remove unnecessary is_crate field from doctree::Module and clean::Module
It can be calculated on-demand even without a TyCtxt.
This also changed json::conversions::from_item_kind to take a whole item, which avoids
having to add more and more parameters.
Helps with rust-lang#76382.
r? @camelid
JohnTitor added a commit to JohnTitor/rust that referenced this pull request
rustdoc: Remove unnecessary is_crate field from doctree::Module and clean::Module
It can be calculated on-demand even without a TyCtxt.
This also changed json::conversions::from_item_kind to take a whole item, which avoids
having to add more and more parameters.
Helps with rust-lang#76382.
r? @camelid
JohnTitor added a commit to JohnTitor/rust that referenced this pull request
rustdoc: Remove unnecessary is_crate field from doctree::Module and clean::Module
It can be calculated on-demand even without a TyCtxt.
This also changed json::conversions::from_item_kind to take a whole item, which avoids
having to add more and more parameters.
Helps with rust-lang#76382.
r? @camelid
This was referenced
Apr 24, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- rust-lang#83519 (Implement a lint that highlights all moves larger than a configured limit)
- rust-lang#84105 (stabilize
core::array::{from_ref,from_mut}in1.53.0) - rust-lang#84179 (Explicitly implement
!Sendand!Syncforsys::{Args, Env}) - rust-lang#84427 (Update Clippy)
- rust-lang#84459 (rustdoc: Turn
JsonRenderer::mod_item_inintounreachable!()) - rust-lang#84460 (rustdoc: Remove unnecessary
is_cratefield from doctree::Module and clean::Module) - rust-lang#84464 (rustdoc: Get rid of
clean::TypeKind) - rust-lang#84518 (Clean up DOM strings)
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Labels
Category: PRs that clean code up or issues documenting cleanup.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the rustdoc team, which will review and decide on the PR/issue.