Let rust-analyzer ship on stable, non-preview by cuviper · Pull Request #98640 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

cuviper

The consensus on rust-lang/rust-analyzer#12432 seems to be that we are ready for rust-analyzer to ship as a rustup component on the beta and stable channels. This won't always be the preferred distribution method, e.g. the VS Code extension will probably still independently update to its weekly releases, but it's still useful to have a component that follows the release train with the rest of the Rust toolchain. So this removes the nightly-only gating on the bundled component, and removes the "-preview" suffix as well by the usual renaming mechanism.

cc @rust-lang/wg-rls-2 @rust-lang/release

lnicola, matklad, Veykril, Kobzol, tshepang, linuxtim, runiq, jonhoo, and azzamsa reacted with heart emoji kornelski, jjpe, and azzamsa reacted with rocket emoji

@cuviper

@rust-highfive

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

lnicola

Mark-Simulacrum

// not be included.
if !builder.build.unstable_features() {
return None;
}
let compiler = self.compiler;
let target = self.target;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a tarball.is_preview below that needs updating I think.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, but cause the actual component remains "*-preview" for the purpose of rustup updates, while the new rename is basically just an alias. We have the same thing still set on all formerly-preview components, even rustfmt.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, interesting. We should consider if there's a way to migrate, feels off that we need to keep what seems like the canonical name the same. Maybe the renames need to be in the other direction or something too?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe so, but we'll need to work with rustup folks to be sure the upgrade path works.

@Mark-Simulacrum

It looks like src/bootstrap/tool.rs needs an update to RustAnalyzer to set stable=true too.

r=me with that done.

@ehuss ehuss mentioned this pull request

Jun 30, 2022

@cuviper

@cuviper

@bors

📌 Commit c29e584 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 30, 2022

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 30, 2022

@matthiaskrgr

…k-Simulacrum

Let rust-analyzer ship on stable, non-preview

The consensus on rust-lang/rust-analyzer#12432 seems to be that we are ready for rust-analyzer to ship as a rustup component on the beta and stable channels. This won't always be the preferred distribution method, e.g. the VS Code extension will probably still independently update to its weekly releases, but it's still useful to have a component that follows the release train with the rest of the Rust toolchain. So this removes the nightly-only gating on the bundled component, and removes the "-preview" suffix as well by the usual renaming mechanism.

cc @rust-lang/wg-rls-2 @rust-lang/release

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jul 1, 2022

@bors

@ehuss ehuss mentioned this pull request

Jul 6, 2022

@cuviper cuviper added the relnotes

Marks issues that should be documented in the release notes of the next release.

label

Jul 20, 2022

wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request

Oct 11, 2022

@he32

Pkgsrc changes:

Upstream changes:

Version 1.64.0 (2022-09-22)

Language

Compiler

Libraries

Stabilized APIs

These types were previously stable in std::ffi, but are now also available in core and alloc:

These types were previously stable in std::os::raw, but are now also available in core::ffi and std::ffi:

These APIs are now usable in const contexts:

Cargo

Misc

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools.

@cuviper cuviper deleted the stable-rust-analyzer branch

October 15, 2022 00:16

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request

Nov 16, 2022

@he32

Pkgsrc changes:

Upstream changes:

Version 1.64.0 (2022-09-22)

Language

Compiler

Libraries

Stabilized APIs

These types were previously stable in std::ffi, but are now also available in core and alloc:

These types were previously stable in std::os::raw, but are now also available in core::ffi and std::ffi:

These APIs are now usable in const contexts:

Cargo

Misc

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools.

Labels

relnotes

Marks issues that should be documented in the release notes of the next release.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.