Optimize Vec::insert for the case where index == len. by nnethercote · Pull Request #98755 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

By skipping the call to copy with a zero length. This makes it closer
to push.

I did this recently for SmallVec
(servo/rust-smallvec#282) and it was a big perf win in
one case. Although I don't have a specific use case in mind, it seems
worth doing it for Vec as well.

Things to note:

• In the index < len case, the number of conditions checked is
  unchanged.
• In the index == len case, the number of conditions checked increases
  by one, but the more expensive zero-length copy is avoided.
• In the index > len case the code now reserves space for the extra
  element before panicking. This seems like an unimportant change.

r? @cuviper

By skipping the call to copy with a zero length. This makes it closer to push.

I did this recently for SmallVec (servo/rust-smallvec#282) and it was a big perf win in one case. Although I don't have a specific use case in mind, it seems worth doing it for Vec as well.

Things to note:

• In the index < len case, the number of conditions checked is unchanged.
• In the index == len case, the number of conditions checked increases by one, but the more expensive zero-length copy is avoided.
• In the index > len case the code now reserves space for the extra element before panicking. This seems like an unimportant change.

rustbot added the T-libs

Relevant to the library team, which will review and decide on the PR/issue.

label

Jul 1, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

LGTM; not r+ing because you asked for a specific reviewer.

OK -- let's merge alone for perf, but I'm not sure if it's used anywhere in the compiler anyway.

@bors r+ rollup=never

📌 Commit 679c5ee has been approved by cuviper

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 1, 2022

Finished benchmarking commit (f99f9e4): comparison url.

Instruction count

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: 🎉 relevant improvements found

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: no relevant changes found

Cycles

Results

• Primary benchmarks: 😿 relevant regression found
• Secondary benchmarks: 😿 relevant regression found

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩2 ↩3
2. number of relevant changes ↩ ↩2 ↩3

Wow, we actually got a few speedups on the benchmarks. Nice.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "infallible" comment is now a lie and needs extra justification.

wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request

Oct 11, 2022

Pkgsrc changes:

• Add patch to fix vendor/kqueue issue (on 32-bit hosts)
• Adjust other patches & line numbers
• Version bumps & checksum changes.

Upstream changes:

Version 1.64.0 (2022-09-22)

Language

• Unions with mutable references or tuples of allowed types are now allowed

• It is now considered valid to deallocate memory pointed to by a shared reference &T if every byte in T is inside an UnsafeCell

• Unused tuple struct fields are now warned against in an allow-by-default lint, [unused_tuple_struct_fields] (rust-lang/rust#95977), similar to the existing warning for unused struct fields. This lint will become warn-by-default in the future.

Compiler

• [Add Nintendo Switch as tier 3 target] (rust-lang/rust#88991)
  • Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support.
• [Only compile #[used] as llvm.compiler.used for ELF targets] (rust-lang/rust#93718)
• [Add the --diagnostic-width compiler flag to define the terminal width.] (rust-lang/rust#95635)
• [Add support for link-flavor rust-lld for iOS, tvOS and watchOS] (rust-lang/rust#98771)

Libraries

• [Remove restrictions on compare-exchange memory ordering.] (rust-lang/rust#98383)
• You can now write! or writeln! into an OsString: Implement fmt::Write for OsString
• [Make RwLockReadGuard covariant] (rust-lang/rust#96820)
• [Implement FusedIterator for std:🥅:[Into]Incoming] (rust-lang/rust#97300)
• [impl<T: AsRawFd> AsRawFd for {Arc,Box}<T>] (rust-lang/rust#97437)
• [ptr::copy and ptr::swap are doing untyped copies] (rust-lang/rust#97712)
• [Add cgroupv1 support to available_parallelism] (rust-lang/rust#97925)
• [Mitigate many incorrect uses of mem::uninitialized] (rust-lang/rust#99182)

Stabilized APIs

• [future::IntoFuture] (https://doc.rust-lang.org/stable/std/future/trait.IntoFuture.html)
• [future::poll_fn] (https://doc.rust-lang.org/stable/std/future/fn.poll_fn.html)
• [task::ready!] (https://doc.rust-lang.org/stable/std/task/macro.ready.html)
• [num::NonZero*::checked_mul] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_mul)
• [num::NonZero*::checked_pow] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_pow)
• [num::NonZero*::saturating_mul] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.saturating_mul)
• [num::NonZero*::saturating_pow] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.saturating_pow)
• [num::NonZeroI*::abs] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.abs)
• [num::NonZeroI*::checked_abs] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.checked_abs)
• [num::NonZeroI*::overflowing_abs] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.overflowing_abs)
• [num::NonZeroI*::saturating_abs] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.saturating_abs)
• [num::NonZeroI*::unsigned_abs] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.unsigned_abs)
• [num::NonZeroI*::wrapping_abs] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.wrapping_abs)
• [num::NonZeroU*::checked_add] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_add)
• [num::NonZeroU*::checked_next_power_of_two] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_next_power_of_two)
• [num::NonZeroU*::saturating_add] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.saturating_add)
• [os::unix::process::CommandExt::process_group] (https://doc.rust-lang.org/stable/std/os/unix/process/trait.CommandExt.html#tymethod.process_group)
• [os::windows::fs::FileTypeExt::is_symlink_dir] (https://doc.rust-lang.org/stable/std/os/windows/fs/trait.FileTypeExt.html#tymethod.is_symlink_dir)
• [os::windows::fs::FileTypeExt::is_symlink_file] (https://doc.rust-lang.org/stable/std/os/windows/fs/trait.FileTypeExt.html#tymethod.is_symlink_file)

These types were previously stable in std::ffi, but are now also available in core and alloc:

• [core::ffi::CStr] (https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html)
• [core::ffi::FromBytesWithNulError] (https://doc.rust-lang.org/stable/core/ffi/struct.FromBytesWithNulError.html)
• [alloc::ffi::CString] (https://doc.rust-lang.org/stable/alloc/ffi/struct.CString.html)
• [alloc::ffi::FromVecWithNulError] (https://doc.rust-lang.org/stable/alloc/ffi/struct.FromVecWithNulError.html)
• [alloc::ffi::IntoStringError] (https://doc.rust-lang.org/stable/alloc/ffi/struct.IntoStringError.html)
• [alloc::ffi::NulError] (https://doc.rust-lang.org/stable/alloc/ffi/struct.NulError.html)

These types were previously stable in std::os::raw, but are now also available in core::ffi and std::ffi:

• [ffi::c_char] (https://doc.rust-lang.org/stable/std/ffi/type.c_char.html)
• [ffi::c_double] (https://doc.rust-lang.org/stable/std/ffi/type.c_double.html)
• [ffi::c_float] (https://doc.rust-lang.org/stable/std/ffi/type.c_float.html)
• [ffi::c_int] (https://doc.rust-lang.org/stable/std/ffi/type.c_int.html)
• [ffi::c_long] (https://doc.rust-lang.org/stable/std/ffi/type.c_long.html)
• [ffi::c_longlong] (https://doc.rust-lang.org/stable/std/ffi/type.c_longlong.html)
• [ffi::c_schar] (https://doc.rust-lang.org/stable/std/ffi/type.c_schar.html)
• [ffi::c_short] (https://doc.rust-lang.org/stable/std/ffi/type.c_short.html)
• [ffi::c_uchar] (https://doc.rust-lang.org/stable/std/ffi/type.c_uchar.html)
• [ffi::c_uint] (https://doc.rust-lang.org/stable/std/ffi/type.c_uint.html)
• [ffi::c_ulong] (https://doc.rust-lang.org/stable/std/ffi/type.c_ulong.html)
• [ffi::c_ulonglong] (https://doc.rust-lang.org/stable/std/ffi/type.c_ulonglong.html)
• [ffi::c_ushort] (https://doc.rust-lang.org/stable/std/ffi/type.c_ushort.html)

These APIs are now usable in const contexts:

• [slice::from_raw_parts] (https://doc.rust-lang.org/stable/core/slice/fn.from_raw_parts.html)

Cargo

• [Packages can now inherit settings from the workspace so that the settings can be centralized in one place.] (rust-lang/cargo#10859) See workspace.package and workspace.dependencies for more details on how to define these common settings.
• [Cargo commands can now accept multiple --target flags to build for multiple targets at once] (rust-lang/cargo#10766), and the build.target config option may now take an array of multiple targets.
• [The --jobs argument can now take a negative number to count backwards from the max CPUs.] (rust-lang/cargo#10844)
• [cargo add will now update Cargo.lock.] (rust-lang/cargo#10902)
• Added the --crate-type flag to cargo rustc to override the crate type.
• [Significantly improved the performance fetching git dependencies from GitHub when using a hash in the rev field.] (rust-lang/cargo#10079)

Misc

• [The rust-analyzer rustup component is now available on the stable channel.] (rust-lang/rust#98640)

Compatibility Notes

• The minimum required versions for all -linux-gnu targets are now at least kernel 3.2 and glibc 2.17, for targets that previously supported older versions: Increase the minimum linux-gnu versions
• [Network primitives are now implemented with the ideal Rust layout, not the C system layout] (rust-lang/rust#78802). This can cause problems when transmuting the types.
• [Add assertion that transmute_copy's U is not larger than T] (rust-lang/rust#98839)
• [A soundness bug in BTreeMap was fixed] (rust-lang/rust#99413) that allowed data it was borrowing to be dropped before the container.
• [The Drop behavior of C-like enums cast to ints has changed] (rust-lang/rust#96862). These are already discouraged by a compiler warning.
• [Relate late-bound closure lifetimes to parent fn in NLL] (rust-lang/rust#98835)
• [Errors at const-eval time are now in future incompatibility reports] (rust-lang/rust#97743)
• On the thumbv6m-none-eabi target, some incorrect asm! statements were erroneously accepted if they used the high registers (r8 to r14) as an input/output operand. [This is no longer accepted] (rust-lang/rust#99155).
• [impl Trait was accidentally accepted as the associated type value of return-position impl Trait] (rust-lang/rust#97346), without fulfilling all the trait bounds of that associated type, as long as the hidden type satisfies said bounds. This has been fixed.

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools.

• Windows builds now use profile-guided optimization, providing 10-20% improvements to compiler performance: [Utilize PGO for windows x64 rustc dist builds] (rust-lang/rust#96978)
• [Stop keeping metadata in memory before writing it to disk] (rust-lang/rust#96544)
• [compiletest: strip debuginfo by default for mode=ui] (rust-lang/rust#98140)
• Many improvements to generated code for derives, including performance improvements:
  • [Don't use match-destructuring for derived ops on structs.] (rust-lang/rust#98446)
  • [Many small deriving cleanups] (rust-lang/rust#98741)
  • [More derive output improvements] (rust-lang/rust#98758)
  • Clarify deriving code
  • [Final derive output improvements] (rust-lang/rust#99046)
  • Stop injecting #[allow(unused_qualifications)] in generated derive implementations
  • Improve derive(Debug)
• Bump to clap 3
• fully move dropck to mir
• [Optimize Vec::insert for the case where index == len.] (rust-lang/rust#98755)
• [Convert rust-analyzer to an in-tree tool] (rust-lang/rust#99603)

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request

Nov 16, 2022

Pkgsrc changes:

• This package now contains rust-analyzer, so implicitly conflicts with that pkgsrc package. The same goes for the rust-src package.
• Add NetBSD/arm6 port
• Add unfinished NetBSD/mipsel port
• Revert the use of the internal LLVM, should now build with the new pkgsrc LLVM (15).
• Add depndence on compat80 for sparc64 to fix the build
• Adapt patches
• Add CHECK_INTERPRETER_SKIP for a few (mostly unused) files. (A proper fix may come later.)

Upstream changes:

Version 1.64.0 (2022-09-22)

Language

• Unions with mutable references or tuples of allowed types are now allowed

• It is now considered valid to deallocate memory pointed to by a shared reference &T if every byte in T is inside an UnsafeCell

• Unused tuple struct fields are now warned against in an allow-by-default lint, [unused_tuple_struct_fields] (rust-lang/rust#95977), similar to the existing warning for unused struct fields. This lint will become warn-by-default in the future.

Compiler

• [Add Nintendo Switch as tier 3 target] (rust-lang/rust#88991)
  • Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support.
• [Only compile #[used] as llvm.compiler.used for ELF targets] (rust-lang/rust#93718)
• [Add the --diagnostic-width compiler flag to define the terminal width.] (rust-lang/rust#95635)
• [Add support for link-flavor rust-lld for iOS, tvOS and watchOS] (rust-lang/rust#98771)

Libraries

• [Remove restrictions on compare-exchange memory ordering.] (rust-lang/rust#98383)
• You can now write! or writeln! into an OsString: Implement fmt::Write for OsString
• [Make RwLockReadGuard covariant] (rust-lang/rust#96820)
• [Implement FusedIterator for std:🥅:[Into]Incoming] (rust-lang/rust#97300)
• [impl<T: AsRawFd> AsRawFd for {Arc,Box}<T>] (rust-lang/rust#97437)
• [ptr::copy and ptr::swap are doing untyped copies] (rust-lang/rust#97712)
• [Add cgroupv1 support to available_parallelism] (rust-lang/rust#97925)
• [Mitigate many incorrect uses of mem::uninitialized] (rust-lang/rust#99182)

Stabilized APIs

• [future::IntoFuture] (https://doc.rust-lang.org/stable/std/future/trait.IntoFuture.html)
• [future::poll_fn] (https://doc.rust-lang.org/stable/std/future/fn.poll_fn.html)
• [task::ready!] (https://doc.rust-lang.org/stable/std/task/macro.ready.html)
• [num::NonZero*::checked_mul] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_mul)
• [num::NonZero*::checked_pow] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_pow)
• [num::NonZero*::saturating_mul] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.saturating_mul)
• [num::NonZero*::saturating_pow] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.saturating_pow)
• [num::NonZeroI*::abs] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.abs)
• [num::NonZeroI*::checked_abs] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.checked_abs)
• [num::NonZeroI*::overflowing_abs] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.overflowing_abs)
• [num::NonZeroI*::saturating_abs] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.saturating_abs)
• [num::NonZeroI*::unsigned_abs] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.unsigned_abs)
• [num::NonZeroI*::wrapping_abs] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroIsize.html#method.wrapping_abs)
• [num::NonZeroU*::checked_add] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_add)
• [num::NonZeroU*::checked_next_power_of_two] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.checked_next_power_of_two)
• [num::NonZeroU*::saturating_add] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroUsize.html#method.saturating_add)
• [os::unix::process::CommandExt::process_group] (https://doc.rust-lang.org/stable/std/os/unix/process/trait.CommandExt.html#tymethod.process_group)
• [os::windows::fs::FileTypeExt::is_symlink_dir] (https://doc.rust-lang.org/stable/std/os/windows/fs/trait.FileTypeExt.html#tymethod.is_symlink_dir)
• [os::windows::fs::FileTypeExt::is_symlink_file] (https://doc.rust-lang.org/stable/std/os/windows/fs/trait.FileTypeExt.html#tymethod.is_symlink_file)

These types were previously stable in std::ffi, but are now also available in core and alloc:

• [core::ffi::CStr] (https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html)
• [core::ffi::FromBytesWithNulError] (https://doc.rust-lang.org/stable/core/ffi/struct.FromBytesWithNulError.html)
• [alloc::ffi::CString] (https://doc.rust-lang.org/stable/alloc/ffi/struct.CString.html)
• [alloc::ffi::FromVecWithNulError] (https://doc.rust-lang.org/stable/alloc/ffi/struct.FromVecWithNulError.html)
• [alloc::ffi::IntoStringError] (https://doc.rust-lang.org/stable/alloc/ffi/struct.IntoStringError.html)
• [alloc::ffi::NulError] (https://doc.rust-lang.org/stable/alloc/ffi/struct.NulError.html)

These types were previously stable in std::os::raw, but are now also available in core::ffi and std::ffi:

• [ffi::c_char] (https://doc.rust-lang.org/stable/std/ffi/type.c_char.html)
• [ffi::c_double] (https://doc.rust-lang.org/stable/std/ffi/type.c_double.html)
• [ffi::c_float] (https://doc.rust-lang.org/stable/std/ffi/type.c_float.html)
• [ffi::c_int] (https://doc.rust-lang.org/stable/std/ffi/type.c_int.html)
• [ffi::c_long] (https://doc.rust-lang.org/stable/std/ffi/type.c_long.html)
• [ffi::c_longlong] (https://doc.rust-lang.org/stable/std/ffi/type.c_longlong.html)
• [ffi::c_schar] (https://doc.rust-lang.org/stable/std/ffi/type.c_schar.html)
• [ffi::c_short] (https://doc.rust-lang.org/stable/std/ffi/type.c_short.html)
• [ffi::c_uchar] (https://doc.rust-lang.org/stable/std/ffi/type.c_uchar.html)
• [ffi::c_uint] (https://doc.rust-lang.org/stable/std/ffi/type.c_uint.html)
• [ffi::c_ulong] (https://doc.rust-lang.org/stable/std/ffi/type.c_ulong.html)
• [ffi::c_ulonglong] (https://doc.rust-lang.org/stable/std/ffi/type.c_ulonglong.html)
• [ffi::c_ushort] (https://doc.rust-lang.org/stable/std/ffi/type.c_ushort.html)

These APIs are now usable in const contexts:

• [slice::from_raw_parts] (https://doc.rust-lang.org/stable/core/slice/fn.from_raw_parts.html)

Cargo

• [Packages can now inherit settings from the workspace so that the settings can be centralized in one place.] (rust-lang/cargo#10859) See workspace.package and workspace.dependencies for more details on how to define these common settings.
• [Cargo commands can now accept multiple --target flags to build for multiple targets at once] (rust-lang/cargo#10766), and the build.target config option may now take an array of multiple targets.
• [The --jobs argument can now take a negative number to count backwards from the max CPUs.] (rust-lang/cargo#10844)
• [cargo add will now update Cargo.lock.] (rust-lang/cargo#10902)
• Added the --crate-type flag to cargo rustc to override the crate type.
• [Significantly improved the performance fetching git dependencies from GitHub when using a hash in the rev field.] (rust-lang/cargo#10079)

Misc

• [The rust-analyzer rustup component is now available on the stable channel.] (rust-lang/rust#98640)

Compatibility Notes

• The minimum required versions for all -linux-gnu targets are now at least kernel 3.2 and glibc 2.17, for targets that previously supported older versions: Increase the minimum linux-gnu versions
• [Network primitives are now implemented with the ideal Rust layout, not the C system layout] (rust-lang/rust#78802). This can cause problems when transmuting the types.
• [Add assertion that transmute_copy's U is not larger than T] (rust-lang/rust#98839)
• [A soundness bug in BTreeMap was fixed] (rust-lang/rust#99413) that allowed data it was borrowing to be dropped before the container.
• [The Drop behavior of C-like enums cast to ints has changed] (rust-lang/rust#96862). These are already discouraged by a compiler warning.
• [Relate late-bound closure lifetimes to parent fn in NLL] (rust-lang/rust#98835)
• [Errors at const-eval time are now in future incompatibility reports] (rust-lang/rust#97743)
• On the thumbv6m-none-eabi target, some incorrect asm! statements were erroneously accepted if they used the high registers (r8 to r14) as an input/output operand. [This is no longer accepted] (rust-lang/rust#99155).
• [impl Trait was accidentally accepted as the associated type value of return-position impl Trait] (rust-lang/rust#97346), without fulfilling all the trait bounds of that associated type, as long as the hidden type satisfies said bounds. This has been fixed.

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools.

• Windows builds now use profile-guided optimization, providing 10-20% improvements to compiler performance: [Utilize PGO for windows x64 rustc dist builds] (rust-lang/rust#96978)
• [Stop keeping metadata in memory before writing it to disk] (rust-lang/rust#96544)
• [compiletest: strip debuginfo by default for mode=ui] (rust-lang/rust#98140)
• Many improvements to generated code for derives, including performance improvements:
  • [Don't use match-destructuring for derived ops on structs.] (rust-lang/rust#98446)
  • [Many small deriving cleanups] (rust-lang/rust#98741)
  • [More derive output improvements] (rust-lang/rust#98758)
  • Clarify deriving code
  • [Final derive output improvements] (rust-lang/rust#99046)
  • Stop injecting #[allow(unused_qualifications)] in generated derive implementations
  • Improve derive(Debug)
• Bump to clap 3
• fully move dropck to mir
• [Optimize Vec::insert for the case where index == len.] (rust-lang/rust#98755)
• [Convert rust-analyzer to an in-tree tool] (rust-lang/rust#99603)

Labels

merged-by-bors

This PR was explicitly merged by bors.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.