fs: fix the error report on fs.link(Sync) by yorkie · Pull Request #3917 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

As the Node.js documentation specified:

fs.link(srcpath, dstpath, callback)

But when we run:

We will get the below:

TypeError: dest path must be a string at TypeError (native) at Object.fs.link (fs.js:915:11) at repl:1:4

Just correct the message of relevant 2 errors in this PR :-)

mscdex added the fs

Issues and PRs related to the fs subsystem / file system.

label

Nov 19, 2015

good catch! it may seem minor but a quick test case may be worthwhile. otherwise LGTM

Test cases has been added, @cjihrig could you please run CI again, sorry :-(

The @nodejs/ctc decided on this weeks call to handle error message changes as semver-major for the time being... I think this qualifies even tho the error messages were just reversed. Tagging this as major just in case but would like some additional input.

jasnell added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Nov 21, 2015

jasnell pushed a commit that referenced this pull request

Nov 21, 2015

As the Node.js documentation specified:

fs.link(srcpath, dstpath, callback)

But when we run:

> fs.link()

We will get the below:

TypeError: dest path must be a string
    at TypeError (native)
    at Object.fs.link (fs.js:915:11)
    at repl:1:4

Just correct the message of relevant 2 errors in this PR :-)

PR-URL: #3917 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

Landed as 090f9dc ... @yorkie, I went ahead and used your description of the issue from the PR text as the commit log message. In future commits, please make sure to add at least some description in the commit log message :-) Thanks again for the commits!!

jasnell added a commit that referenced this pull request

Apr 26, 2016

The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.

• Buffer
  • New Buffer constructors have been added #4682
  • Previously deprecated Buffer APIs are removed #5048, #4594
  • Improved error handling #4514
• Cluster
  • Worker emitted as first argument in 'message' event #5361.
• Crypto
  • Improved error handling #3100, #5611
  • Simplified Certificate class bindings #5382
  • Improved control over FIPS mode #5181
  • pbkdf2 digest overloading is deprecated #4047
• Dependencies
  • Reintroduce shared c-ares build support #5775.
  • V8 updated to 5.0.71.31 #6111.
• DNS
  • Add resolvePtr API to query plain DNS PTR records #4921.
• Domains
  • Clear stack when no error handler #4659.
• File System
  • The fs.realpath() and fs.realpathSync() methods have been updated to use a more efficient libuv implementation. This change includes the removal of the cache argument and the method can throw new errors #3594
  • FS apis can now accept and return paths as Buffers #5616.
  • Error handling and type checking improvements #5616, #5590, #4518, #3917.
  • fs.read's string interface is deprecated #4525
• HTTP
  • 'clientError' can now be used to return custom errors from an HTTP server #4557.
• Modules
  • Current directory is now prioritized for local lookups #5689
  • Symbolic links are preserved when requiring modules #5950
• Net
  • DNS hints no longer implicitly set #6021.
  • Improved error handling and type checking #5981, #5733, #2904
• Path
  • Improved type checking #5348.
• Process
  • Introduce process warnings API #4782.
  • Throw exception when non-function passed to nextTick #3860.
• Readline
  • Emit key info unconditionally #6024
• REPL
  • Assignment to _ will emit a warning. #5535
• Timers
  • Fail early when callback is not a function #4362
• TLS
  • Rename 'clientError' to 'tlsClientError' #4557
  • SHA1 used for sessionIdContext #3866
• TTY
  • Previously deprecated setRawMode wrapper is removed #2528.
• Util
  • Changes to Error object formatting #4582.
• Windows
  • Windows XP and Vista are no longer supported #5167, #5167.

jasnell added a commit that referenced this pull request

Apr 26, 2016

The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.

• Buffer
  • New Buffer constructors have been added #4682
  • Previously deprecated Buffer APIs are removed #5048, #4594
  • Improved error handling #4514
• Cluster
  • Worker emitted as first argument in 'message' event #5361.
• Crypto
  • Improved error handling #3100, #5611
  • Simplified Certificate class bindings #5382
  • Improved control over FIPS mode #5181
  • pbkdf2 digest overloading is deprecated #4047
• Dependencies
  • Reintroduce shared c-ares build support #5775.
  • V8 updated to 5.0.71.31 #6111.
• DNS
  • Add resolvePtr API to query plain DNS PTR records #4921.
• Domains
  • Clear stack when no error handler #4659.
• File System
  • The fs.realpath() and fs.realpathSync() methods have been updated to use a more efficient libuv implementation. This change includes the removal of the cache argument and the method can throw new errors #3594
  • FS apis can now accept and return paths as Buffers #5616.
  • Error handling and type checking improvements #5616, #5590, #4518, #3917.
  • fs.read's string interface is deprecated #4525
• HTTP
  • 'clientError' can now be used to return custom errors from an HTTP server #4557.
• Modules
  • Current directory is now prioritized for local lookups #5689
  • Symbolic links are preserved when requiring modules #5950
• Net
  • DNS hints no longer implicitly set #6021.
  • Improved error handling and type checking #5981, #5733, #2904
• Path
  • Improved type checking #5348.
• Process
  • Introduce process warnings API #4782.
  • Throw exception when non-function passed to nextTick #3860.
• Readline
  • Emit key info unconditionally #6024
• REPL
  • Assignment to _ will emit a warning. #5535
• Timers
  • Fail early when callback is not a function #4362
• TLS
  • Rename 'clientError' to 'tlsClientError' #4557
  • SHA1 used for sessionIdContext #3866
• TTY
  • Previously deprecated setRawMode wrapper is removed #2528.
• Util
  • Changes to Error object formatting #4582.
• Windows
  • Windows XP and Vista are no longer supported #5167, #5167.

jasnell added a commit that referenced this pull request

Apr 26, 2016

The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.

• Buffer
  • New Buffer constructors have been added #4682
  • Previously deprecated Buffer APIs are removed #5048, #4594
  • Improved error handling #4514
• Cluster
  • Worker emitted as first argument in 'message' event #5361.
• Crypto
  • Improved error handling #3100, #5611
  • Simplified Certificate class bindings #5382
  • Improved control over FIPS mode #5181
  • pbkdf2 digest overloading is deprecated #4047
• Dependencies
  • Reintroduce shared c-ares build support #5775.
  • V8 updated to 5.0.71.31 #6111.
• DNS
  • Add resolvePtr API to query plain DNS PTR records #4921.
• Domains
  • Clear stack when no error handler #4659.
• File System
  • The fs.realpath() and fs.realpathSync() methods have been updated to use a more efficient libuv implementation. This change includes the removal of the cache argument and the method can throw new errors #3594
  • FS apis can now accept and return paths as Buffers #5616.
  • Error handling and type checking improvements #5616, #5590, #4518, #3917.
  • fs.read's string interface is deprecated #4525
• HTTP
  • 'clientError' can now be used to return custom errors from an HTTP server #4557.
• Modules
  • Current directory is now prioritized for local lookups #5689
  • Symbolic links are preserved when requiring modules #5950
• Net
  • DNS hints no longer implicitly set #6021.
  • Improved error handling and type checking #5981, #5733, #2904
• OS X
  • MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 #6402.
• Path
  • Improved type checking #5348.
• Process
  • Introduce process warnings API #4782.
  • Throw exception when non-function passed to nextTick #3860.
• Readline
  • Emit key info unconditionally #6024
• REPL
  • Assignment to _ will emit a warning. #5535
• Timers
  • Fail early when callback is not a function #4362
• TLS
  • Rename 'clientError' to 'tlsClientError' #4557
  • SHA1 used for sessionIdContext #3866
• TTY
  • Previously deprecated setRawMode wrapper is removed #2528.
• Util
  • Changes to Error object formatting #4582.
• Windows
  • Windows XP and Vista are no longer supported #5167, #5167.

jasnell added a commit that referenced this pull request

Apr 26, 2016

The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.

• Buffer
  • New Buffer constructors have been added #4682
  • Previously deprecated Buffer APIs are removed #5048, #4594
  • Improved error handling #4514
• Cluster
  • Worker emitted as first argument in 'message' event #5361.
• Crypto
  • Improved error handling #3100, #5611
  • Simplified Certificate class bindings #5382
  • Improved control over FIPS mode #5181
  • pbkdf2 digest overloading is deprecated #4047
• Dependencies
  • Reintroduce shared c-ares build support #5775.
  • V8 updated to 5.0.71.31 #6111.
• DNS
  • Add resolvePtr API to query plain DNS PTR records #4921.
• Domains
  • Clear stack when no error handler #4659.
• File System
  • The fs.realpath() and fs.realpathSync() methods have been updated to use a more efficient libuv implementation. This change includes the removal of the cache argument and the method can throw new errors #3594
  • FS apis can now accept and return paths as Buffers #5616.
  • Error handling and type checking improvements #5616, #5590, #4518, #3917.
  • fs.read's string interface is deprecated #4525
• HTTP
  • 'clientError' can now be used to return custom errors from an HTTP server #4557.
• Modules
  • Current directory is now prioritized for local lookups #5689
  • Symbolic links are preserved when requiring modules #5950
• Net
  • DNS hints no longer implicitly set #6021.
  • Improved error handling and type checking #5981, #5733, #2904
• OS X
  • MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 #6402.
• Path
  • Improved type checking #5348.
• Process
  • Introduce process warnings API #4782.
  • Throw exception when non-function passed to nextTick #3860.
• Readline
  • Emit key info unconditionally #6024
• REPL
  • Assignment to _ will emit a warning. #5535
• Timers
  • Fail early when callback is not a function #4362
• TLS
  • Rename 'clientError' to 'tlsClientError' #4557
  • SHA1 used for sessionIdContext #3866
• TTY
  • Previously deprecated setRawMode wrapper is removed #2528.
• Util
  • Changes to Error object formatting #4582.
• Windows
  • Windows XP and Vista are no longer supported #5167, #5167.

jasnell added a commit that referenced this pull request

Apr 26, 2016

The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.

• Buffer
  • New Buffer constructors have been added #4682
  • Previously deprecated Buffer APIs are removed #5048, #4594
  • Improved error handling #4514
• Cluster
  • Worker emitted as first argument in 'message' event #5361.
• Crypto
  • Improved error handling #3100, #5611
  • Simplified Certificate class bindings #5382
  • Improved control over FIPS mode #5181
  • pbkdf2 digest overloading is deprecated #4047
• Dependencies
  • Reintroduce shared c-ares build support #5775.
  • V8 updated to 5.0.71.31 #6111.
• DNS
  • Add resolvePtr API to query plain DNS PTR records #4921.
• Domains
  • Clear stack when no error handler #4659.
• File System
  • The fs.realpath() and fs.realpathSync() methods have been updated to use a more efficient libuv implementation. This change includes the removal of the cache argument and the method can throw new errors #3594
  • FS apis can now accept and return paths as Buffers #5616.
  • Error handling and type checking improvements #5616, #5590, #4518, #3917.
  • fs.read's string interface is deprecated #4525
• HTTP
  • 'clientError' can now be used to return custom errors from an HTTP server #4557.
• Modules
  • Current directory is now prioritized for local lookups #5689
  • Symbolic links are preserved when requiring modules #5950
• Net
  • DNS hints no longer implicitly set #6021.
  • Improved error handling and type checking #5981, #5733, #2904
• OS X
  • MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 #6402.
• Path
  • Improved type checking #5348.
• Process
  • Introduce process warnings API #4782.
  • Throw exception when non-function passed to nextTick #3860.
• Readline
  • Emit key info unconditionally #6024
• REPL
  • Assignment to _ will emit a warning. #5535
• Timers
  • Fail early when callback is not a function #4362
• TLS
  • Rename 'clientError' to 'tlsClientError' #4557
  • SHA1 used for sessionIdContext #3866
• TTY
  • Previously deprecated setRawMode wrapper is removed #2528.
• Util
  • Changes to Error object formatting #4582.
• Windows
  • Windows XP and Vista are no longer supported #5167, #5167.

Labels

fs

Issues and PRs related to the fs subsystem / file system.

semver-major

PRs that contain breaking changes and should be released in the next major version.