net: remove implicit setting of DNS hints by cjihrig · Pull Request #6021 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This commit removes the implicit setting of the V4MAPPED and ADDRCONFIG DNS flags in createConnection(). As of 39de601, users that need these flags can set them explicitly.

cjihrig added net

Issues and PRs related to the net subsystem.

semver-major

PRs that contain breaking changes and should be released in the next major version.

labels

Apr 2, 2016

Got a green CI. CITGM failure seems unrelated.

LGTM. Do we want to get this into v6 or wait (I'm cutting the first v6 release candidate a week from monday)

LGTM. I think including it in the first RC of 6.0.0 is okay. I feel like a lot of people are itching to try out 6.x and hopefully that will make sure this isn't really breaking anyone's current setup too bad

LGTM. Targeting v6 seems reasonable to me; this change hopefully fixes more than it breaks.

Thanks for the reviews. Landed in b85a50b.

cjihrig added a commit that referenced this pull request

Apr 5, 2016

This commit removes the implicit setting of the V4MAPPED and ADDRCONFIG DNS flags in createConnection(). As of 39de601, users that need these flags can set them explicitly.

PR-URL: #6021 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Evan Lucas evanlucas@me.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

jasnell added a commit that referenced this pull request

Apr 26, 2016

The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.

• Buffer
  • New Buffer constructors have been added #4682
  • Previously deprecated Buffer APIs are removed #5048, #4594
  • Improved error handling #4514
• Cluster
  • Worker emitted as first argument in 'message' event #5361.
• Crypto
  • Improved error handling #3100, #5611
  • Simplified Certificate class bindings #5382
  • Improved control over FIPS mode #5181
  • pbkdf2 digest overloading is deprecated #4047
• Dependencies
  • Reintroduce shared c-ares build support #5775.
  • V8 updated to 5.0.71.31 #6111.
• DNS
  • Add resolvePtr API to query plain DNS PTR records #4921.
• Domains
  • Clear stack when no error handler #4659.
• File System
  • The fs.realpath() and fs.realpathSync() methods have been updated to use a more efficient libuv implementation. This change includes the removal of the cache argument and the method can throw new errors #3594
  • FS apis can now accept and return paths as Buffers #5616.
  • Error handling and type checking improvements #5616, #5590, #4518, #3917.
  • fs.read's string interface is deprecated #4525
• HTTP
  • 'clientError' can now be used to return custom errors from an HTTP server #4557.
• Modules
  • Current directory is now prioritized for local lookups #5689
  • Symbolic links are preserved when requiring modules #5950
• Net
  • DNS hints no longer implicitly set #6021.
  • Improved error handling and type checking #5981, #5733, #2904
• Path
  • Improved type checking #5348.
• Process
  • Introduce process warnings API #4782.
  • Throw exception when non-function passed to nextTick #3860.
• Readline
  • Emit key info unconditionally #6024
• REPL
  • Assignment to _ will emit a warning. #5535
• Timers
  • Fail early when callback is not a function #4362
• TLS
  • Rename 'clientError' to 'tlsClientError' #4557
  • SHA1 used for sessionIdContext #3866
• TTY
  • Previously deprecated setRawMode wrapper is removed #2528.
• Util
  • Changes to Error object formatting #4582.
• Windows
  • Windows XP and Vista are no longer supported #5167, #5167.

jasnell added a commit that referenced this pull request

Apr 26, 2016

The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.

• Buffer
  • New Buffer constructors have been added #4682
  • Previously deprecated Buffer APIs are removed #5048, #4594
  • Improved error handling #4514
• Cluster
  • Worker emitted as first argument in 'message' event #5361.
• Crypto
  • Improved error handling #3100, #5611
  • Simplified Certificate class bindings #5382
  • Improved control over FIPS mode #5181
  • pbkdf2 digest overloading is deprecated #4047
• Dependencies
  • Reintroduce shared c-ares build support #5775.
  • V8 updated to 5.0.71.31 #6111.
• DNS
  • Add resolvePtr API to query plain DNS PTR records #4921.
• Domains
  • Clear stack when no error handler #4659.
• File System
  • The fs.realpath() and fs.realpathSync() methods have been updated to use a more efficient libuv implementation. This change includes the removal of the cache argument and the method can throw new errors #3594
  • FS apis can now accept and return paths as Buffers #5616.
  • Error handling and type checking improvements #5616, #5590, #4518, #3917.
  • fs.read's string interface is deprecated #4525
• HTTP
  • 'clientError' can now be used to return custom errors from an HTTP server #4557.
• Modules
  • Current directory is now prioritized for local lookups #5689
  • Symbolic links are preserved when requiring modules #5950
• Net
  • DNS hints no longer implicitly set #6021.
  • Improved error handling and type checking #5981, #5733, #2904
• Path
  • Improved type checking #5348.
• Process
  • Introduce process warnings API #4782.
  • Throw exception when non-function passed to nextTick #3860.
• Readline
  • Emit key info unconditionally #6024
• REPL
  • Assignment to _ will emit a warning. #5535
• Timers
  • Fail early when callback is not a function #4362
• TLS
  • Rename 'clientError' to 'tlsClientError' #4557
  • SHA1 used for sessionIdContext #3866
• TTY
  • Previously deprecated setRawMode wrapper is removed #2528.
• Util
  • Changes to Error object formatting #4582.
• Windows
  • Windows XP and Vista are no longer supported #5167, #5167.

jasnell added a commit that referenced this pull request

Apr 26, 2016

The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.

• Buffer
  • New Buffer constructors have been added #4682
  • Previously deprecated Buffer APIs are removed #5048, #4594
  • Improved error handling #4514
• Cluster
  • Worker emitted as first argument in 'message' event #5361.
• Crypto
  • Improved error handling #3100, #5611
  • Simplified Certificate class bindings #5382
  • Improved control over FIPS mode #5181
  • pbkdf2 digest overloading is deprecated #4047
• Dependencies
  • Reintroduce shared c-ares build support #5775.
  • V8 updated to 5.0.71.31 #6111.
• DNS
  • Add resolvePtr API to query plain DNS PTR records #4921.
• Domains
  • Clear stack when no error handler #4659.
• File System
  • The fs.realpath() and fs.realpathSync() methods have been updated to use a more efficient libuv implementation. This change includes the removal of the cache argument and the method can throw new errors #3594
  • FS apis can now accept and return paths as Buffers #5616.
  • Error handling and type checking improvements #5616, #5590, #4518, #3917.
  • fs.read's string interface is deprecated #4525
• HTTP
  • 'clientError' can now be used to return custom errors from an HTTP server #4557.
• Modules
  • Current directory is now prioritized for local lookups #5689
  • Symbolic links are preserved when requiring modules #5950
• Net
  • DNS hints no longer implicitly set #6021.
  • Improved error handling and type checking #5981, #5733, #2904
• OS X
  • MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 #6402.
• Path
  • Improved type checking #5348.
• Process
  • Introduce process warnings API #4782.
  • Throw exception when non-function passed to nextTick #3860.
• Readline
  • Emit key info unconditionally #6024
• REPL
  • Assignment to _ will emit a warning. #5535
• Timers
  • Fail early when callback is not a function #4362
• TLS
  • Rename 'clientError' to 'tlsClientError' #4557
  • SHA1 used for sessionIdContext #3866
• TTY
  • Previously deprecated setRawMode wrapper is removed #2528.
• Util
  • Changes to Error object formatting #4582.
• Windows
  • Windows XP and Vista are no longer supported #5167, #5167.

jasnell added a commit that referenced this pull request

Apr 26, 2016

The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.

• Buffer
  • New Buffer constructors have been added #4682
  • Previously deprecated Buffer APIs are removed #5048, #4594
  • Improved error handling #4514
• Cluster
  • Worker emitted as first argument in 'message' event #5361.
• Crypto
  • Improved error handling #3100, #5611
  • Simplified Certificate class bindings #5382
  • Improved control over FIPS mode #5181
  • pbkdf2 digest overloading is deprecated #4047
• Dependencies
  • Reintroduce shared c-ares build support #5775.
  • V8 updated to 5.0.71.31 #6111.
• DNS
  • Add resolvePtr API to query plain DNS PTR records #4921.
• Domains
  • Clear stack when no error handler #4659.
• File System
  • The fs.realpath() and fs.realpathSync() methods have been updated to use a more efficient libuv implementation. This change includes the removal of the cache argument and the method can throw new errors #3594
  • FS apis can now accept and return paths as Buffers #5616.
  • Error handling and type checking improvements #5616, #5590, #4518, #3917.
  • fs.read's string interface is deprecated #4525
• HTTP
  • 'clientError' can now be used to return custom errors from an HTTP server #4557.
• Modules
  • Current directory is now prioritized for local lookups #5689
  • Symbolic links are preserved when requiring modules #5950
• Net
  • DNS hints no longer implicitly set #6021.
  • Improved error handling and type checking #5981, #5733, #2904
• OS X
  • MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 #6402.
• Path
  • Improved type checking #5348.
• Process
  • Introduce process warnings API #4782.
  • Throw exception when non-function passed to nextTick #3860.
• Readline
  • Emit key info unconditionally #6024
• REPL
  • Assignment to _ will emit a warning. #5535
• Timers
  • Fail early when callback is not a function #4362
• TLS
  • Rename 'clientError' to 'tlsClientError' #4557
  • SHA1 used for sessionIdContext #3866
• TTY
  • Previously deprecated setRawMode wrapper is removed #2528.
• Util
  • Changes to Error object formatting #4582.
• Windows
  • Windows XP and Vista are no longer supported #5167, #5167.

jasnell added a commit that referenced this pull request

Apr 26, 2016

The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.

• Buffer
  • New Buffer constructors have been added #4682
  • Previously deprecated Buffer APIs are removed #5048, #4594
  • Improved error handling #4514
• Cluster
  • Worker emitted as first argument in 'message' event #5361.
• Crypto
  • Improved error handling #3100, #5611
  • Simplified Certificate class bindings #5382
  • Improved control over FIPS mode #5181
  • pbkdf2 digest overloading is deprecated #4047
• Dependencies
  • Reintroduce shared c-ares build support #5775.
  • V8 updated to 5.0.71.31 #6111.
• DNS
  • Add resolvePtr API to query plain DNS PTR records #4921.
• Domains
  • Clear stack when no error handler #4659.
• File System
  • The fs.realpath() and fs.realpathSync() methods have been updated to use a more efficient libuv implementation. This change includes the removal of the cache argument and the method can throw new errors #3594
  • FS apis can now accept and return paths as Buffers #5616.
  • Error handling and type checking improvements #5616, #5590, #4518, #3917.
  • fs.read's string interface is deprecated #4525
• HTTP
  • 'clientError' can now be used to return custom errors from an HTTP server #4557.
• Modules
  • Current directory is now prioritized for local lookups #5689
  • Symbolic links are preserved when requiring modules #5950
• Net
  • DNS hints no longer implicitly set #6021.
  • Improved error handling and type checking #5981, #5733, #2904
• OS X
  • MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 #6402.
• Path
  • Improved type checking #5348.
• Process
  • Introduce process warnings API #4782.
  • Throw exception when non-function passed to nextTick #3860.
• Readline
  • Emit key info unconditionally #6024
• REPL
  • Assignment to _ will emit a warning. #5535
• Timers
  • Fail early when callback is not a function #4362
• TLS
  • Rename 'clientError' to 'tlsClientError' #4557
  • SHA1 used for sessionIdContext #3866
• TTY
  • Previously deprecated setRawMode wrapper is removed #2528.
• Util
  • Changes to Error object formatting #4582.
• Windows
  • Windows XP and Vista are no longer supported #5167, #5167.

Labels

net

Issues and PRs related to the net subsystem.

semver-major

PRs that contain breaking changes and should be released in the next major version.