build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7 by ChALkeR · Pull Request #6402 · nodejs/node (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation14 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Ref: #5731.
We currently target 10.5.
Libuv is going to drop 10.6 in v2: libuv/libuv#758.
Note that OS X versions 10.5-10.8 are not supported by Apple anymore and do not receive security patches.
Note that we don't state supported OS X versions anywhere, and the only version tested at CI is 10.10. Ref: nodejs/build#367.
/cc @bnoordhuis, @ofrobots, @jbergstroem, @nodejs/ctc
Awesome-looking patch. LGTM!
Ref: nodejs/build#367
libuv is going to drop 10.6 in v2. Ref: libuv/libuv#758
OS X versions below 10.9 are not supported by Apple anymore and do not receive security patches.
PR-URL: nodejs#6402 Reviewed-By: Ali Ijaz Sheikh ofrobots@google.com Reviewed-By: Evan Lucas evanlucas@me.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Colin Ihrig cjihrig@gmail.com
Sigh... lol... yes, can get this one in
1 similar comment
Landing in master and will pull it back
PRs that contain breaking changes and should be released in the next major version.
Issues and PRs related to build files or the CI.
Issues and PRs related to the macOS platform / OSX.
labels
jasnell pushed a commit that referenced this pull request
Refs: nodejs/build#367
libuv is going to drop 10.6 in v2. Ref: libuv/libuv#758
OS X versions below 10.9 are not supported by Apple anymore and do not receive security patches.
PR-URL: #6402 Reviewed-By: Ali Ijaz Sheikh ofrobots@google.com Reviewed-By: Evan Lucas evanlucas@me.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Fedor Indutny fedor.indutny@gmail.com Reviewed-By: Myles Borins myles.borins@gmail.com
@jasnell Argh, I made a mistake in the commit message. The first ref should have been #5731. It's not critical, though, you can ignore that.
Sorry for that.
jasnell pushed a commit that referenced this pull request
Refs: nodejs/build#367
libuv is going to drop 10.6 in v2. Ref: libuv/libuv#758
OS X versions below 10.9 are not supported by Apple anymore and do not receive security patches.
PR-URL: #6402 Reviewed-By: Ali Ijaz Sheikh ofrobots@google.com Reviewed-By: Evan Lucas evanlucas@me.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Fedor Indutny fedor.indutny@gmail.com Reviewed-By: Myles Borins myles.borins@gmail.com
jasnell added a commit that referenced this pull request
The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.
- Buffer
- Cluster
- Worker emitted as first argument in 'message' event #5361.
- Crypto
- Dependencies
- DNS
- Add resolvePtr API to query plain DNS PTR records #4921.
- Domains
- Clear stack when no error handler #4659.
- File System
- The
fs.realpath()andfs.realpathSync()methods have been updated to use a more efficient libuv implementation. This change includes the removal of thecacheargument and the method can throw new errors #3594 - FS apis can now accept and return paths as Buffers #5616.
- Error handling and type checking improvements #5616, #5590, #4518, #3917.
- fs.read's string interface is deprecated #4525
- The
- HTTP
- 'clientError' can now be used to return custom errors from an HTTP server #4557.
- Modules
- Net
- OS X
- MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 #6402.
- Path
- Improved type checking #5348.
- Process
- Readline
- Emit key info unconditionally #6024
- REPL
- Assignment to
_will emit a warning. #5535
- Assignment to
- Timers
- Fail early when callback is not a function #4362
- TLS
- TTY
- Previously deprecated setRawMode wrapper is removed #2528.
- Util
- Changes to Error object formatting #4582.
- Windows
jasnell added a commit that referenced this pull request
The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.
- Buffer
- Cluster
- Worker emitted as first argument in 'message' event #5361.
- Crypto
- Dependencies
- DNS
- Add resolvePtr API to query plain DNS PTR records #4921.
- Domains
- Clear stack when no error handler #4659.
- File System
- The
fs.realpath()andfs.realpathSync()methods have been updated to use a more efficient libuv implementation. This change includes the removal of thecacheargument and the method can throw new errors #3594 - FS apis can now accept and return paths as Buffers #5616.
- Error handling and type checking improvements #5616, #5590, #4518, #3917.
- fs.read's string interface is deprecated #4525
- The
- HTTP
- 'clientError' can now be used to return custom errors from an HTTP server #4557.
- Modules
- Net
- OS X
- MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 #6402.
- Path
- Improved type checking #5348.
- Process
- Readline
- Emit key info unconditionally #6024
- REPL
- Assignment to
_will emit a warning. #5535
- Assignment to
- Timers
- Fail early when callback is not a function #4362
- TLS
- TTY
- Previously deprecated setRawMode wrapper is removed #2528.
- Util
- Changes to Error object formatting #4582.
- Windows
jasnell added a commit that referenced this pull request
The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.
- Buffer
- Cluster
- Worker emitted as first argument in 'message' event #5361.
- Crypto
- Dependencies
- DNS
- Add resolvePtr API to query plain DNS PTR records #4921.
- Domains
- Clear stack when no error handler #4659.
- File System
- The
fs.realpath()andfs.realpathSync()methods have been updated to use a more efficient libuv implementation. This change includes the removal of thecacheargument and the method can throw new errors #3594 - FS apis can now accept and return paths as Buffers #5616.
- Error handling and type checking improvements #5616, #5590, #4518, #3917.
- fs.read's string interface is deprecated #4525
- The
- HTTP
- 'clientError' can now be used to return custom errors from an HTTP server #4557.
- Modules
- Net
- OS X
- MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 #6402.
- Path
- Improved type checking #5348.
- Process
- Readline
- Emit key info unconditionally #6024
- REPL
- Assignment to
_will emit a warning. #5535
- Assignment to
- Timers
- Fail early when callback is not a function #4362
- TLS
- TTY
- Previously deprecated setRawMode wrapper is removed #2528.
- Util
- Changes to Error object formatting #4582.
- Windows
Looks like this was landed without a CI run. :-(
@Trott The CI run was made for the whole 6.0.0 release, and this was the last commit before the release.
@ChALkeR ... the CI run for v6 didn't include this because it came in just after I kicked that off. I ran the tests locally but I already had the work around in place that @bnoordhuis identified (which explains why I haven't been able to recreate this locally... I just switched that back off and low and behold, getting the error).
Labels
Issues and PRs related to build files or the CI.
Issues and PRs related to the macOS platform / OSX.
PRs that contain breaking changes and should be released in the next major version.