Upgrade to V8 5.0.71.32 in master by ofrobots · Pull Request #6111 · nodejs/node (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation18 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Checklist
- tests and code linting passes
- the commit message follows commit guidelines
Affected core subsystem(s)
deps
Description of change
This PR is a rebase of vee-eight-5.0 (+ latest V8 5.0 lkgr) to master.
Normally we wait for V8 version to launch in Chrome stable before landing it onto master. Given that we are planning to start releasing RCs for Node v6 next week, it would be convenient to land V8 5.0 onto master sooner than normal. I expect that V8 5.0 will hit stable within the next couple of weeks.
Ref: #5945, #5766.
R=@nodejs/v8
/cc @nodejs/ctcCI: https://ci.nodejs.org/job/node-test-pull-request/2217/ (5.0.71.31)
CI: https://ci.nodejs.org/job/node-test-pull-request/2258/
@nodejs/ctc ... I would like to get this in before cutting the first release candidate for v6 on Monday afternoon but I'd like to get sign off first. If necessary, I can cut the release candidate as a branch off the vee-eight-5.0 branch rebased on the current master but, in general, I think it would be better to go directly off master.
I think it would be safest to make the first RC off a PR/branch like this.
@nodejs/benchmarking Could you run a special run off a branch for comparison, but not actually add to the usual graphs on the website?
Since we have no guarantee that Chromium 50 will go stable in time I think this presents a risk for our schedule and I'd rather not lock it in like this. If 50 doesn't get out during this month then we're going to have to ship with 4.9 and update to 5.0 later on. Locking ourselves in to Chromium's release schedule would be irresponsible when we've put so much work in to communicating our release schedule. So my suggestion is that if you really want to include 5.0 in RC builds then do it off the vee-eight-5.0 branch.
OK. Fortunately and unfortunately I'm behind schedule today so I won't be cutting the v6 RC1 until later this evening or tomorrow (likely tomorrow).
Chrome team have bumped canary branch to v52 it means that they should release v50 to stable in next few weeks, I hope so 🐙
Upgrade to V8 5.0.71.31 in master Upgrade to V8 5.0.71.32 in master
@ofrobots that means this version is the stable branch? (i.e. 5.0.71.x)
Fishrock123, geowarin, dlmanning, ChALkeR, bricss, mgol, krnlde, abenhamdine, flaki, lin7sh, and ubaltaci reacted with hooray emoji
This is the first time I've seen this test failure in SmartOS:
https://ci.nodejs.org/job/node-test-commit-smartos/nodes=smartos14-64/2065/
#
# assert.js:90
# throw new assert.AssertionError({
# ^
# AssertionError: 'This is a unicode text: سلام' == ''
# at process.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-http-default-encoding.js:36:10)
# at emitOne (events.js:95:20)
# at process.emit (events.js:182:7)
# at process.exit (internal/process.js:79:15)
# at ClientRequest.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-http-default-encoding.js:31:13)
# at emitOne (events.js:90:13)
# at ClientRequest.emit (events.js:182:7)
# at Socket.socketErrorListener (_http_client.js:306:9)
# at emitOne (events.js:90:13)
# at Socket.emit (events.js:182:7)
# connect ECONNREFUSED 127.0.0.1:12346
I don't know if it is related or not though.
Rubber-stamp LGTM. Looks like the ARM failure is a flake; the test uses process.on('uncaughtException') - huge red flag. Are you going to squash the two upgrade commits?
V8 5.0 introduced a small modification for the unexpected end of input error.
PR-URL: nodejs#5945 Reviewed-By: bnoordhuis - Ben Noordhuis info@bnoordhuis.nl Reviewed-By: indutny - Fedor Indutny fedor.indutny@gmail.com
PRs that contain breaking changes and should be released in the next major version.
label
jasnell added a commit that referenced this pull request
The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.
- Buffer
- Cluster
- Worker emitted as first argument in 'message' event #5361.
- Crypto
- Dependencies
- DNS
- Add resolvePtr API to query plain DNS PTR records #4921.
- Domains
- Clear stack when no error handler #4659.
- File System
- The
fs.realpath()andfs.realpathSync()methods have been updated to use a more efficient libuv implementation. This change includes the removal of thecacheargument and the method can throw new errors #3594 - FS apis can now accept and return paths as Buffers #5616.
- Error handling and type checking improvements #5616, #5590, #4518, #3917.
- fs.read's string interface is deprecated #4525
- The
- HTTP
- 'clientError' can now be used to return custom errors from an HTTP server #4557.
- Modules
- Net
- Path
- Improved type checking #5348.
- Process
- Readline
- Emit key info unconditionally #6024
- REPL
- Assignment to
_will emit a warning. #5535
- Assignment to
- Timers
- Fail early when callback is not a function #4362
- TLS
- TTY
- Previously deprecated setRawMode wrapper is removed #2528.
- Util
- Changes to Error object formatting #4582.
- Windows
jasnell added a commit that referenced this pull request
The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.
- Buffer
- Cluster
- Worker emitted as first argument in 'message' event #5361.
- Crypto
- Dependencies
- DNS
- Add resolvePtr API to query plain DNS PTR records #4921.
- Domains
- Clear stack when no error handler #4659.
- File System
- The
fs.realpath()andfs.realpathSync()methods have been updated to use a more efficient libuv implementation. This change includes the removal of thecacheargument and the method can throw new errors #3594 - FS apis can now accept and return paths as Buffers #5616.
- Error handling and type checking improvements #5616, #5590, #4518, #3917.
- fs.read's string interface is deprecated #4525
- The
- HTTP
- 'clientError' can now be used to return custom errors from an HTTP server #4557.
- Modules
- Net
- Path
- Improved type checking #5348.
- Process
- Readline
- Emit key info unconditionally #6024
- REPL
- Assignment to
_will emit a warning. #5535
- Assignment to
- Timers
- Fail early when callback is not a function #4362
- TLS
- TTY
- Previously deprecated setRawMode wrapper is removed #2528.
- Util
- Changes to Error object formatting #4582.
- Windows
jasnell pushed a commit that referenced this pull request
jasnell added a commit that referenced this pull request
The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.
- Buffer
- Cluster
- Worker emitted as first argument in 'message' event #5361.
- Crypto
- Dependencies
- DNS
- Add resolvePtr API to query plain DNS PTR records #4921.
- Domains
- Clear stack when no error handler #4659.
- File System
- The
fs.realpath()andfs.realpathSync()methods have been updated to use a more efficient libuv implementation. This change includes the removal of thecacheargument and the method can throw new errors #3594 - FS apis can now accept and return paths as Buffers #5616.
- Error handling and type checking improvements #5616, #5590, #4518, #3917.
- fs.read's string interface is deprecated #4525
- The
- HTTP
- 'clientError' can now be used to return custom errors from an HTTP server #4557.
- Modules
- Net
- OS X
- MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 #6402.
- Path
- Improved type checking #5348.
- Process
- Readline
- Emit key info unconditionally #6024
- REPL
- Assignment to
_will emit a warning. #5535
- Assignment to
- Timers
- Fail early when callback is not a function #4362
- TLS
- TTY
- Previously deprecated setRawMode wrapper is removed #2528.
- Util
- Changes to Error object formatting #4582.
- Windows
jasnell added a commit that referenced this pull request
The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.
- Buffer
- Cluster
- Worker emitted as first argument in 'message' event #5361.
- Crypto
- Dependencies
- DNS
- Add resolvePtr API to query plain DNS PTR records #4921.
- Domains
- Clear stack when no error handler #4659.
- File System
- The
fs.realpath()andfs.realpathSync()methods have been updated to use a more efficient libuv implementation. This change includes the removal of thecacheargument and the method can throw new errors #3594 - FS apis can now accept and return paths as Buffers #5616.
- Error handling and type checking improvements #5616, #5590, #4518, #3917.
- fs.read's string interface is deprecated #4525
- The
- HTTP
- 'clientError' can now be used to return custom errors from an HTTP server #4557.
- Modules
- Net
- OS X
- MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 #6402.
- Path
- Improved type checking #5348.
- Process
- Readline
- Emit key info unconditionally #6024
- REPL
- Assignment to
_will emit a warning. #5535
- Assignment to
- Timers
- Fail early when callback is not a function #4362
- TLS
- TTY
- Previously deprecated setRawMode wrapper is removed #2528.
- Util
- Changes to Error object formatting #4582.
- Windows
jasnell added a commit that referenced this pull request
The following significant (semver-major) changes have been made since the previous Node v5.0.0 release.
- Buffer
- Cluster
- Worker emitted as first argument in 'message' event #5361.
- Crypto
- Dependencies
- DNS
- Add resolvePtr API to query plain DNS PTR records #4921.
- Domains
- Clear stack when no error handler #4659.
- File System
- The
fs.realpath()andfs.realpathSync()methods have been updated to use a more efficient libuv implementation. This change includes the removal of thecacheargument and the method can throw new errors #3594 - FS apis can now accept and return paths as Buffers #5616.
- Error handling and type checking improvements #5616, #5590, #4518, #3917.
- fs.read's string interface is deprecated #4525
- The
- HTTP
- 'clientError' can now be used to return custom errors from an HTTP server #4557.
- Modules
- Net
- OS X
- MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 #6402.
- Path
- Improved type checking #5348.
- Process
- Readline
- Emit key info unconditionally #6024
- REPL
- Assignment to
_will emit a warning. #5535
- Assignment to
- Timers
- Fail early when callback is not a function #4362
- TLS
- TTY
- Previously deprecated setRawMode wrapper is removed #2528.
- Util
- Changes to Error object formatting #4582.
- Windows
Labels
PRs that contain breaking changes and should be released in the next major version.
Issues and PRs related to the V8 dependency.