Add test for fn pointer duplication. by cjgillot · Pull Request #123714 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits3 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
I managed to make it fail when removing provenance checks in GVN.
cc #123670
r? @oli-obk
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
| @@ -0,0 +1,21 @@ |
|---|
| //! Verify that we correctly handle fn pointer provenance in MIR optimizations. |
| //! By asking to inline `static_fnptr::bar`, we have two copies of `static_fnptr::foo`, one in the |
| //! auxiliary crate and one in the local crate CGU. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to rely on foo being automatically marked as inline? Does inline(never) on foo make the issue go away?
If yes it'd be better to mark it as inline explicitly to avoid rely on the auto-inline heuristic.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 4c779d7 has been approved by wesleywiser
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
Add test for fn pointer duplication.
I managed to make it fail when removing provenance checks in GVN.
r? @oli-obk
bors added a commit to rust-lang-ci/rust that referenced this pull request
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Add test for fn pointer duplication.
I managed to make it fail when removing provenance checks in GVN.
r? @oli-obk
bors added a commit to rust-lang-ci/rust that referenced this pull request
jhpratt added a commit to jhpratt/rust that referenced this pull request
Add test for fn pointer duplication.
I managed to make it fail when removing provenance checks in GVN.
r? @oli-obk
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Add test for fn pointer duplication.
I managed to make it fail when removing provenance checks in GVN.
r? @oli-obk
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
Add test for fn pointer duplication.
I managed to make it fail when removing provenance checks in GVN.
r? @oli-obk
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 10 pull requests
Successful merges:
- rust-lang#123714 (Add test for fn pointer duplication.)
- rust-lang#124091 (Update AST validation module docs)
- rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR)
- rust-lang#127015 (Switch back
non_local_definitionslint to allow-by-default) - rust-lang#127016 (docs: check if the disambiguator matches its suffix)
- rust-lang#127029 (Fix Markdown tables in platform-support.md)
- rust-lang#127032 (Enable const casting for
f16andf128) - rust-lang#127041 (Migrate
run-make/override-aliased-flagstormake.rs) - rust-lang#127045 (Rename
super_predicates_ofand similar queries toexplicit_*to note that they're not elaborated) - rust-lang#127075 (rustc_data_structures: Explicitly check for 64-bit atomics support)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 11 pull requests
Successful merges:
- rust-lang#123714 (Add test for fn pointer duplication.)
- rust-lang#124091 (Update AST validation module docs)
- rust-lang#127015 (Switch back
non_local_definitionslint to allow-by-default) - rust-lang#127016 (docs: check if the disambiguator matches its suffix)
- rust-lang#127029 (Fix Markdown tables in platform-support.md)
- rust-lang#127032 (Enable const casting for
f16andf128) - rust-lang#127055 (Mark Hasher::finish as #[must_use])
- rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
- rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
- rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
- rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 11 pull requests
Successful merges:
- rust-lang#123714 (Add test for fn pointer duplication.)
- rust-lang#124091 (Update AST validation module docs)
- rust-lang#127015 (Switch back
non_local_definitionslint to allow-by-default) - rust-lang#127016 (docs: check if the disambiguator matches its suffix)
- rust-lang#127029 (Fix Markdown tables in platform-support.md)
- rust-lang#127032 (Enable const casting for
f16andf128) - rust-lang#127055 (Mark Hasher::finish as #[must_use])
- rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
- rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
- rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
- rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 11 pull requests
Successful merges:
- rust-lang#123714 (Add test for fn pointer duplication.)
- rust-lang#124091 (Update AST validation module docs)
- rust-lang#127015 (Switch back
non_local_definitionslint to allow-by-default) - rust-lang#127016 (docs: check if the disambiguator matches its suffix)
- rust-lang#127029 (Fix Markdown tables in platform-support.md)
- rust-lang#127032 (Enable const casting for
f16andf128) - rust-lang#127055 (Mark Hasher::finish as #[must_use])
- rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
- rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
- rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
- rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#123714 - cjgillot:static-fnptr, r=wesleywiser
Add test for fn pointer duplication.
I managed to make it fail when removing provenance checks in GVN.
r? @oli-obk
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.