Enable const casting for f16 and f128 by tgross35 · Pull Request #127032 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

I have an open PR to the Miri repo adding tests for this behavior rust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version of rust-lang/miri#3688.

Cc @RalfJung

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jun 27, 2024

📌 Commit 648cb16 has been approved by oli-obk

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 27, 2024

Technically you should be able to test this from const eval now, right?

Yeah I think this unblocks the only exposed codepath, the remaining changes in miri are just intrinsics that we don't have library functions for. Miri just has a good structure for casting tests so it seems easiest to make use of what is there

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Jun 27, 2024

… r=oli-obk

Enable const casting for f16 and f128

I have an open PR to the Miri repo adding tests for this behavior rust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version of rust-lang/miri#3688.

Cc @RalfJung

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 27, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 27, 2024

… r=oli-obk

Enable const casting for f16 and f128

I have an open PR to the Miri repo adding tests for this behavior rust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version of rust-lang/miri#3688.

Cc @RalfJung

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 27, 2024

jhpratt added a commit to jhpratt/rust that referenced this pull request

Jun 28, 2024

… r=oli-obk

Enable const casting for f16 and f128

I have an open PR to the Miri repo adding tests for this behavior rust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version of rust-lang/miri#3688.

Cc @RalfJung

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 28, 2024

… r=oli-obk

Enable const casting for f16 and f128

I have an open PR to the Miri repo adding tests for this behavior rust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version of rust-lang/miri#3688.

Cc @RalfJung

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 28, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 28, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Jun 28, 2024

… r=oli-obk

Enable const casting for f16 and f128

I have an open PR to the Miri repo adding tests for this behavior rust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version of rust-lang/miri#3688.

Cc @RalfJung

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 28, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 28, 2024

…llaumeGomez

Rollup of 10 pull requests

Successful merges:

• rust-lang#123714 (Add test for fn pointer duplication.)
• rust-lang#124091 (Update AST validation module docs)
• rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR)
• rust-lang#127015 (Switch back non_local_definitions lint to allow-by-default)
• rust-lang#127016 (docs: check if the disambiguator matches its suffix)
• rust-lang#127029 (Fix Markdown tables in platform-support.md)
• rust-lang#127032 (Enable const casting for f16 and f128)
• rust-lang#127041 (Migrate run-make/override-aliased-flags to rmake.rs)
• rust-lang#127045 (Rename super_predicates_of and similar queries to explicit_* to note that they're not elaborated)
• rust-lang#127075 (rustc_data_structures: Explicitly check for 64-bit atomics support)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 28, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 28, 2024

…iaskrgr

Rollup of 11 pull requests

Successful merges:

• rust-lang#123714 (Add test for fn pointer duplication.)
• rust-lang#124091 (Update AST validation module docs)
• rust-lang#127015 (Switch back non_local_definitions lint to allow-by-default)
• rust-lang#127016 (docs: check if the disambiguator matches its suffix)
• rust-lang#127029 (Fix Markdown tables in platform-support.md)
• rust-lang#127032 (Enable const casting for f16 and f128)
• rust-lang#127055 (Mark Hasher::finish as #[must_use])
• rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
• rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
• rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
• rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

…iaskrgr

Rollup of 11 pull requests

Successful merges:

• rust-lang#123714 (Add test for fn pointer duplication.)
• rust-lang#124091 (Update AST validation module docs)
• rust-lang#127015 (Switch back non_local_definitions lint to allow-by-default)
• rust-lang#127016 (docs: check if the disambiguator matches its suffix)
• rust-lang#127029 (Fix Markdown tables in platform-support.md)
• rust-lang#127032 (Enable const casting for f16 and f128)
• rust-lang#127055 (Mark Hasher::finish as #[must_use])
• rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
• rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
• rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
• rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

…iaskrgr

Rollup of 11 pull requests

Successful merges:

• rust-lang#123714 (Add test for fn pointer duplication.)
• rust-lang#124091 (Update AST validation module docs)
• rust-lang#127015 (Switch back non_local_definitions lint to allow-by-default)
• rust-lang#127016 (docs: check if the disambiguator matches its suffix)
• rust-lang#127029 (Fix Markdown tables in platform-support.md)
• rust-lang#127032 (Enable const casting for f16 and f128)
• rust-lang#127055 (Mark Hasher::finish as #[must_use])
• rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
• rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
• rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
• rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

Rollup merge of rust-lang#127032 - tgross35:f16-f128-const-eval-cast, r=oli-obk

Enable const casting for f16 and f128

I have an open PR to the Miri repo adding tests for this behavior rust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version of rust-lang/miri#3688.

Cc @RalfJung

tgross35 deleted the f16-f128-const-eval-cast branch

June 29, 2024 07:17

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.