docs: check if the disambiguator matches its suffix by bvanjoi · Pull Request #127016 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation13 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Fixes #126986

This PR makes it will not continue resolving when its disambiguator doesn't match the suffix format.

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

labels

Jun 27, 2024

As far as I can see, it doesn't resolve #126986. The issue is that the macro is defined after the doc comment without #[macro_export], meaning that the compiler will only see it after the doc comment is processed.

Just to add more information: maybe I'm wrong, but in this case, please add a test without #[macro_export] to confirm it and then it can be approved and merged.

If CI is happy, I'll approve it. Thanks for working on this. :)

@bors r=GuillaumeGomez,notriddle

📌 Commit 6400a4f has been approved by GuillaumeGomez,notriddle

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 27, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Jun 27, 2024

…ez,notriddle

docs: check if the disambiguator matches its suffix

Fixes rust-lang#126986

This PR makes it will not continue resolving when its disambiguator doesn't match the suffix format.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 27, 2024

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add:

//@ normalize-stderr-test: "nightly|beta|1\.[0-9][0-9]\.[0-9]" -> "$$CHANNEL"

And then to remove and regenerate stderr files (for both tests).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only necessary if the stderr has a URL in it. That one doesn't.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like they said. :)

This time it should be all good to go. Thanks again!

@bors r+ rollup

📌 Commit 91d3ac7 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jun 28, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Jun 28, 2024

docs: check if the disambiguator matches its suffix

Fixes rust-lang#126986

This PR makes it will not continue resolving when its disambiguator doesn't match the suffix format.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 28, 2024

…llaumeGomez

Rollup of 10 pull requests

Successful merges:

• rust-lang#123714 (Add test for fn pointer duplication.)
• rust-lang#124091 (Update AST validation module docs)
• rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR)
• rust-lang#127015 (Switch back non_local_definitions lint to allow-by-default)
• rust-lang#127016 (docs: check if the disambiguator matches its suffix)
• rust-lang#127029 (Fix Markdown tables in platform-support.md)
• rust-lang#127032 (Enable const casting for f16 and f128)
• rust-lang#127041 (Migrate run-make/override-aliased-flags to rmake.rs)
• rust-lang#127045 (Rename super_predicates_of and similar queries to explicit_* to note that they're not elaborated)
• rust-lang#127075 (rustc_data_structures: Explicitly check for 64-bit atomics support)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 28, 2024

…iaskrgr

Rollup of 11 pull requests

Successful merges:

• rust-lang#123714 (Add test for fn pointer duplication.)
• rust-lang#124091 (Update AST validation module docs)
• rust-lang#127015 (Switch back non_local_definitions lint to allow-by-default)
• rust-lang#127016 (docs: check if the disambiguator matches its suffix)
• rust-lang#127029 (Fix Markdown tables in platform-support.md)
• rust-lang#127032 (Enable const casting for f16 and f128)
• rust-lang#127055 (Mark Hasher::finish as #[must_use])
• rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
• rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
• rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
• rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

…iaskrgr

Rollup of 11 pull requests

Successful merges:

• rust-lang#123714 (Add test for fn pointer duplication.)
• rust-lang#124091 (Update AST validation module docs)
• rust-lang#127015 (Switch back non_local_definitions lint to allow-by-default)
• rust-lang#127016 (docs: check if the disambiguator matches its suffix)
• rust-lang#127029 (Fix Markdown tables in platform-support.md)
• rust-lang#127032 (Enable const casting for f16 and f128)
• rust-lang#127055 (Mark Hasher::finish as #[must_use])
• rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
• rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
• rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
• rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

…iaskrgr

Rollup of 11 pull requests

Successful merges:

• rust-lang#123714 (Add test for fn pointer duplication.)
• rust-lang#124091 (Update AST validation module docs)
• rust-lang#127015 (Switch back non_local_definitions lint to allow-by-default)
• rust-lang#127016 (docs: check if the disambiguator matches its suffix)
• rust-lang#127029 (Fix Markdown tables in platform-support.md)
• rust-lang#127032 (Enable const casting for f16 and f128)
• rust-lang#127055 (Mark Hasher::finish as #[must_use])
• rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
• rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
• rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
• rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

Rollup merge of rust-lang#127016 - bvanjoi:fix-126986, r=GuillaumeGomez

docs: check if the disambiguator matches its suffix

Fixes rust-lang#126986

This PR makes it will not continue resolving when its disambiguator doesn't match the suffix format.

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.